From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7585C31E44 for ; Fri, 14 Jun 2019 09:23:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B6E72133D for ; Fri, 14 Jun 2019 09:23:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="u59wIOzf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B6E72133D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=triplefau.lt Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tBOvq5vvWPaleB7VioFZG6ghNdvBxa5vU/yiFveAsrg=; b=u59wIOzfHEHnSV IVxVwqLSY0Ht0Y3oSTPMAwcy/EkhCqq3PZdiUaOVx1chXjZocqRDxsRm8a0Q0Ja/7Hs1qM+NddP6u FO2V+Tfse5PefRyoVGJCboK/mT1TFkEGQ88rKeEtQJjfarBDFV4Hn8Dvsm+gMNLLyzpZFJrExJBUd ri7cbGIyBipECbnO8h1ZhSpo/HyKvacfBxUcWc8flEK2Emy9LHBkR6RwvUkUEq1EHtPsSkg+lYF98 UmfhcPLsXtwiTsB3mfL4YC5uKaOP8E0+aif/RnFT/3xM7BKAmXZuGy+VH5ZVVUMSOS5HHXWn893Ne 0N+ln0l5/0fxo4+yomhQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hbiR5-0008An-Bi; Fri, 14 Jun 2019 09:23:51 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hbiR2-00089Y-RT for linux-arm-kernel@lists.infradead.org; Fri, 14 Jun 2019 09:23:50 +0000 X-Originating-IP: 88.190.179.123 Received: from localhost (unknown [88.190.179.123]) (Authenticated sender: repk@triplefau.lt) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 2E5FE240018; Fri, 14 Jun 2019 09:23:34 +0000 (UTC) Date: Fri, 14 Jun 2019 11:33:21 +0200 From: Remi Pommarel To: Thomas Petazzoni Subject: Re: [PATCH v2] PCI: aardvark: Fix PCI_EXP_RTCTL conf register writing Message-ID: <20190614093320.GC12859@voidbox.localdomain> References: <20190614064225.24434-1-repk@triplefau.lt> <20190614105854.4c2f270f@windsurf> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190614105854.4c2f270f@windsurf> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190614_022349_053454_68181F4F X-CRM114-Status: GOOD ( 11.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ellie Reeves , Lorenzo Pieralisi , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, On Fri, Jun 14, 2019 at 10:58:54AM +0200, Thomas Petazzoni wrote: > Hello, > > On Fri, 14 Jun 2019 08:42:25 +0200 > Remi Pommarel wrote: > > > PCI_EXP_RTCTL is used to activate PME interrupt only, so writing into it > > should not modify other interrupts' mask. The ISR mask polarity was also > > inverted, when PCI_EXP_RTCTL_PMEIE is set PCIE_MSG_PM_PME_MASK mask bit > > should actually be cleared. > > > > Fixes: 6302bf3ef78d ("PCI: Init PCIe feature bits for managed host bridge alloc") > > Are you sure about this Fixes tag ? This commit seems unrelated. > > The commit introducing this issue is 8a3ebd8de328301aacbe328650a59253be2ac82c. The 6302bf3ef78d commit fixes PCI bridge's PME flag which introduces the configuration of PCI_EXP_RTCTL register (which wasn't used before). So, yes, PCI_EXP_RTCTL conf was flawed since 8a3ebd8de328 but the infinite interrupt loop happens only since that 6302bf3ef78d has fixed this PME flag bug. I chose to use 6302bf3ef78d because it was the one commit triggering the bug during my bisect process, but yes maybe using the commit that introduced (even if it was silently) the problem makes more sense. So if you want I can do a v3 with this Fixes tag modification. -- Remi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel