From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A261C31E44 for ; Fri, 14 Jun 2019 08:59:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E698220866 for ; Fri, 14 Jun 2019 08:59:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KtbQhqfh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E698220866 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5cOnGqOfPQJ8IFRhV3yD9/o2GGzCvTwOyJHT7UGNl54=; b=KtbQhqfhnuvRal GFvzB1LmnAajYSyilr0IZAVyzKPL1nMBzslVVFMBfEIi3BkeZx7DDk49hB+bTzlewBwcgDe0zTO/V U4T/U9AQQZ2xOSjsdwapx/fU60C58AFnZQTlRnEhKKDlYOa+aJ5Y3VBrdLnGZwnjPgqLgxuDEtfq9 TsnLHzIMqzk7Zm+OzxVa9+8zxiR6hNlfVknxGA+lCK//dyz2d3MarNMCqJhZdJAhrqSUZcPC9WV5M Ib+6HHEVhmi/mOcWVd8dXhwM/X2WfkbTi8eQAT9aPXfq8uV7n/l+B3O3GUxMYmldmRpo6fJgNXTIs sEjY5h/CTpB23DNFdvpQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hbi3I-0001tT-7J; Fri, 14 Jun 2019 08:59:16 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hbi3E-0001ru-TT for linux-arm-kernel@lists.infradead.org; Fri, 14 Jun 2019 08:59:14 +0000 Received: from windsurf (aaubervilliers-681-1-81-150.w90-88.abo.wanadoo.fr [90.88.23.150]) (Authenticated sender: thomas.petazzoni@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id C61A6240007; Fri, 14 Jun 2019 08:58:55 +0000 (UTC) Date: Fri, 14 Jun 2019 10:58:54 +0200 From: Thomas Petazzoni To: Remi Pommarel Subject: Re: [PATCH v2] PCI: aardvark: Fix PCI_EXP_RTCTL conf register writing Message-ID: <20190614105854.4c2f270f@windsurf> In-Reply-To: <20190614064225.24434-1-repk@triplefau.lt> References: <20190614064225.24434-1-repk@triplefau.lt> Organization: Bootlin X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190614_015913_114130_167D6C46 X-CRM114-Status: UNSURE ( 7.99 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ellie Reeves , Lorenzo Pieralisi , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, On Fri, 14 Jun 2019 08:42:25 +0200 Remi Pommarel wrote: > PCI_EXP_RTCTL is used to activate PME interrupt only, so writing into it > should not modify other interrupts' mask. The ISR mask polarity was also > inverted, when PCI_EXP_RTCTL_PMEIE is set PCIE_MSG_PM_PME_MASK mask bit > should actually be cleared. > > Fixes: 6302bf3ef78d ("PCI: Init PCIe feature bits for managed host bridge alloc") Are you sure about this Fixes tag ? This commit seems unrelated. The commit introducing this issue is 8a3ebd8de328301aacbe328650a59253be2ac82c. Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel