From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 702F5C31E44 for ; Sat, 15 Jun 2019 03:08:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3994621473 for ; Sat, 15 Jun 2019 03:08:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="e+27JCzy"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="nLJrviAA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3994621473 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3hdJP0l/qaNFDGTz/tyB40X+vuQn2rzBRx+pYX+at0M=; b=e+27JCzy9I8nBr tHI/iYRB4LHHvn7yrrSWZlIVU9Pz6QvAfWzW9+yCeZKBPadJ5R23BcXMQ/9AkWjA5bE3pAdTivReV Fs2ChX86JawtCHK5zK5SuxEK/6cr5bO/no+tcK5TybbohbQTw9ABJ7OTRMt5jRJfYphuHqu4hwnFP WpF/fVLjfTI3zfu3LGlIQirToqPl+4dfuUCFz5iSauMYDNIIB296F5pkpuhbvcBlS90XgkDVbGzFS H7MV1dWzRe5Nb39suceIAfaSUmMIBBJ3+RNfrGswSwgtOaVoMRdUj8c1nGYkdU8GQctEjw06nXpIS k1XDxqaXA9R+0tuXx0mg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hbz3g-0000Bc-GS; Sat, 15 Jun 2019 03:08:48 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hbz3d-0000B8-GW for linux-arm-kernel@lists.infradead.org; Sat, 15 Jun 2019 03:08:46 +0000 Received: by mail-pg1-x543.google.com with SMTP id k187so2585313pga.0 for ; Fri, 14 Jun 2019 20:08:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=s3h9liOL4pzy4K3mokxNpyJvGGWg+jIohBl0u3f0MSw=; b=nLJrviAAsir3PYO/XtH16yQzp8ONsbHuhdT8WIRi/kJGgxZSSD55ofOhQDDYeUdiu0 A7bYKKKzCmbwF1kdcQlqcIp/DseAP6aT5PVkQZaEIVEVBXstCULU0UiiNAXsNo5l2zrV gUD/9w6GoXQk/0PpZRJIVFj+/Sv4EozCcSF+I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=s3h9liOL4pzy4K3mokxNpyJvGGWg+jIohBl0u3f0MSw=; b=d6wIwB8XTTXVptKdCAFffwwJEPNNYVlyJQpnZQJPyykoTtEw7yyu73C3fHHxNawmMy 7VJFn3FRygJojyevsNr/njNf5zRKOkUI8Ewjjg6WAD//2AakKCZv0M7n9bcTUkWAsNc2 OCPIKNTP+UpQJHvlzsHvCqx+QYPcQdneqrGvaz6zvGH8pyK7bgGzwb1AvqxVZoyVOBk7 MIi5aQwJdz31ejxauDogBcNnw9rOdrZxT8/3kfZ8HlZBu8Z3FlrJOb65cSxGzbt0qjVR WTPm1y8WCmmkcZ12KvOTqmBtlpaLpEKn8thbnokqEOcCB5ZQqPMkm+votvpLXlnQHUsz 6crw== X-Gm-Message-State: APjAAAUk3yAiYl9w9eHX1jJhCwzaobXIaSJoqBZRqU5pSJAwZmRj0D2s DHjnzwW8EElBqRN/11zcuJUNzA== X-Google-Smtp-Source: APXvYqxIMz0tLLWT+ykuDfGa2gdns1WEiGTzOvYHKMsnAh3J26q1NOxQ3TGblUcsPdaDOSE8lxsQOg== X-Received: by 2002:a63:f402:: with SMTP id g2mr37256655pgi.197.1560568124036; Fri, 14 Jun 2019 20:08:44 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id m20sm4057774pjn.16.2019.06.14.20.08.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 14 Jun 2019 20:08:43 -0700 (PDT) Date: Fri, 14 Jun 2019 20:08:42 -0700 From: Kees Cook To: Jann Horn Subject: Re: [PATCH] security: do not enable CONFIG_GCC_PLUGINS by default Message-ID: <201906142002.833D224C6F@keescook> References: <20190614145755.10926-1-GNUtoo@cyberdimension.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190614_200845_577776_E37F452D X-CRM114-Status: GOOD ( 12.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kernel Hardening , Russell King , Paul Kocialkowski , Emese Revfy , Denis 'GNUtoo' Carikli , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 14, 2019 at 06:05:19PM +0200, Jann Horn wrote: > On Fri, Jun 14, 2019 at 5:10 PM Denis 'GNUtoo' Carikli > wrote: > > Booting was broken by the following commit: > > 9f671e58159a ("security: Create "kernel hardening" config area") > > I don't think GCC_PLUGINS alone is supposed to generate any code? It > just makes it possible to enable a bunch of other kconfig flags that > can generate code. > > STACKPROTECTOR_PER_TASK defaults to y and depends on GCC_PLUGINS, so > is that perhaps what broke? Can you try whether disabling just that > works for you? Yes, this has come up before: the option you want to disable is as Jann mentions: CONFIG_STACKPROTECTOR_PER_TASK. > My guess is that maybe there is some early boot code that needs to > have the stack protector disabled, or something like that. Right, though I'm not sure what portion would be specific to that device. You can turn off SSP on a per-file basis with: CFLAGS_target.o += $(DISABLE_ARM_SSP_PER_TASK_PLUGIN) or per-Makefile, as in arch/arm/boot/compressed/Makefile. -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel