From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B77BFC31E49 for ; Sun, 16 Jun 2019 08:59:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 855B221473 for ; Sun, 16 Jun 2019 08:59:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LkL9ZqbL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 855B221473 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+OaVzn8sYgK/Zqly+BFRyyIbfZRPVtdvehKrpPTZKlo=; b=LkL9ZqbLbZ1Gla IGqnBJVhcrx4gKpfgB+tzAwoMcmcxdpXZOA5lvsThuBdusV+de5HAgdW+O1DmrJzCMMZ2gN6LnKO+ E5jvmAbtdj82pEOLKTT6au5/DNcb+wDPkLy8HnDg2O9YNkn9O7DzKZx40HNExR98epe4R+XNso4mQ i55BjG5lpljY+ZfjtcEM25AxbZkKYyDrLC6p2BTWKJ2oxDHoFHS6YxY/2nUHKCDVwAuKjZsKK97C9 sZd7sEHZ5kueC8boK2w0ypjH2oldhFDzaeI8IF3YI/GaRMYMEa+TtFiRUUFN+AL1rezbajUTR+oQf OThoq6I9yqqmgRr+TILA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hcR0o-00062y-Ix; Sun, 16 Jun 2019 08:59:42 +0000 Received: from mail-wm1-f68.google.com ([209.85.128.68]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hcR0k-00062K-WD for linux-arm-kernel@lists.infradead.org; Sun, 16 Jun 2019 08:59:40 +0000 Received: by mail-wm1-f68.google.com with SMTP id v19so6066762wmj.5 for ; Sun, 16 Jun 2019 01:59:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ITLiVQZ3ttHS2OCmJVdr2pwqDxExpjxblx6QJpo79NY=; b=R8hM5gor7DTjHrJ5Xx3Kp8zlTE04eaJHQSXS4gdHeThe+e9IHek1H83Sv0zzYSsHIW aF327F3lsxZIkCANckNNI57DLgXoJdxHiMsTNu3A+YYfQK9BcmahdaDwAoadXe9lGJom IIcr3x5G3/tJqzIrYS9FfEobv3T1BenGJbHfqrHk5gUQQu68aLZb0lJXKmgKw/uXJgLp pvUKIviiABWhOCPXqQwuSrbN9P1WWrLke1QEwPlupDmsj0m5rKLBL0AgtnWFxNinqfzQ jlBm/Z6+H62d8CkLEsNi42WCZMepRmBse0ZsLK/pjTnKKwivBfpdxUqJAsRHz3/DmEms d0lQ== X-Gm-Message-State: APjAAAW7HMmMl2mMpZJChltrKJPrmnHlUKDQ+s309q+M/xj3tiVGx8Wk HljMu7WN4CyTic6Vmldf7Ls= X-Google-Smtp-Source: APXvYqzSFlADfZGpYrtAtOjU/NYmJZYEAkWsu4on1+2TMhvgCshgH31ng4O8HIUzQ+YcUwFU6kLTWA== X-Received: by 2002:a1c:6156:: with SMTP id v83mr9069782wmb.81.1560675571337; Sun, 16 Jun 2019 01:59:31 -0700 (PDT) Received: from kozik-lap ([194.230.155.186]) by smtp.googlemail.com with ESMTPSA id s7sm4514716wmc.2.2019.06.16.01.59.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 16 Jun 2019 01:59:30 -0700 (PDT) Date: Sun, 16 Jun 2019 10:59:28 +0200 From: Krzysztof Kozlowski To: Joseph Kogut Subject: Re: [PATCH v2 2/2] arm: dts: add ARM Mali GPU node for Odroid XU3 Message-ID: <20190616085928.GB3826@kozik-lap> References: <20190614203144.3850-2-joseph.kogut@gmail.com> <20190614235719.8134-1-joseph.kogut@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190614235719.8134-1-joseph.kogut@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190616_015939_039780_36F5559A X-CRM114-Status: GOOD ( 15.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, airlied@linux.ie, dri-devel@lists.freedesktop.org, robh+dt@kernel.org, kgene@kernel.org, daniel@ffwll.ch, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 14, 2019 at 04:57:19PM -0700, Joseph Kogut wrote: > Add device tree node for mali gpu on Odroid XU3 SoCs. > > Signed-off-by: Joseph Kogut > --- > > Changes v1 -> v2: > - Use interrupt name ordering from binding doc > - Specify a single clock for GPU node > - Add gpu opp table > - Fix warnings from IRQ_TYPE_NONE > > .../boot/dts/exynos5422-odroidxu3-common.dtsi | 26 +++++++++++++++++++ This should go to exynos5422-odroid-core.dtsi instead, because it is common to entire Odroid Exynos5422 family (not only XU3 family). > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > index 93a48f2dda49..b8a4246e3b37 100644 > --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > @@ -48,6 +48,32 @@ > cooling-levels = <0 130 170 230>; > }; > > + gpu: gpu@11800000 { > + compatible = "samsung,exynos-mali", "arm,mali-t628"; This is common to all Exynos542x chips so it should go to exynos5420.dtsi. Here you would need to only enable it and provide regulator. Probably this should be also associated with tmu_gpu as a cooling device (if Mali registers a cooling device...). Otherwise the tmu_gpu is not really used for it. > + reg = <0x11800000 0x5000>; > + interrupts = , > + , > + ; > + interrupt-names = "job", "mmu", "gpu"; > + clocks = <&clock CLK_G3D>; > + mali-supply = <&buck4_reg>; Please check if always-on property could be removed from buck4. Also, what about LDO27? It should be used as well (maybe through vendor-specific properties which would justify the need of new vendor compatible). Best regards, Krzysztof > + operating-points-v2 = <&gpu_opp_table>; > + }; > + > + gpu_opp_table: gpu-opp-table { > + compatible = "operating-points-v2"; > + > + opp-177000000 { > + opp-hz = /bits/ 64 <117000000>; > + opp-microvolt = <812500>; > + }; > + > + opp-600000000 { > + opp-hz = /bits/ 64 <600000000>; > + opp-microvolt = <1150000>; > + }; > + }; > + > thermal-zones { > cpu0_thermal: cpu0-thermal { > thermal-sensors = <&tmu_cpu0 0>; > -- > 2.22.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel