From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E9DBC31E5E for ; Tue, 18 Jun 2019 06:54:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4250720665 for ; Tue, 18 Jun 2019 06:54:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XiAuB1G0"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="oBvX088a" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4250720665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aYBOKbtZZd7CyN/zQMWtZgrdCCaBJIO3aZHqNcG/SfA=; b=XiAuB1G0uFK3w1 IC+hZeKkUyeO/Hkv985ueOylKmB5uD639p8BjCWEQOymiH5HwxGvan74OfKEY5wauL5d5TiXjqxvM Gvoy1BnNoBMyck7h0bk2KU6moCdJuMroRGAo9NfEks22yIcgtHRNPqWnxg2a9p2ykmqH/neQICWO3 7MiGVBMpyMxP4F6NxGa08CtkM8+EMpvSmlpv2Fx8/H87LXKP21oC0ggBani1HTj55QT1YovsNW3T1 znFOW9bcFrwjHYfgbVNLMF7yXTy+58xo093IrrW4kXTW2Xs9idNZ8J9pnNRP54j73KSRgZaPAmClc AIKyjUGuFseYPGa5M9AQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hd80e-0001ni-Pu; Tue, 18 Jun 2019 06:54:24 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hd80c-0001nJ-6j for linux-arm-kernel@lists.infradead.org; Tue, 18 Jun 2019 06:54:23 +0000 Received: from brain-police (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AB0AB20665; Tue, 18 Jun 2019 06:54:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560840861; bh=h6KCEecYqvEUsVXMGsOj14p5VeuD+CI26MOesVKK8tw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oBvX088a/fOuuObjn7+ntF6Kq5hoY2/4Hpn4C9r/FHAPQ18VfSrKIN6FL5H8J8wzc BBR26SXGwC+04hPIj6pp4cWe3SMe5tW99SFutH5DZAbPe6caLBBE0uSV5X3hETFvma RU/jAfOdqr0dwXiPJhdVASX8az+JIm0olJ4+olBE= Date: Tue, 18 Jun 2019 07:54:15 +0100 From: Will Deacon To: Mike Rapoport Subject: Re: [PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc() Message-ID: <20190618065414.GA15875@brain-police> References: <1559656836-24940-1-git-send-email-cai@lca.pw> <20190604142338.GC24467@lakrids.cambridge.arm.com> <20190610114326.GF15979@fuggles.cambridge.arm.com> <1560187575.6132.70.camel@lca.pw> <20190611100348.GB26409@lakrids.cambridge.arm.com> <20190613121100.GB25164@rapoport-lnx> <20190617151252.GF16810@rapoport-lnx> <20190617163630.GH30800@fuggles.cambridge.arm.com> <20190618061259.GB15497@rapoport-lnx> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190618061259.GB15497@rapoport-lnx> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190617_235422_286546_F6FC8CD4 X-CRM114-Status: GOOD ( 19.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , catalin.marinas@arm.com, Will Deacon , linux-kernel@vger.kernel.org, mhocko@kernel.org, linux-mm@kvack.org, Qian Cai , vdavydov.dev@gmail.com, hannes@cmpxchg.org, cgroups@vger.kernel.org, akpm@linux-foundation.org, Roman Gushchin , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 18, 2019 at 09:12:59AM +0300, Mike Rapoport wrote: > On Mon, Jun 17, 2019 at 05:36:30PM +0100, Will Deacon wrote: > > On Mon, Jun 17, 2019 at 06:12:52PM +0300, Mike Rapoport wrote: > > > Andrew, can you please add the patch below as an incremental fix? > > > > > > With this the arm64::pgd_alloc() should be in the right shape. > > > > > > > > > From 1c1ef0bc04c655689c6c527bd03b140251399d87 Mon Sep 17 00:00:00 2001 > > > From: Mike Rapoport > > > Date: Mon, 17 Jun 2019 17:37:43 +0300 > > > Subject: [PATCH] arm64/mm: don't initialize pgd_cache twice > > > > > > When PGD_SIZE != PAGE_SIZE, arm64 uses kmem_cache for allocation of PGD > > > memory. That cache was initialized twice: first through > > > pgtable_cache_init() alias and then as an override for weak > > > pgd_cache_init(). > > > > > > After enabling accounting for the PGD memory, this created a confusion for > > > memcg and slub sysfs code which resulted in the following errors: > > > > > > [ 90.608597] kobject_add_internal failed for pgd_cache(13:init.scope) (error: -2 parent: cgroup) > > > [ 90.678007] kobject_add_internal failed for pgd_cache(13:init.scope) (error: -2 parent: cgroup) > > > [ 90.713260] kobject_add_internal failed for pgd_cache(21:systemd-tmpfiles-setup.service) (error: -2 parent: cgroup) > > > > > > Removing the alias from pgtable_cache_init() and keeping the only pgd_cache > > > initialization in pgd_cache_init() resolves the problem and allows > > > accounting of PGD memory. > > > > > > Reported-by: Qian Cai > > > Signed-off-by: Mike Rapoport > > > --- > > > arch/arm64/include/asm/pgtable.h | 3 +-- > > > arch/arm64/mm/pgd.c | 5 +---- > > > 2 files changed, 2 insertions(+), 6 deletions(-) > > > > Looks like this actually fixes caa841360134 ("x86/mm: Initialize PGD cache > > during mm initialization") due to an unlucky naming conflict! > > > > In which case, I'd actually prefer to take this fix asap via the arm64 > > tree. Is that ok? > > I suppose so, it just won't apply as is. Would you like a patch against the > current upstream? Yes, please. I'm assuming it's a straightforward change (please shout if it isn't). Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel