From: Shawn Guo <shawnguo@kernel.org>
To: Anson.Huang@nxp.com
Cc: abel.vesa@nxp.com, viresh.kumar@linaro.org,
s.hauer@pengutronix.de, linux-kernel@vger.kernel.org,
Linux-imx@nxp.com, kernel@pengutronix.de,
leonard.crestez@nxp.com, festevam@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] soc: imx: Add i.MX8MN SoC driver support
Date: Tue, 18 Jun 2019 15:03:35 +0800 [thread overview]
Message-ID: <20190618070334.GD29881@dragon> (raw)
In-Reply-To: <20190611013125.3434-1-Anson.Huang@nxp.com>
On Tue, Jun 11, 2019 at 09:31:25AM +0800, Anson.Huang@nxp.com wrote:
> From: Anson Huang <Anson.Huang@nxp.com>
>
> This patch adds i.MX8MN SoC driver support:
>
> root@imx8mnevk:~# cat /sys/devices/soc0/family
> Freescale i.MX
>
> root@imx8mnevk:~# cat /sys/devices/soc0/machine
> NXP i.MX8MNano DDR4 EVK board
>
> root@imx8mnevk:~# cat /sys/devices/soc0/soc_id
> i.MX8MN
>
> root@imx8mnevk:~# cat /sys/devices/soc0/revision
> 1.0
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> drivers/soc/imx/soc-imx8.c | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/imx/soc-imx8.c b/drivers/soc/imx/soc-imx8.c
> index 3842d09..02309a2 100644
> --- a/drivers/soc/imx/soc-imx8.c
> +++ b/drivers/soc/imx/soc-imx8.c
> @@ -55,7 +55,12 @@ static u32 __init imx8mm_soc_revision(void)
> void __iomem *anatop_base;
> u32 rev;
>
> - np = of_find_compatible_node(NULL, NULL, "fsl,imx8mm-anatop");
> + if (of_machine_is_compatible("fsl,imx8mm"))
> + np = of_find_compatible_node(NULL, NULL, "fsl,imx8mm-anatop");
> + else if (of_machine_is_compatible("fsl,imx8mn"))
> + np = of_find_compatible_node(NULL, NULL, "fsl,imx8mn-anatop");
Can we have this anatop compatible in imx8_soc_data, so that we may save
the call to of_machine_is_compatible()?
Shawn
> + else
> + np = NULL;
> if (!np)
> return 0;
>
> @@ -79,9 +84,15 @@ static const struct imx8_soc_data imx8mm_soc_data = {
> .soc_revision = imx8mm_soc_revision,
> };
>
> +static const struct imx8_soc_data imx8mn_soc_data = {
> + .name = "i.MX8MN",
> + .soc_revision = imx8mm_soc_revision,
> +};
> +
> static const struct of_device_id imx8_soc_match[] = {
> { .compatible = "fsl,imx8mq", .data = &imx8mq_soc_data, },
> { .compatible = "fsl,imx8mm", .data = &imx8mm_soc_data, },
> + { .compatible = "fsl,imx8mn", .data = &imx8mn_soc_data, },
> { }
> };
>
> --
> 2.7.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-18 7:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 1:31 [PATCH] soc: imx: Add i.MX8MN SoC driver support Anson.Huang
2019-06-18 7:03 ` Shawn Guo [this message]
2019-06-18 8:24 ` Anson Huang
2019-06-18 12:59 ` Shawn Guo
2019-06-19 1:06 ` Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618070334.GD29881@dragon \
--to=shawnguo@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=Linux-imx@nxp.com \
--cc=abel.vesa@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).