From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5FAFC31E51 for ; Tue, 18 Jun 2019 07:04:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8271F20673 for ; Tue, 18 Jun 2019 07:04:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rYkrEp4G"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="t5Cp/sFZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8271F20673 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+S3zCO2mtsP3hN7s/Dzcge1kq6aSkgCpmJXZJKwMFUs=; b=rYkrEp4GjDigtw xOVsjbScYtfrZe6BaAfwBtSWszESEJRp6syPCIIHfdt+F1DSOUVJFDuD9HF0lgzwev6Zk2TKTXKvD OT8eyI2QllkA+ctIcKH386J23fg0sRHq9Al2mSsq1agwCXEEjm1h7R8ACoUpnB4DkSYkOKb0qj+5f RcVVp6UY/cE2CYras6BjoinDG9CKPisvB83jkZDsm0DXfhtHMx6cx+G34TUq2bPaxjRCr6pkYwUHG h8E0PA5+ZcGp56kmtJdc02HBmMJfDJRiJyotO/Io9IfPahZiQOnTl1VtHlcWikzpG/TWEhlgrQv4J izzusHWp4Dvn60elWplA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hd8AO-0008NZ-Vy; Tue, 18 Jun 2019 07:04:29 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hd8AM-0008N4-9L for linux-arm-kernel@lists.infradead.org; Tue, 18 Jun 2019 07:04:27 +0000 Received: from dragon (li1322-146.members.linode.com [45.79.223.146]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8711B20665; Tue, 18 Jun 2019 07:04:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560841465; bh=bm2DKq2EIZtKPTiAVRzsCQniXdUMQeaYWYo40ocVKd0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=t5Cp/sFZYyd4zhxGNyiMT4RVBJ5dQioW+ujYpGLtOqgTXmP3MlE8ATBKOkjUQH+V0 AuhyNNvZtXrsMJYnjJ8dT1b6ddzRNmKMq6YzBez9UJhI50EBiUIKZ+FFBWyjHXNHan 8FTc4VYvIv/V38X1206XO6H3Sl+vS3TL7Sw2jO7o= Date: Tue, 18 Jun 2019 15:03:35 +0800 From: Shawn Guo To: Anson.Huang@nxp.com Subject: Re: [PATCH] soc: imx: Add i.MX8MN SoC driver support Message-ID: <20190618070334.GD29881@dragon> References: <20190611013125.3434-1-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190611013125.3434-1-Anson.Huang@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190618_000426_340535_4184EEC7 X-CRM114-Status: GOOD ( 16.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: abel.vesa@nxp.com, viresh.kumar@linaro.org, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, Linux-imx@nxp.com, kernel@pengutronix.de, leonard.crestez@nxp.com, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 11, 2019 at 09:31:25AM +0800, Anson.Huang@nxp.com wrote: > From: Anson Huang > > This patch adds i.MX8MN SoC driver support: > > root@imx8mnevk:~# cat /sys/devices/soc0/family > Freescale i.MX > > root@imx8mnevk:~# cat /sys/devices/soc0/machine > NXP i.MX8MNano DDR4 EVK board > > root@imx8mnevk:~# cat /sys/devices/soc0/soc_id > i.MX8MN > > root@imx8mnevk:~# cat /sys/devices/soc0/revision > 1.0 > > Signed-off-by: Anson Huang > --- > drivers/soc/imx/soc-imx8.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/drivers/soc/imx/soc-imx8.c b/drivers/soc/imx/soc-imx8.c > index 3842d09..02309a2 100644 > --- a/drivers/soc/imx/soc-imx8.c > +++ b/drivers/soc/imx/soc-imx8.c > @@ -55,7 +55,12 @@ static u32 __init imx8mm_soc_revision(void) > void __iomem *anatop_base; > u32 rev; > > - np = of_find_compatible_node(NULL, NULL, "fsl,imx8mm-anatop"); > + if (of_machine_is_compatible("fsl,imx8mm")) > + np = of_find_compatible_node(NULL, NULL, "fsl,imx8mm-anatop"); > + else if (of_machine_is_compatible("fsl,imx8mn")) > + np = of_find_compatible_node(NULL, NULL, "fsl,imx8mn-anatop"); Can we have this anatop compatible in imx8_soc_data, so that we may save the call to of_machine_is_compatible()? Shawn > + else > + np = NULL; > if (!np) > return 0; > > @@ -79,9 +84,15 @@ static const struct imx8_soc_data imx8mm_soc_data = { > .soc_revision = imx8mm_soc_revision, > }; > > +static const struct imx8_soc_data imx8mn_soc_data = { > + .name = "i.MX8MN", > + .soc_revision = imx8mm_soc_revision, > +}; > + > static const struct of_device_id imx8_soc_match[] = { > { .compatible = "fsl,imx8mq", .data = &imx8mq_soc_data, }, > { .compatible = "fsl,imx8mm", .data = &imx8mm_soc_data, }, > + { .compatible = "fsl,imx8mn", .data = &imx8mn_soc_data, }, > { } > }; > > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel