* [PATCH] arm64: dts: marvell: add missing #interrupt-cells property
@ 2019-06-17 14:49 Russell King
2019-06-18 8:17 ` Alexandre Belloni
0 siblings, 1 reply; 3+ messages in thread
From: Russell King @ 2019-06-17 14:49 UTC (permalink / raw)
To: Gregory Clement
Cc: Mark Rutland, Andrew Lunn, Jason Cooper, devicetree, Rob Herring,
linux-arm-kernel, Sebastian Hesselbarth
The GPIO interrupt controllers are missing their required
#interrupt-cells property, which prevents GPIO interrupts being
specified in DT.
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
arch/arm64/boot/dts/marvell/armada-cp110.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
index 4d6e4a097f72..f71afb1de18f 100644
--- a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
@@ -238,6 +238,7 @@
<85 IRQ_TYPE_LEVEL_HIGH>,
<84 IRQ_TYPE_LEVEL_HIGH>,
<83 IRQ_TYPE_LEVEL_HIGH>;
+ #interrupt-cells = <2>;
status = "disabled";
};
@@ -253,6 +254,7 @@
<81 IRQ_TYPE_LEVEL_HIGH>,
<80 IRQ_TYPE_LEVEL_HIGH>,
<79 IRQ_TYPE_LEVEL_HIGH>;
+ #interrupt-cells = <2>;
status = "disabled";
};
};
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: marvell: add missing #interrupt-cells property
2019-06-17 14:49 [PATCH] arm64: dts: marvell: add missing #interrupt-cells property Russell King
@ 2019-06-18 8:17 ` Alexandre Belloni
2019-06-18 8:20 ` Gregory CLEMENT
0 siblings, 1 reply; 3+ messages in thread
From: Alexandre Belloni @ 2019-06-18 8:17 UTC (permalink / raw)
To: Russell King
Cc: Mark Rutland, Andrew Lunn, Jason Cooper, devicetree,
Gregory Clement, Rob Herring, linux-arm-kernel,
Sebastian Hesselbarth
On 17/06/2019 15:49:55+0100, Russell King wrote:
> The GPIO interrupt controllers are missing their required
> #interrupt-cells property, which prevents GPIO interrupts being
> specified in DT.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> arch/arm64/boot/dts/marvell/armada-cp110.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
> index 4d6e4a097f72..f71afb1de18f 100644
> --- a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
> @@ -238,6 +238,7 @@
> <85 IRQ_TYPE_LEVEL_HIGH>,
> <84 IRQ_TYPE_LEVEL_HIGH>,
> <83 IRQ_TYPE_LEVEL_HIGH>;
> + #interrupt-cells = <2>;
> status = "disabled";
> };
>
> @@ -253,6 +254,7 @@
> <81 IRQ_TYPE_LEVEL_HIGH>,
> <80 IRQ_TYPE_LEVEL_HIGH>,
> <79 IRQ_TYPE_LEVEL_HIGH>;
> + #interrupt-cells = <2>;
> status = "disabled";
> };
> };
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: marvell: add missing #interrupt-cells property
2019-06-18 8:17 ` Alexandre Belloni
@ 2019-06-18 8:20 ` Gregory CLEMENT
0 siblings, 0 replies; 3+ messages in thread
From: Gregory CLEMENT @ 2019-06-18 8:20 UTC (permalink / raw)
To: Russell King
Cc: Mark Rutland, Andrew Lunn, Alexandre Belloni, Jason Cooper,
devicetree, Rob Herring, linux-arm-kernel, Sebastian Hesselbarth
Hi Russell,
> On 17/06/2019 15:49:55+0100, Russell King wrote:
>> The GPIO interrupt controllers are missing their required
>> #interrupt-cells property, which prevents GPIO interrupts being
>> specified in DT.
>>
>> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Applied on mvebu/dt64
Thanks,
Gregory
>
>> ---
>> arch/arm64/boot/dts/marvell/armada-cp110.dtsi | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
>> index 4d6e4a097f72..f71afb1de18f 100644
>> --- a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
>> +++ b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi
>> @@ -238,6 +238,7 @@
>> <85 IRQ_TYPE_LEVEL_HIGH>,
>> <84 IRQ_TYPE_LEVEL_HIGH>,
>> <83 IRQ_TYPE_LEVEL_HIGH>;
>> + #interrupt-cells = <2>;
>> status = "disabled";
>> };
>>
>> @@ -253,6 +254,7 @@
>> <81 IRQ_TYPE_LEVEL_HIGH>,
>> <80 IRQ_TYPE_LEVEL_HIGH>,
>> <79 IRQ_TYPE_LEVEL_HIGH>;
>> + #interrupt-cells = <2>;
>> status = "disabled";
>> };
>> };
>> --
>> 2.7.4
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-18 8:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-17 14:49 [PATCH] arm64: dts: marvell: add missing #interrupt-cells property Russell King
2019-06-18 8:17 ` Alexandre Belloni
2019-06-18 8:20 ` Gregory CLEMENT
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).