From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77618C31E51 for ; Tue, 18 Jun 2019 09:34:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BCFB206B7 for ; Tue, 18 Jun 2019 09:34:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cJGs1mt8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BCFB206B7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MMekfPgfeNJSRyR5f6hCsR6GBPGWhdAd6ttYm+k52bw=; b=cJGs1mt896ICEj N8t/NlLJ99HjAC8XDF02KjjUImZt/SXMWpY/f8/9CB8MeNjKLiNd0k41KwAliT8vOuJIHkWo55E7N uMCay2U499OZHkof8DFneOw9E6GuKOODFzeYdK4rmLnk6taXFurQLQJ6tLFjTWTrMqDrm94F6XcLJ PXbrVZ1aYPAngim7D5J3Hd+8hMZV6dIw9//RfSAX4Nilg3djrw9G76wEomVolJ+Z8eEkry17dtYez 6dzAqVhSaT3/uJOOKNtpg0hLUyIhKrMibpf9EnvivUhRNejJl0OKhYvhJGKoCga7lEh0sfwn5sm09 YQ1RedjKtOPR2xURKClA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdAW1-0004gj-3k; Tue, 18 Jun 2019 09:34:57 +0000 Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.92 #3 (Red Hat Linux)) id 1hdAVz-0004g7-K0; Tue, 18 Jun 2019 09:34:55 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 7B3AE20A410E1; Tue, 18 Jun 2019 11:34:53 +0200 (CEST) Date: Tue, 18 Jun 2019 11:34:53 +0200 From: Peter Zijlstra To: Valentin Schneider Subject: Re: [PATCH] sched/topology: remove unused sd param from arch_scale_cpu_capacity() Message-ID: <20190618093453.GN3436@hirez.programming.kicks-ass.net> References: <1560783617-5827-1-git-send-email-vincent.guittot@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, gregkh@linuxfoundation.org, rafael@kernel.org, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, quentin.perret@arm.com, mingo@redhat.com, viresh.kumar@linaro.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 17, 2019 at 06:07:29PM +0100, Valentin Schneider wrote: > Hi, > > On 17/06/2019 16:00, Vincent Guittot wrote: > > struct sched_domain *sd parameter is not used anymore in > > arch_scale_cpu_capacity() so we can remove it. > > > > I think it can't hurt to give a bit of background. The *sd parameter used > to be there for smt_gain, which got snipped out by: > > 765d0af19f5f ("sched/topology: Remove the ::smt_gain field from 'struct sched_domain'") > > I'd appreciate having that commit mentioned in the log. > > > Signed-off-by: Vincent Guittot > > Other than that, the changes look fine to me. > > Reviewed-by: Valentin Schneider The commit log now reads: --- The 'struct sched_domain *sd' argument to arch_scale_cpu_capacity() is unused since commit: 765d0af19f5f ("sched/topology: Remove the ::smt_gain field from 'struct sched_domain'") remove it. --- _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel