linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] arm64: Expose ARMv8.5 CondM capability to userspace
Date: Tue, 18 Jun 2019 17:51:28 +0100	[thread overview]
Message-ID: <20190618165128.GC4270@fuggles.cambridge.arm.com> (raw)
In-Reply-To: <20190617112656.2614-1-broonie@kernel.org>

Hi Mark,

On Mon, Jun 17, 2019 at 12:26:55PM +0100, Mark Brown wrote:
> ARMv8.5 adds new instructions XAFLAG and AXFLAG to translate the
> representation of the results of floating point comparisons between the
> native ARM format and an alternative format used by some software. Add
> a hwcap allowing userspace to determine if they are present.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>  Documentation/arm64/elf_hwcaps.txt  | 4 ++++
>  arch/arm64/include/asm/hwcap.h      | 1 +
>  arch/arm64/include/uapi/asm/hwcap.h | 1 +
>  arch/arm64/kernel/cpufeature.c      | 1 +
>  arch/arm64/kernel/cpuinfo.c         | 1 +
>  5 files changed, 8 insertions(+)
> 
> diff --git a/Documentation/arm64/elf_hwcaps.txt b/Documentation/arm64/elf_hwcaps.txt
> index b73a2519ecf2..08e8e380a826 100644
> --- a/Documentation/arm64/elf_hwcaps.txt
> +++ b/Documentation/arm64/elf_hwcaps.txt
> @@ -207,6 +207,10 @@ HWCAP_FLAGM
>  
>      Functionality implied by ID_AA64ISAR0_EL1.TS == 0b0001.
>  
> +HWCAP_CONDM85

This should be referring to HWCAP2.

Also, to dive in with the naming bikeshed, although CONDM85 does appear
to be aligned with the architecture, we've already got HWCAP_FLAGM for
the case when ID_AA64ISAR0_EL1.TS == 0b0001, so I think we're better off
being consistent with ourselves and just having something like
HWCAP2_FLAGM2 with the string "flagm2".

With that change:

Acked-by: Will Deacon <will.deacon@arm.com>

Thanks,

Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-06-18 16:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-17 11:26 [PATCH 1/2] arm64: Expose ARMv8.5 CondM capability to userspace Mark Brown
2019-06-17 11:26 ` [PATCH 2/2] arm64: Expose FRINT " Mark Brown
2019-06-18 16:51   ` Will Deacon
2019-06-18 16:51 ` Will Deacon [this message]
     [not found] <20190618181055.31576-1-broonie@kernel.org>
2019-06-25 13:26 ` [PATCH 1/2] arm64: Expose ARMv8.5 CondM " Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190618165128.GC4270@fuggles.cambridge.arm.com \
    --to=will.deacon@arm.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).