From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E301C31E49 for ; Wed, 19 Jun 2019 13:32:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F4DC20B1F for ; Wed, 19 Jun 2019 13:32:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YCoZebEW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F4DC20B1F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8UKglrtI7w4nwvXHE+DNrm1Z4N5D6K2ob09L4WeYmFQ=; b=YCoZebEWdeJ20l A5gEnPq+7tLO6wFd1ZIZeWYyBOtMIEMAI9LoToXApiRYNe9P4rnMr/XTW+8JRT3Jv8FL4C4ZzMEmi R+N1yUvThihZgTsaHsPSe+gpfrQ4CrkU+RUCy1HCDXaGaFzcWq9TTcVvvGV6Pk4MF+T9xCYElDN46 9qpd3WWQoLgw+uzj7jLwZ2dIkYaDxv6IzyHB4VBSCzkgJoaC8cc3WvocGbqCjNbO7bBBbjo/mlbmE JJlbJ7w3EUVsYYjhMOr/NVjZlqag0qDw19ze2jlJYqILI55++zNh3tB7bWWP4LrplGGP7r+kf2mXb 1ZqTK62os7Fc8VoLs0hw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdahU-0005GU-2C; Wed, 19 Jun 2019 13:32:32 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdahQ-0005G1-VB for linux-arm-kernel@lists.infradead.org; Wed, 19 Jun 2019 13:32:30 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 520DB344; Wed, 19 Jun 2019 06:32:27 -0700 (PDT) Received: from localhost (unknown [10.37.6.20]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C838B3F738; Wed, 19 Jun 2019 06:32:26 -0700 (PDT) Date: Wed, 19 Jun 2019 14:32:25 +0100 From: Andrew Murray To: Arnd Bergmann Subject: Re: [PATCH] ARM: omap2: remove incorrect __init annotation Message-ID: <20190619133224.GX20984@e119886-lin.cambridge.arm.com> References: <20190619130529.1502322-1-arnd@arndb.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190619130529.1502322-1-arnd@arndb.de> User-Agent: Mutt/1.10.1+81 (426a6c1) (2018-08-26) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190619_063229_052001_217A2EE9 X-CRM114-Status: GOOD ( 18.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Walmsley , Rajendra Nayak , Tony Lindgren , linux-kernel@vger.kernel.org, arm@kernel.org, Nathan Chancellor , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 19, 2019 at 03:04:54PM +0200, Arnd Bergmann wrote: > omap3xxx_prm_enable_io_wakeup() is marked __init, but its caller is not, so > we get a warning with clang-8: > > WARNING: vmlinux.o(.text+0x343c8): Section mismatch in reference from the function omap3xxx_prm_late_init() to the function .init.text:omap3xxx_prm_enable_io_wakeup() > The function omap3xxx_prm_late_init() references > the function __init omap3xxx_prm_enable_io_wakeup(). > This is often because omap3xxx_prm_late_init lacks a __init > annotation or the annotation of omap3xxx_prm_enable_io_wakeup is wrong. > That's unfortunate, both omap3xxx_prm_enable_io_wakeup and omap3xxx_prm_late_init are only ever called at init time (by prm_late_init which is also __init annotated). However the omap3xxx_prm_ll_data structure containing the late_init has a life beyond init. Otherwise I would have suggested annotating omap3xxx_prm_late_init. Reviewed-by: Andrew Murray > When building with gcc, omap3xxx_prm_enable_io_wakeup() is always > inlined, so we never noticed in the past. > > Signed-off-by: Arnd Bergmann > Reviewed-by: Nathan Chancellor > Acked-by: Tony Lindgren > --- > arch/arm/mach-omap2/prm3xxx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/prm3xxx.c b/arch/arm/mach-omap2/prm3xxx.c > index 05858f966f7d..dfa65fc2c82b 100644 > --- a/arch/arm/mach-omap2/prm3xxx.c > +++ b/arch/arm/mach-omap2/prm3xxx.c > @@ -433,7 +433,7 @@ static void omap3_prm_reconfigure_io_chain(void) > * registers, and omap3xxx_prm_reconfigure_io_chain() must be called. > * No return value. > */ > -static void __init omap3xxx_prm_enable_io_wakeup(void) > +static void omap3xxx_prm_enable_io_wakeup(void) > { > if (prm_features & PRM_HAS_IO_WAKEUP) > omap2_prm_set_mod_reg_bits(OMAP3430_EN_IO_MASK, WKUP_MOD, > -- > 2.20.0 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel