From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A87BC43613 for ; Thu, 20 Jun 2019 06:03:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F31D021537 for ; Thu, 20 Jun 2019 06:03:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YrS68zQF"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="q/QSx2oA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F31D021537 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8PpgLeHkT3nHHanPv1sCu6A5DRfNSywzqn/sGruBjsk=; b=YrS68zQFnFgSYM XUUyGW25gCGJo5QBP0tEfXDL2cpDdc1Olo1BoiKkbpggom05rnolxwsdmA+xy2F7l2P4ywRH945vg dyKRjLMwqigIg/fc6kEWGcp6ZvabAg7pL39xOJpeyXYd7FCfjJ3iGHicXuI4viU8O+RzvuBHmk1xe IIWpl36or8xHsF1QgnCpJUo0e6Q5PpRC1hi0VZd+AbDPiajPW8UKv8tS/f/iAfAb4nNq2D36zWXFO qtA98qBA8tMB1mzHXQzrGKltcocZmC0eEh0v2uGfGGh5rikjsWPBrtYcXdaqVDRrKkeDgcI5DLxNz RDJXbDf76po1m/hN/qkA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdq9z-0008Ix-8i; Thu, 20 Jun 2019 06:02:59 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hdq9v-0008IT-Uh for linux-arm-kernel@lists.infradead.org; Thu, 20 Jun 2019 06:02:57 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BE3BF20B1F; Thu, 20 Jun 2019 06:02:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561010573; bh=wcAr+780Ny2oqChydp8V0jb0itzjGRPIq6ZstMdsFhs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=q/QSx2oA5nn0fX7A9/cygM+vQJe/iGGdwcNqlHDVTxA1NYe7nLHOVlp8mt7QGu1l9 LCNvMPEvAWU+z/kZKcAihcQvoKFpCyO5kjgYHN1gIUeaTM15XukBQboRj3fGGnIvSJ NW4icyIs6rY7FH2g1ZB3apQfl8z3IwxBXz7y2Gm4= Date: Thu, 20 Jun 2019 08:02:50 +0200 From: Greg KH To: Mathieu Poirier Subject: Re: [PATCH 20/28] coresight: tmc-etr: Do not call smp_processor_id() from preemptible Message-ID: <20190620060250.GA26319@kroah.com> References: <20190619195318.19254-1-mathieu.poirier@linaro.org> <20190619195318.19254-21-mathieu.poirier@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190619195318.19254-21-mathieu.poirier@linaro.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190619_230256_009038_CA090EE1 X-CRM114-Status: GOOD ( 14.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 19, 2019 at 01:53:10PM -0600, Mathieu Poirier wrote: > From: Suzuki K Poulose > > During a perf session we try to allocate buffers on the "node" associated > with the CPU the event is bound to. If it's not bound to a CPU, we use > the current CPU node, using smp_processor_id(). However this is unsafe > in a pre-emptible context and could generate the splats as below : > > BUG: using smp_processor_id() in preemptible [00000000] code: perf/1743 > caller is alloc_etr_buf.isra.6+0x80/0xa0 > CPU: 1 PID: 1743 Comm: perf Not tainted 5.1.0-rc6-147786-g116841e #344 > Hardware name: ARM LTD ARM Juno Development Platform/ARM Juno Development Platform, BIOS EDK II Feb 1 2019 > Call trace: > dump_backtrace+0x0/0x150 > show_stack+0x14/0x20 > dump_stack+0x9c/0xc4 > debug_smp_processor_id+0x10c/0x110 > alloc_etr_buf.isra.6+0x80/0xa0 > tmc_alloc_etr_buffer+0x12c/0x1f0 > etm_setup_aux+0x1c4/0x230 > rb_alloc_aux+0x1b8/0x2b8 > perf_mmap+0x35c/0x478 > mmap_region+0x34c/0x4f0 > do_mmap+0x2d8/0x418 > vm_mmap_pgoff+0xd0/0xf8 > ksys_mmap_pgoff+0x88/0xf8 > __arm64_sys_mmap+0x28/0x38 > el0_svc_handler+0xd8/0x138 > el0_svc+0x8/0xc > > Use NUMA_NO_NODE hint instead of using the current node for events > not bound to CPUs. > > Fixes: 855ab61c16bf70b646 ("coresight: tmc-etr: Refactor function tmc_etr_setup_perf_buf()") > Cc: Mathieu Poirier > Signed-off-by: Suzuki K Poulose > Signed-off-by: Mathieu Poirier > --- > drivers/hwtracing/coresight/coresight-tmc-etr.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Why isn't this being submitted for 5.2-final? Why wait until 5.3 to fix this? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel