From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75467C43613 for ; Thu, 20 Jun 2019 09:44:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47B2B2080C for ; Thu, 20 Jun 2019 09:44:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iEM3KGcU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47B2B2080C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y5Qrq0Mn++QkqbxbByP95YM93QG7pKlT/PMV5TZ1FX0=; b=iEM3KGcUK4Rvb5 dVZpocct2mAB3yjmyS2gtlzmIY1zW4x3ZXvbC4DfmBB5SY0Z8I5oErZWkmmTrnE1hIn0ZUnUcJc7R VREBvUZE8voOX5vWdNgTA+eJ4qh2/EpysCCF28uY4eDM4euzcIIvmXlOOmZ6T9ix7CiCRVA3gefTJ PscfJxaZwY0mBWSsHgEmNEsi4rO3NELJ6oZgOuvCc105ivZdenQ2PboezCTsXAH4AxPb+lJWd5M5I DSlcPPopW2hIccWHgiGN6grbqfW6IYbYU0cOnnmrB5yRpL+YjzzH1uWs4qVI0FnGTeSgv2gTU22Ep bZOtg7ecnoPkQqIRGWSw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdtc2-0004jl-NK; Thu, 20 Jun 2019 09:44:10 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdtbx-0004gn-RW for linux-arm-kernel@lists.infradead.org; Thu, 20 Jun 2019 09:44:08 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5BB59360; Thu, 20 Jun 2019 02:44:03 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (unknown [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5548C3F246; Thu, 20 Jun 2019 02:44:02 -0700 (PDT) Date: Thu, 20 Jun 2019 10:43:57 +0100 From: Lorenzo Pieralisi To: Ard Biesheuvel Subject: Re: [RFC PATCH] acpi/arm64: ignore 5.1 FADTs that are reported as 5.0 Message-ID: <20190620094357.GA20872@e121166-lin.cambridge.arm.com> References: <20190619121831.7614-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190619121831.7614-1-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190620_024405_966256_3A84C0F8 X-CRM114-Status: GOOD ( 16.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: catalin.marinas@arm.com, will.deacon@arm.com, leif.lindholm@linaro.org, linux-acpi@vger.kernel.org, lee.jones@linaro.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 19, 2019 at 02:18:31PM +0200, Ard Biesheuvel wrote: > Some Qualcomm Snapdragon based laptops built to run Microsoft Windows > are clearly ACPI 5.1 based, given that that is the first ACPI revision > that supports ARM, and introduced the FADT 'arm_boot_flags' field, > which has a non-zero field on those systems. > > So in these cases, infer from the ARM boot flags that the FADT must be > 5.1 or later, and treat it as 5.1. > > Signed-off-by: Ard Biesheuvel > --- > arch/arm64/kernel/acpi.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) AFAICS this should be harmless, so: Acked-by: Lorenzo Pieralisi > diff --git a/arch/arm64/kernel/acpi.c b/arch/arm64/kernel/acpi.c > index 803f0494dd3e..7722e85fb69c 100644 > --- a/arch/arm64/kernel/acpi.c > +++ b/arch/arm64/kernel/acpi.c > @@ -155,10 +155,14 @@ static int __init acpi_fadt_sanity_check(void) > */ > if (table->revision < 5 || > (table->revision == 5 && fadt->minor_revision < 1)) { > - pr_err("Unsupported FADT revision %d.%d, should be 5.1+\n", > + pr_err(FW_BUG "Unsupported FADT revision %d.%d, should be 5.1+\n", > table->revision, fadt->minor_revision); > - ret = -EINVAL; > - goto out; > + > + if (!fadt->arm_boot_flags) { > + ret = -EINVAL; > + goto out; > + } > + pr_err("FADT has ARM boot flags set, assuming 5.1\n"); > } > > if (!(fadt->flags & ACPI_FADT_HW_REDUCED)) { > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel