From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3A88C43613 for ; Thu, 20 Jun 2019 16:24:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C94D92083B for ; Thu, 20 Jun 2019 16:24:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="j8qgHWBZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C94D92083B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w6/JXT+ZTJPfFG3wXPFku0+oLA8mncxMMwavvP9ByVc=; b=j8qgHWBZ+/K+3X ZqelpMN119duq4KDU18pWo6TrISMjFGZS467Duw0EIlGYaeM2Nb8tVbCpoZxxmAf4u7LQvrxQnguA hle4zfM3Is9y+CHDZZK2Ev6S+HwUoS0ZvmvlSmXqOxeAPoG6vaQx7XVtxsIAe3CLiso5olMpFk7Xt Dy9xq/FfJzmncQLbg36hN5YTGhndy9GDG05CFwvJmF7Q4GX6I/MiYGid4crvQZcwKxgMQBvoQhVOQ NZ4aaQRAry70Tlpj/d7gGmQNq3i0Z7PNmfYfmqI198X7c/sr/R7f9yBC4+z1qtB0QsCM4rob61H7H hRbJ/ksdOShZFAALEiDg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdzqq-0006RA-Ik; Thu, 20 Jun 2019 16:23:53 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hdzpY-0005h6-3G for linux-arm-kernel@lists.infradead.org; Thu, 20 Jun 2019 16:22:34 +0000 X-Originating-IP: 92.137.69.152 Received: from localhost (alyon-656-1-672-152.w92-137.abo.wanadoo.fr [92.137.69.152]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 0CE2320013; Thu, 20 Jun 2019 16:22:21 +0000 (UTC) Date: Thu, 20 Jun 2019 18:22:20 +0200 From: Alexandre Belloni To: Chen-Yu Tsai Subject: Re: [PATCH 0/3] rtc: pcf8563: Fix unhandled interrupt storm Message-ID: <20190620162220.GA23549@piout.net> References: <20190604042337.26129-1-wens@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190604042337.26129-1-wens@kernel.org> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190620_092232_393051_161E8D01 X-CRM114-Status: GOOD ( 19.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, Alessandro Zummo , devicetree@vger.kernel.org, Maxime Ripard , linux-kernel@vger.kernel.org, Vincent Donnefort , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/06/2019 12:23:34+0800, Chen-Yu Tsai wrote: > From: Chen-Yu Tsai > > Hi everyone, > > While bringing up my Pine H64, I encountered an interrupt storm from the > pcf8563 RTC. The RTC chip's interrupt line is shared with the PMIC, and > was not properly added to the device tree. Also, the driver was using an > trigger method incompatible with the PMIC, preventing the interrupt line > from being shared. Last, the driver only clears and masks the alarm > interrupt, while leaving the timer interrupt untouched. This is a > problem if previous systems left the timer interrupt enabled, and there > was an interrupt pending. > > This patch set fixes all three issues, one per patch. > > Please have a look. > I don't have that particular RTC so I can't test but the interrupt handling in pcf8563_irq seems problematic too. I guess the RTC will only trigger once per second because the call to pcf8563_set_alarm_mode will explicitely leave the alarm enabled. The core doesn't really care but it doesn't really expect the alarm to stay enabled. i.e. It will ensure the alarm is enabled again after setting it when necessary. I think it would be safer to simply clear both AIE and AF here. Could you test? > Chen-Yu Tsai (3): > rtc: pcf8563: Fix interrupt trigger method > rtc: pcf8563: Clear event flags and disable interrupts before > requesting irq > arm64: dts: allwinner: h6: Pine H64: Add interrupt line for RTC > > .../arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts | 2 ++ > drivers/rtc/rtc-pcf8563.c | 13 ++++++------- > 2 files changed, 8 insertions(+), 7 deletions(-) > > -- > 2.20.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel