From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32906C43613 for ; Thu, 20 Jun 2019 18:38:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF3112085A for ; Thu, 20 Jun 2019 18:38:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QJ5B4PvY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF3112085A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dYYIb7PeDi2KyBlgK3mGGL+2HImXmNchFJspxQ7SNQI=; b=QJ5B4PvYOvOj85 tGRPSOP5Wp7dBUe367nyIf0TTz1WLFZ/BaKss3q3Ajj6H18HlZARyxJfZt+AYMOWwcYk9S2uU0GqM aZnw5TEujkclVIlAd6IzEZ4GCRh0kCDoJIHE/BRZcsRmKc0SAYYowyNJO+yLtlMC59b9QKg+AQDzm Mtq5OKO4XztQSOMzXE3WAt2X9shf0IB/orV1bYDXldHQx4Sz/uJS5qJ5FA6hW2Ge0vwskBVSPenMq YFXoDAqj13HZrSMlo/kqOvjzDaWg43Aaxz0PWZj8QsQpwiTvOj7/1hHfokl9uebO/UZV2iyuOJ4PO RK8KUX88QRa4gV6N1xsA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1he1wf-0002cO-Je; Thu, 20 Jun 2019 18:38:01 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1he1v1-0001Ld-Uo for linux-arm-kernel@lists.infradead.org; Thu, 20 Jun 2019 18:36:22 +0000 X-Originating-IP: 90.65.161.137 Received: from localhost (lfbn-1-1545-137.w90-65.abo.wanadoo.fr [90.65.161.137]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 59E5E240005; Thu, 20 Jun 2019 18:36:04 +0000 (UTC) Date: Thu, 20 Jun 2019 20:36:04 +0200 From: Alexandre Belloni To: Chen-Yu Tsai Subject: Re: [PATCH 1/3] rtc: pcf8563: Fix interrupt trigger method Message-ID: <20190620183604.GC23549@piout.net> References: <20190604042337.26129-1-wens@kernel.org> <20190604042337.26129-2-wens@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190604042337.26129-2-wens@kernel.org> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190620_113620_221749_3D82C441 X-CRM114-Status: GOOD ( 12.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, Alessandro Zummo , devicetree@vger.kernel.org, Maxime Ripard , linux-kernel@vger.kernel.org, Vincent Donnefort , Chen-Yu Tsai , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/06/2019 12:23:35+0800, Chen-Yu Tsai wrote: > From: Chen-Yu Tsai > > The PCF8563 datasheet says the interrupt line is active low and stays > active until the events are cleared, i.e. a level trigger interrupt. > > Fix the flags used to request the interrupt. > > Fixes: ede3e9d47cca ("drivers/rtc/rtc-pcf8563.c: add alarm support") > Signed-off-by: Chen-Yu Tsai > --- > > Not sure if this would cause issues for other platforms. Ideally we'd > take the flags from the device tree, but it seems not all platforms > support this. > > --- > drivers/rtc/rtc-pcf8563.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel