From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2FA6C4646C for ; Fri, 21 Jun 2019 09:53:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5F7921537 for ; Fri, 21 Jun 2019 09:53:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rRGkj/xo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5F7921537 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gl00HY3IvBsFxk1wicEvMckgbwRwLmqi//8h/ed2WwI=; b=rRGkj/xo1kQNUB eapBt9DeOAW92xgSL9lgNBdtTF2/V7GZGxTubyZsrjaoVkeHNezBUxhdBnnDowJpZRsO1DT5ot87b 5KwZ/JwQmFE5AB5uJxjb+XD2wOgDsz7ZanCoIXwQ20tpFH3IcF45RTcP4FNPoBfjkwHBSSB7fthH8 ZwTmXEr5lMnIbn9v1beV0bEN2naic0Z2zuidgFXaMxxhBQUqRmZC1fW0NSybGSNM6bshBvh3OeOPD VD2t3pwzupBjKjCSHYIKoQeHdWV4egYfpmCcltErlYvFn7llgrJ6vBjoQGaltNNWUqfaVWwQW6LBb 7Ruw5/4UVbQqSMPGLO/w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1heGEM-0003iG-C0; Fri, 21 Jun 2019 09:53:14 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1heFrk-0006Ga-Jr for linux-arm-kernel@lists.infradead.org; Fri, 21 Jun 2019 09:29:54 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3604A142F; Fri, 21 Jun 2019 02:29:51 -0700 (PDT) Received: from localhost (unknown [10.37.6.20]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AB3DB3F246; Fri, 21 Jun 2019 02:29:50 -0700 (PDT) Date: Fri, 21 Jun 2019 10:29:49 +0100 From: Andrew Murray To: Mathieu Poirier Subject: Re: [PATCH v1 5/5] coresight: etm4x: save/restore state across CPU low power states Message-ID: <20190621092948.GJ20984@e119886-lin.cambridge.arm.com> References: <20190619110749.GD1360@e107155-lin> <20190620114116.GE20984@e119886-lin.cambridge.arm.com> <20190620154154.GB25273@e107155-lin> <20190620163426.GC25273@e107155-lin> <20190620165427.GH20984@e119886-lin.cambridge.arm.com> <9adb65af-a898-462b-ecbc-af972d9331a6@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1+81 (426a6c1) (2018-08-26) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190621_022953_003704_67C5FA34 X-CRM114-Status: GOOD ( 14.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Al Grant , Suzuki K Poulose , Alexander Shishkin , Sudeep Holla , linux-arm-kernel , Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 20, 2019 at 11:10:26AM -0600, Mathieu Poirier wrote: > On Thu, 20 Jun 2019 at 11:00, Suzuki K Poulose wrote: > > > > > > > > On 20/06/2019 17:54, Andrew Murray wrote: > > > On Thu, Jun 20, 2019 at 10:47:38AM -0600, Mathieu Poirier wrote: > > >> On Thu, 20 Jun 2019 at 10:34, Sudeep Holla wrote: > > >>> > > >>> On Thu, Jun 20, 2019 at 10:14:04AM -0600, Mathieu Poirier wrote: > > >>>> On Thu, 20 Jun 2019 at 09:41, Sudeep Holla wrote: > > > > ... > > > > >> Then all we have to do is make the ACPI/DT property that indicate the > > >> method used to deal with tracer idling mandatory. That way people are > > >> conscious of the choice they are making. To be backward compatible > > >> with current systems we default to the TRCPDCR.PU method but print a > > >> warning message, just like we do for obsolete DT bindings. > > > > > > I'll respin the series based on this approach. I'll also flip the > > > 'disable_pm_save' module option to 'enable_pm_save' - thus allowing any > > > one to use software save/restore if they wish. > > > > If you are going to add a firmware property, please get a consensus on the > > name here, before respinning to avoid another churn :-). How about one of : > > > > "arm,coresight-etm-looses-state" > > "arm,coresight-etm-needs-save-restore" > > "arm,coresight-needs-save-restore" > > That way we can also use it for CTI. I have no objections with "arm,coresight-needs-save-restore", however in trying to come up with a name that describes the hardware rather than something software needs to do, I came up with: "arm,coresight-broken-pu" "arm,coresight-no-pu" "arm,coresight-pu-ignored" Are any of these prefered? Thanks, Andrew Murray > > > > > or something better long the line. > > > > Cheers > > Suzuki > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel