From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C212C48BE5 for ; Fri, 21 Jun 2019 09:53:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E3F84215EA for ; Fri, 21 Jun 2019 09:53:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fm25XqIz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3F84215EA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pyZF4h8KaqKTxv3eBmwNIXekD0tsaZO9QcX8dZRk07E=; b=fm25XqIzFPDbf/ rcUyu/M4tbZOayNAnF1BXYCyVM4wNIaxFRIU/rZHCnCjCSVEB5++tNsXjQXUdJNMXLmz/odGYj3bd Kqd0whJpS6vQbP6kqEBCXYBPr2yq9P9Tum14iW8gtutwJFMjxAttKhr1HhiuY5ov7jkwZY5zOLpNf SC7GPSiOIdqzhEHC1K+v4/SEWeBpHnTumSEFl0gyiC2hPc8w1rgaGJVy7RMbgQp5RvsSfZZ06s6v/ LU/qVZBCx13UvxGtxz8BpTJMghVgZ2zmVAk46i3QrefRbf23zR+0TTUG6uU0GUaY0Mv1bIPOX99Lo lQTK2faItmxv3wuG5fwQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1heGEs-0004Ab-Hg; Fri, 21 Jun 2019 09:53:46 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1heFv3-0001Ly-IP for linux-arm-kernel@lists.infradead.org; Fri, 21 Jun 2019 09:33:25 +0000 X-Originating-IP: 92.137.69.152 Received: from localhost (alyon-656-1-672-152.w92-137.abo.wanadoo.fr [92.137.69.152]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id E0B1160007; Fri, 21 Jun 2019 09:33:03 +0000 (UTC) Date: Fri, 21 Jun 2019 11:33:02 +0200 From: Alexandre Belloni To: Claudiu.Beznea@microchip.com Subject: Re: [PATCH 0/7] clk: at91: sckc: improve error path Message-ID: <20190621093302.GJ23549@piout.net> References: <1560440205-4604-1-git-send-email-claudiu.beznea@microchip.com> <20190618095521.GE23549@piout.net> <929ac20b-db1d-3f7a-b37c-0dfb253156d5@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <929ac20b-db1d-3f7a-b37c-0dfb253156d5@microchip.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190621_023317_789409_1FBD8F01 X-CRM114-Status: GOOD ( 14.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sboyd@kernel.org, mturquette@baylibre.com, linux-kernel@vger.kernel.org, claudiu.beznea@gmail.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20/06/2019 10:30:42+0000, Claudiu.Beznea@microchip.com wrote: > Hi, > > On 18.06.2019 12:55, Alexandre Belloni wrote: > > On 13/06/2019 15:37:06+0000, Claudiu.Beznea@microchip.com wrote: > >> From: Claudiu Beznea > >> > >> Hi, > >> > >> This series tries to improve error path for slow clock registrations > >> by adding functions to free resources and using them on failures. > >> > > > > Does the platform even boot when the slow clock is not available? > > > > The TCB clocksource would fail at: > > > > tc.slow_clk = of_clk_get_by_name(node->parent, "slow_clk"); > > if (IS_ERR(tc.slow_clk)) > > return PTR_ERR(tc.slow_clk); > > > > In case of using TC as clocksource, yes, the platform wouldn't boot if slow > clock is not available, because, anyway the TC needs it. PIT may work > without it (if slow clock is not used to drive the PIT). > > For sure there are other IPs (which may be or are driven by slow clock) > which may not work if slow clock is driven them. > > Anyway, please let me know if you feel this series has no meaning. > Well, I'm not sure it is worth it but at the same time, it is not adding many lines and you already developed it... -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel