From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C272C43613 for ; Fri, 21 Jun 2019 15:32:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 021652075E for ; Fri, 21 Jun 2019 15:32:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ODAOKIZF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 021652075E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6po0xN+y5NfwCyKb+uWYEgTRhD9YdFAXcf2eoZCe4M8=; b=ODAOKIZFCcEV3U jDon03aMqlcGJRLBci/hGfL/QyFcmNuXC23o9KI5y5kSEE/BhSBdt4lRS9VjQq/sXiJFJb6+ExW4L +836TLw3pO3ca8jvJ+UG2j0C/1/7ADdJVtgUAJ1+3cbW1HLOH3dGufUy5sXAAnAMgnIWZG1y6n9qs hk3PAgR7goLAgji5nwJ0RlS4w9l9Qgt8o34Kc7GS78Mv5edk739CYta5LfLr/tuMIFl7Oaxj1EK8I XRBnPnZJGj9Ann539XbV9sTHTb7IFVeFZx2cSCmvzenG9Gnk95D7RE4CVo99CXEoc42wUmAKfAP0y YZy3XxrU08385253u0hA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1heLWr-0008Rj-Ii; Fri, 21 Jun 2019 15:32:41 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1heLWe-0008Jn-Ef for linux-arm-kernel@lists.infradead.org; Fri, 21 Jun 2019 15:32:29 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0C66DC0A; Fri, 21 Jun 2019 08:32:28 -0700 (PDT) Received: from e103592.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C73583F575; Fri, 21 Jun 2019 08:32:26 -0700 (PDT) Date: Fri, 21 Jun 2019 16:32:24 +0100 From: Dave Martin To: Julien Grall Subject: Re: [RFC PATCH v2 1/8] arm64/fpsimd: Update documentation of do_sve_acc Message-ID: <20190621153224.GW2790@e103592.cambridge.arm.com> References: <20190613161656.20765-1-julien.grall@arm.com> <20190613161656.20765-2-julien.grall@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190613161656.20765-2-julien.grall@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190621_083228_741394_D81D5492 X-CRM114-Status: GOOD ( 16.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anton.Kirilov@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, oleg@redhat.com, zhang.lei@jp.fujitsu.com, alex.bennee@linaro.org, linux-arm-kernel@lists.infradead.org, Daniel.Kiss@arm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 13, 2019 at 05:16:49PM +0100, Julien Grall wrote: > TIF_SVE is cleared by fpsimd_restore_current_state() not > task_fpsimd_load(). Update the documentation of do_sve_acc to reflect > this behavior. > > Signed-off-by: Julien Grall > > --- > Changes in v2: > - Fix typo in the commit message > --- > arch/arm64/kernel/fpsimd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/fpsimd.c b/arch/arm64/kernel/fpsimd.c > index a38bf74bcca8..92f418e4f989 100644 > --- a/arch/arm64/kernel/fpsimd.c > +++ b/arch/arm64/kernel/fpsimd.c > @@ -853,7 +853,7 @@ void fpsimd_release_task(struct task_struct *dead_task) > * the SVE access trap will be disabled the next time this task > * reaches ret_to_user. > * > - * TIF_SVE should be clear on entry: otherwise, task_fpsimd_load() > + * TIF_SVE should be clear on entry: otherwise, fpsimd_restore_current_state() > * would have disabled the SVE access trap for userspace during > * ret_to_user, making an SVE access trap impossible in that case. > */ Good spot, thanks! Modulo any outstanding comments from Mark, Reviewed-by: Dave Martin Cheers ---Dave _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel