From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE584C43613 for ; Fri, 21 Jun 2019 15:34:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F9CA2075E for ; Fri, 21 Jun 2019 15:34:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jdbugvNA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F9CA2075E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nzwq9w09es+93Gqv5mBKiSzhtpjbTu+TulQbTd97Z/o=; b=jdbugvNAJGvv65 Hi8rbqtDkw2nH3iE+0Vnmdy49EVqFmBrdgWgurpAYhFFIRhxcrN4hi24AKFSGUzExxskpAlChPPT2 1H69YH8tMmbnf4+0ZsrDx9CLpP2Y78BtKhacuBacpRFFj2mLVhBjx8rfNcDftlgygQzEAAui4NkiQ BghHp36LGYPVCIfvkH8wmzUgItO2SoVGbcZiX7LG3eQfSDybYNd4G9QmmWOWscwqW2azDcTGRu4f4 Wh8QZBQrO3OzHQ6MEnXgVirzx7Nc9D/U1ic5ZIjo9dKj5H1P9eFQzOgsrBFc6TuMnhatyhsWIHSDg 28erjuVWMQgeRZ6PadxQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1heLYN-0001Eg-Kc; Fri, 21 Jun 2019 15:34:15 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1heLXN-0000Sm-56 for linux-arm-kernel@lists.infradead.org; Fri, 21 Jun 2019 15:33:15 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D11841500; Fri, 21 Jun 2019 08:33:12 -0700 (PDT) Received: from e103592.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 97EE13F575; Fri, 21 Jun 2019 08:33:11 -0700 (PDT) Date: Fri, 21 Jun 2019 16:33:09 +0100 From: Dave Martin To: Julien Grall Subject: Re: [RFC PATCH v2 6/8] arm64/sve: Implement an helper to load SVE registers from FPSIMD state Message-ID: <20190621153309.GB2790@e103592.cambridge.arm.com> References: <20190613161656.20765-1-julien.grall@arm.com> <20190613161656.20765-7-julien.grall@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190613161656.20765-7-julien.grall@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190621_083313_321032_56F47037 X-CRM114-Status: GOOD ( 16.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anton.Kirilov@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, oleg@redhat.com, zhang.lei@jp.fujitsu.com, alex.bennee@linaro.org, linux-arm-kernel@lists.infradead.org, Daniel.Kiss@arm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 13, 2019 at 05:16:54PM +0100, Julien Grall wrote: > In a follow-up patch, we may save the FPSIMD rather than the full SVE > state when the state has to be zeroed on return to userspace (e.g > during a syscall). > > Introduce an helper to load SVE vectors from FPSIMD state and zero the rest > of SVE registers. > > Signed-off-by: Julien Grall > --- > arch/arm64/include/asm/fpsimd.h | 3 +++ > arch/arm64/kernel/entry-fpsimd.S | 17 +++++++++++++++++ > 2 files changed, 20 insertions(+) > > diff --git a/arch/arm64/include/asm/fpsimd.h b/arch/arm64/include/asm/fpsimd.h > index fda3544c9606..f07a88552588 100644 > --- a/arch/arm64/include/asm/fpsimd.h > +++ b/arch/arm64/include/asm/fpsimd.h > @@ -86,6 +86,9 @@ extern void sve_load_state(void const *state, u32 const *pfpsr, > > extern void sve_flush_live(void); > > +extern void sve_load_from_fpsimd_state(struct user_fpsimd_state const *state, > + unsigned long vq_minus_1); > + Lose the extra blank line? > extern unsigned int sve_get_vl(void); > > struct arm64_cpu_capabilities; > diff --git a/arch/arm64/kernel/entry-fpsimd.S b/arch/arm64/kernel/entry-fpsimd.S > index 17121a51c41f..35c21a707730 100644 > --- a/arch/arm64/kernel/entry-fpsimd.S > +++ b/arch/arm64/kernel/entry-fpsimd.S > @@ -58,6 +58,23 @@ ENTRY(sve_get_vl) > ret > ENDPROC(sve_get_vl) > > +/* > + * Load SVE state from FPSIMD state. > + * > + * x0 = pointer to struct fpsimd_state > + * x1 = VQ - 1 > + * > + * Each SVE vector will be loaded with the first 128-bits taken from FPSIMD > + * and the rest zeroed. All the other SVE registers will be zeroed. > + */ > +ENTRY(sve_load_from_fpsimd_state) > + sve_load_vq x1, x2, x3 > + fpsimd_restore x0, 8 > + _for n, 0, 15, _sve_pfalse \n > + _sve_wrffr 0 > + ret > +ENDPROC(sve_load_from_fpsimd_state) > + > /* Zero all SVE registers but the first 128-bits of each vector */ > ENTRY(sve_flush_live) > sve_flush With the extra blank line in fpsimd.h gone (if you agree): Reviewed-by: Dave Martin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel