From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,UNWANTED_LANGUAGE_BODY,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C29DC43613 for ; Mon, 24 Jun 2019 00:29:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D934E2146F for ; Mon, 24 Jun 2019 00:29:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EJOJr4ZR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="0NjCYYEE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D934E2146F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WSbbHyig1cDZZ8AMTpdMUE2T4H9CaLecu/9Ck6ce540=; b=EJOJr4ZRf7t140 Espd1qrHNtbpV8fg6pZM30IKd2POfFhT4/g8kEZ+r3N8K0SZQdPWKhTl/qnGCHoSp9xT/Mj3IUfuE /MATDkze9h2niBHHaBK8Wd7NGVu/3vX2A2XRHq87wxzEu9KJY+SABwgrKdyFvUhT+tkKO8ettV42e U08cmnt8b5AjhixExsJnuoSRKkhDluzgKpko6zTzkxMt90/S8XDAxYRVBC3GcBxvEGGo2jdLupu4B aGtPfKn7eaqTaqv2xIC0S0QtuYhRmh22rlodmjvqToLNJoXTCaNHFEyuniFDQI4fZWU7GPNV+fh2L nypdnAgeL+t7OIq+Y+MQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hfCr9-0001Sz-KC; Mon, 24 Jun 2019 00:29:11 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hfCr5-0001SI-RC for linux-arm-kernel@lists.infradead.org; Mon, 24 Jun 2019 00:29:09 +0000 Received: from dragon (li1322-146.members.linode.com [45.79.223.146]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9E4282133F; Mon, 24 Jun 2019 00:29:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561336147; bh=cpSGSmm/kURiWlNaTfui8DywiRIeRNlWNGYYmkVeqEI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0NjCYYEEoahcoOj0mI5V5d3pNNfhzvqU/mSzk7Gv9IIpImvyUHc+o5AQSxLafC0E4 Z+G8ivwt1Fu4nkZV81PoZ55ThOVFn/QaKoyRByebuHPBKy6ZkXh1FoAga91aN2L/h9 cjmE93pkt0FScMdX8JoylMKELBIgdhubj8ccaBVc= Date: Mon, 24 Jun 2019 08:28:55 +0800 From: Shawn Guo To: Andrey Smirnov Subject: Re: [PATCH v2 1/2] ARM: dts: Add ZII support for ZII i.MX7 RMU2 board Message-ID: <20190624002853.GC3800@dragon> References: <20190617153025.12120-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190617153025.12120-1-andrew.smirnov@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190623_172907_920928_4C4A8A05 X-CRM114-Status: GOOD ( 18.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Rob Herring , Liang Pan , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Chris Healy , Fabio Estevam , Bob Langer , Lucas Stach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 17, 2019 at 08:30:24AM -0700, Andrey Smirnov wrote: > Add support for ZII's i.MX7 based Remote Modem Unit 2 (RMU2) board. > > Signed-off-by: Andrey Smirnov > Cc: Shawn Guo > Cc: Rob Herring > Cc: Chris Healy > Cc: Lucas Stach > Cc: Fabio Estevam > Cc: Bob Langer > Cc: Liang Pan > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: devicetree@vger.kernel.org > --- > > Changes since [v1]: > > - Added missing #address-cells and #size-cells > > - Replaced reset-gpio -> reset-gpios > > > [v1] lore.kernel.org/r/20190614080317.16850-1-andrew.smirnov@gmail.com > > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/imx7d-zii-rmu2.dts | 361 +++++++++++++++++++++++++++ > 2 files changed, 362 insertions(+) > create mode 100644 arch/arm/boot/dts/imx7d-zii-rmu2.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 5559028b770e..516e2912236d 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -593,6 +593,7 @@ dtb-$(CONFIG_SOC_IMX7D) += \ > imx7d-sdb.dtb \ > imx7d-sdb-reva.dtb \ > imx7d-sdb-sht11.dtb \ > + imx7d-zii-rmu2.dtb \ > imx7d-zii-rpu2.dtb \ > imx7s-colibri-eval-v3.dtb \ > imx7s-mba7.dtb \ > diff --git a/arch/arm/boot/dts/imx7d-zii-rmu2.dts b/arch/arm/boot/dts/imx7d-zii-rmu2.dts > new file mode 100644 > index 000000000000..e60b3232a090 > --- /dev/null > +++ b/arch/arm/boot/dts/imx7d-zii-rmu2.dts > @@ -0,0 +1,361 @@ > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > +/* > + * Device tree file for ZII's RMU2 board > + * > + * RMU - Remote Modem Unit > + * > + * Copyright (C) 2019 Zodiac Inflight Innovations > + */ > + > +/dts-v1/; > +#include > +#include "imx7d.dtsi" > + > +/ { > + model = "ZII RMU2 Board"; > + compatible = "zii,imx7d-rmu2", "fsl,imx7d"; > + > + chosen { > + stdout-path = &uart2; > + }; > + > + gpio-leds { > + compatible = "gpio-leds"; > + pinctrl-0 = <&pinctrl_leds_debug>; > + pinctrl-names = "default"; > + > + debug { > + label = "zii:green:debug1"; > + gpios = <&gpio2 8 GPIO_ACTIVE_HIGH>; > + linux,default-trigger = "heartbeat"; > + }; > + }; > +}; > + > +&cpu0 { > + arm-supply = <&sw1a_reg>; > +}; > + > +&ecspi1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_ecspi1>; > + cs-gpios = <&gpio4 19 GPIO_ACTIVE_HIGH>; > + status = "okay"; > + > + flash@0 { > + compatible = "jedec,spi-nor"; > + spi-max-frequency = <20000000>; > + reg = <0>; > + #address-cells = <1>; > + #size-cells = <1>; > + }; > +}; > + > +&fec1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_enet1>; > + assigned-clocks = <&clks IMX7D_ENET1_TIME_ROOT_SRC>, > + <&clks IMX7D_ENET1_TIME_ROOT_CLK>; > + assigned-clock-parents = <&clks IMX7D_PLL_ENET_MAIN_100M_CLK>; > + assigned-clock-rates = <0>, <100000000>; > + phy-mode = "rgmii"; > + phy-handle = <&fec1_phy>; > + status = "okay"; > + > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + fec1_phy: phy@0 { ethernet-phy for node name. > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_enet1_phy_reset>, > + <&pinctrl_enet1_phy_interrupt>; > + reg = <0>; > + interrupt-parent = <&gpio1>; > + interrupts = <2 IRQ_TYPE_LEVEL_LOW>; > + reset-gpios = <&gpio5 11 GPIO_ACTIVE_LOW>; > + }; > + }; > +}; > + > +&i2c1 { > + clock-frequency = <100000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c1>; > + status = "okay"; > + > + pmic: pmic@8 { Label can be more specific, so maybe: pfuze3000: pmic@8 > + compatible = "fsl,pfuze3000"; > + reg = <0x08>; > + > + regulators { > + sw1a_reg: sw1a { > + regulator-min-microvolt = <700000>; > + regulator-max-microvolt = <3300000>; > + regulator-boot-on; > + regulator-always-on; > + regulator-ramp-delay = <6250>; > + }; > + > + sw1c_reg: sw1b { > + regulator-min-microvolt = <700000>; > + regulator-max-microvolt = <1475000>; > + regulator-boot-on; > + regulator-always-on; > + regulator-ramp-delay = <6250>; > + }; > + > + sw2_reg: sw2 { > + regulator-min-microvolt = <1500000>; > + regulator-max-microvolt = <1850000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + sw3a_reg: sw3 { > + regulator-min-microvolt = <900000>; > + regulator-max-microvolt = <1650000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + swbst_reg: swbst { > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5150000>; > + }; > + > + snvs_reg: vsnvs { > + regulator-min-microvolt = <1000000>; > + regulator-max-microvolt = <3000000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + vref_reg: vrefddr { > + regulator-boot-on; > + regulator-always-on; > + }; > + > + vgen1_reg: vldo1 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; > + > + vgen2_reg: vldo2 { > + regulator-min-microvolt = <800000>; > + regulator-max-microvolt = <1550000>; > + regulator-always-on; > + }; > + > + vgen3_reg: vccsd { > + regulator-min-microvolt = <2850000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; > + > + vgen4_reg: v33 { > + regulator-min-microvolt = <2850000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; > + > + vgen5_reg: vldo3 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; > + > + vgen6_reg: vldo4 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; > + }; > + }; > + > + eeprom@50 { > + compatible = "atmel,24c04"; > + reg = <0x50>; > + }; > + > + eeprom@52 { > + compatible = "atmel,24c04"; > + reg = <0x52>; > + }; > +}; > + > +&uart2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_uart2>; > + assigned-clocks = <&clks IMX7D_UART2_ROOT_SRC>; > + assigned-clock-parents = <&clks IMX7D_OSC_24M_CLK>; > + status = "okay"; > +}; > + > +&uart4 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_uart4>; > + assigned-clocks = <&clks IMX7D_UART4_ROOT_SRC>; > + assigned-clock-parents = <&clks IMX7D_PLL_SYS_MAIN_240M_CLK>; > + status = "okay"; > + > + rave-sp { > + compatible = "zii,rave-sp-rdu2"; > + current-speed = <1000000>; > + #address-cells = <1>; > + #size-cells = <1>; > + > + watchdog { > + compatible = "zii,rave-sp-watchdog"; > + }; > + > + eeprom@a3 { > + compatible = "zii,rave-sp-eeprom"; > + reg = <0xa3 0x4000>; > + #address-cells = <1>; > + #size-cells = <1>; > + zii,eeprom-name = "main-eeprom"; > + }; > + }; > +}; > + > +&usbotg2 { > + dr_mode = "host"; > + disable-over-current; > + status = "okay"; > +}; > + > +&usdhc1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usdhc1>; > + bus-width = <4>; > + no-1-8-v; > + no-sdio; > + keep-power-in-suspend; > + status = "okay"; > +}; > + > +&usdhc3 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usdhc3>; > + bus-width = <8>; > + no-1-8-v; > + non-removable; > + no-sdio; > + no-sd; > + keep-power-in-suspend; > + status = "okay"; > +}; > + > +&wdog1 { > + status = "disabled"; > +}; > + > +&snvs_rtc { > + status = "disabled"; > +}; Please sort it alphabetically in label name. > + > +&snvs_pwrkey { > + status = "disabled"; > +}; We already queued up the patch below to disable snvs_pwrkey by default. https://lkml.org/lkml/2019/6/13/1170 > + > +&iomuxc { > + pinctrl_ecspi1: ecspi1grp { > + fsl,pins = < > + MX7D_PAD_ECSPI1_SCLK__ECSPI1_SCLK 0x2 > + MX7D_PAD_ECSPI1_MOSI__ECSPI1_MOSI 0x2 > + MX7D_PAD_ECSPI1_MISO__ECSPI1_MISO 0x2 > + MX7D_PAD_ECSPI1_SS0__GPIO4_IO19 0x59 > + >; > + }; > + > + pinctrl_enet1: enet1grp { > + fsl,pins = < > + MX7D_PAD_SD2_CD_B__ENET1_MDIO 0x3 > + MX7D_PAD_SD2_WP__ENET1_MDC 0x3 > + MX7D_PAD_ENET1_RGMII_TXC__ENET1_RGMII_TXC 0x1 > + MX7D_PAD_ENET1_RGMII_TD0__ENET1_RGMII_TD0 0x1 > + MX7D_PAD_ENET1_RGMII_TD1__ENET1_RGMII_TD1 0x1 > + MX7D_PAD_ENET1_RGMII_TD2__ENET1_RGMII_TD2 0x1 > + MX7D_PAD_ENET1_RGMII_TD3__ENET1_RGMII_TD3 0x1 > + MX7D_PAD_ENET1_RGMII_TX_CTL__ENET1_RGMII_TX_CTL 0x1 > + MX7D_PAD_ENET1_RGMII_RXC__ENET1_RGMII_RXC 0x1 > + MX7D_PAD_ENET1_RGMII_RD0__ENET1_RGMII_RD0 0x1 > + MX7D_PAD_ENET1_RGMII_RD1__ENET1_RGMII_RD1 0x1 > + MX7D_PAD_ENET1_RGMII_RD2__ENET1_RGMII_RD2 0x1 > + MX7D_PAD_ENET1_RGMII_RD3__ENET1_RGMII_RD3 0x1 > + MX7D_PAD_ENET1_RGMII_RX_CTL__ENET1_RGMII_RX_CTL 0x1 > + >; > + }; > + > + pinctrl_enet1_phy_reset: enet1phyresetgrp { > + fsl,pins = < > + MX7D_PAD_SD2_RESET_B__GPIO5_IO11 0x14 > + > + >; > + }; > + > + pinctrl_i2c1: i2c1grp { > + fsl,pins = < > + MX7D_PAD_I2C1_SDA__I2C1_SDA 0x4000007f > + MX7D_PAD_I2C1_SCL__I2C1_SCL 0x4000007f > + >; > + }; > + > + pinctrl_leds_debug: debuggrp { ledsgrp? Shawn > + fsl,pins = < > + MX7D_PAD_EPDC_DATA08__GPIO2_IO8 0x59 > + >; > + }; > + > + > + pinctrl_uart2: uart2grp { > + fsl,pins = < > + MX7D_PAD_UART2_RX_DATA__UART2_DCE_RX 0x79 > + MX7D_PAD_UART2_TX_DATA__UART2_DCE_TX 0x79 > + >; > + }; > + > + pinctrl_uart4: uart4grp { > + fsl,pins = < > + MX7D_PAD_SD2_DATA0__UART4_DCE_RX 0x79 > + MX7D_PAD_SD2_DATA1__UART4_DCE_TX 0x79 > + >; > + }; > + > + pinctrl_usdhc1: usdhc1grp { > + fsl,pins = < > + MX7D_PAD_SD1_CMD__SD1_CMD 0x59 > + MX7D_PAD_SD1_CLK__SD1_CLK 0x19 > + MX7D_PAD_SD1_DATA0__SD1_DATA0 0x59 > + MX7D_PAD_SD1_DATA1__SD1_DATA1 0x59 > + MX7D_PAD_SD1_DATA2__SD1_DATA2 0x59 > + MX7D_PAD_SD1_DATA3__SD1_DATA3 0x59 > + >; > + }; > + > + pinctrl_usdhc3: usdhc3grp { > + fsl,pins = < > + MX7D_PAD_SD3_CMD__SD3_CMD 0x59 > + MX7D_PAD_SD3_CLK__SD3_CLK 0x19 > + MX7D_PAD_SD3_DATA0__SD3_DATA0 0x59 > + MX7D_PAD_SD3_DATA1__SD3_DATA1 0x59 > + MX7D_PAD_SD3_DATA2__SD3_DATA2 0x59 > + MX7D_PAD_SD3_DATA3__SD3_DATA3 0x59 > + MX7D_PAD_SD3_DATA4__SD3_DATA4 0x59 > + MX7D_PAD_SD3_DATA5__SD3_DATA5 0x59 > + MX7D_PAD_SD3_DATA6__SD3_DATA6 0x59 > + MX7D_PAD_SD3_DATA7__SD3_DATA7 0x59 > + MX7D_PAD_SD3_RESET_B__SD3_RESET_B 0x59 > + >; > + }; > +}; > + > +&iomuxc_lpsr { > + pinctrl_enet1_phy_interrupt: enet1phyinterruptgrp { > + fsl,phy = < > + MX7D_PAD_LPSR_GPIO1_IO02__GPIO1_IO2 0x08 > + >; > + }; > +}; > -- > 2.21.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel