From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEE7BC43613 for ; Mon, 24 Jun 2019 10:42:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B39AC20674 for ; Mon, 24 Jun 2019 10:42:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cfvQv8/3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B39AC20674 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eizEkTrGPn2TGvXxR/iFjYfLbIioO5OXfP3KtS6GZC0=; b=cfvQv8/3bGKXMX dx2HrtQPorTWIIlajbzkR7Fwmbct/kLDAYH17OUGPiG20QyHUx6Ifb/bbpYmy/VUzN2gZyUq5iPoy bk7X5K5LvxlS4avqCN60tJ+cjQv0b5YBbq9XmKi899YTuw3ngexF4pVrhESRpJAATGQJteryI4bVE mBqBdl9VpD/3hc6OUR0HZBy+uUalS5Q2PLx9x9Xzdlnz8ZXvIa1icXllyDRBrl+5BF/R7MfNozcRC mGd0oxwJP4w34GohpgMzxW97w81r5wZehVM+mlvJxdrErHEX+SA40UcbQ9lj08+Z5CLCx/3Z8gMdi c70pzewAoNpxjN86in1Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hfMR7-0003yW-5a; Mon, 24 Jun 2019 10:42:57 +0000 Received: from relay11.mail.gandi.net ([217.70.178.231]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hfMR3-0003xK-Tc for linux-arm-kernel@lists.infradead.org; Mon, 24 Jun 2019 10:42:55 +0000 Received: from localhost (alyon-656-1-672-152.w92-137.abo.wanadoo.fr [92.137.69.152]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay11.mail.gandi.net (Postfix) with ESMTPSA id BE47B100005; Mon, 24 Jun 2019 10:42:38 +0000 (UTC) Date: Mon, 24 Jun 2019 12:42:34 +0200 From: Alexandre Belloni To: Chen-Yu Tsai Subject: Re: [PATCH 0/3] rtc: pcf8563: Fix unhandled interrupt storm Message-ID: <20190624104234.GG3133@piout.net> References: <20190604042337.26129-1-wens@kernel.org> <20190620162220.GA23549@piout.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190624_034254_118177_DFC36724 X-CRM114-Status: GOOD ( 21.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, Alessandro Zummo , devicetree , Maxime Ripard , linux-kernel , Vincent Donnefort , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24/06/2019 18:34:29+0800, Chen-Yu Tsai wrote: > On Fri, Jun 21, 2019 at 12:22 AM Alexandre Belloni > wrote: > > > > On 04/06/2019 12:23:34+0800, Chen-Yu Tsai wrote: > > > From: Chen-Yu Tsai > > > > > > Hi everyone, > > > > > > While bringing up my Pine H64, I encountered an interrupt storm from the > > > pcf8563 RTC. The RTC chip's interrupt line is shared with the PMIC, and > > > was not properly added to the device tree. Also, the driver was using an > > > trigger method incompatible with the PMIC, preventing the interrupt line > > > from being shared. Last, the driver only clears and masks the alarm > > > interrupt, while leaving the timer interrupt untouched. This is a > > > problem if previous systems left the timer interrupt enabled, and there > > > was an interrupt pending. > > > > > > This patch set fixes all three issues, one per patch. > > > > > > Please have a look. > > > > > > > I don't have that particular RTC so I can't test but the interrupt > > handling in pcf8563_irq seems problematic too. I guess the RTC will only > > trigger once per second because the call to pcf8563_set_alarm_mode will > > explicitely leave the alarm enabled. The core doesn't really care but it > > doesn't really expect the alarm to stay enabled. i.e. It will ensure the > > alarm is enabled again after setting it when necessary. I think it would > > be safer to simply clear both AIE and AF here. Could you test? > > Yeah, that bit looked weird to me as well. And actually the alarm doesn't > go down to the second, only the minute. > > Is there a test program I can use to test the alarms? > Sure, tools/testing/selftests/rtc/rtctest.c if you use a recent enough version, it will test minute boundaries. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel