From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B925DC43613 for ; Mon, 24 Jun 2019 18:26:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C35B20645 for ; Mon, 24 Jun 2019 18:26:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OhY+q1Le"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="axrq6CY4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C35B20645 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pmPGxx4RuPS/tcppXwrBqgLoaMVy3xMris+n09v+EyA=; b=OhY+q1Le2R1/s8 JXVewW84gqC+PT5m87IFbXRpL4ueyQUB2uCBLrm0oNU6kh3BwUoEKSWaWtt0TOrE/U3/oSK69N1R/ vaosMZK8hkbJtyaLMmTvrzjd7MEhXcBAN7NaiZwmbkiz1JZlKXwbunuNX1zeA+lSU90XOCFdXXlnY HJV5/Anst4uI//3Gd1gfkG+biipirlZqoqzgZ0SuFxJclf2O91QwB98cpeXH6pMw4B7Kxngqsfad/ T1sOVvTLUQHwyb9utoe8r+7DofJUvfEemQQjmK5ZIRUz22qc7VS7eAmaJeDBCdnnNkISIc799NTXO 6SwVfOWf22WY6A02U05Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hfTg7-0000pR-SS; Mon, 24 Jun 2019 18:26:55 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hfTg5-0000pH-9y for linux-arm-kernel@bombadil.infradead.org; Mon, 24 Jun 2019 18:26:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=SQLoGuDrIRqFw0SdGRGBkF1ZPUHhu60LtLFjjoddWXQ=; b=axrq6CY4sBvm3Ks2fS8qjBqqN DY/S2/Jelda119sFvrCw5xcih+O6lHyzhZAjqK2Hj/4pACJo7sgGYCrYtSjik4Iwd+zt8wykFjDig cQeco+IU0mSFLhp8pT/2tLFZqcZehwUkMFmMXYgpE1rijsCYOYUR3cUUnnSfkpt5U43WVKB4Ve3jK Jzzre+IwB8xpj1Cnn487+HbQqUgDrARe0yUjMA99wY/nWa3sj4+dmIKVN3l8ZgYOirQx3/U4ZRjIJ aeLIhiEpmri37oXjTQGYJI5QG/DgHzTncaLs4y7ThgqpOGFO5KnQEOeEVHFpH19/4kfBp1A5g/OI6 HaOhEhD6w==; Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by casper.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hfTg4-0003Xu-8U for linux-arm-kernel@lists.infradead.org; Mon, 24 Jun 2019 18:26:54 +0000 X-Originating-IP: 90.65.161.137 Received: from localhost (lfbn-1-1545-137.w90-65.abo.wanadoo.fr [90.65.161.137]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 4A0E5E0008; Mon, 24 Jun 2019 18:26:15 +0000 (UTC) Date: Mon, 24 Jun 2019 20:26:14 +0200 From: Alexandre Belloni To: Andrew Lunn Subject: Re: [PATCH net-next 4/6] arm64: dts: fsl: ls1028a: Add Felix switch port DT node Message-ID: <20190624182614.GC5690@piout.net> References: <1561131532-14860-1-git-send-email-claudiu.manoil@nxp.com> <1561131532-14860-5-git-send-email-claudiu.manoil@nxp.com> <20190621164940.GL31306@lunn.ch> <20190624115558.GA5690@piout.net> <20190624142625.GR31306@lunn.ch> <20190624152344.3bv46jjhhygo6zwl@lx-anielsen.microsemi.net> <20190624162431.GX31306@lunn.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190624162431.GX31306@lunn.ch> User-Agent: Mutt/1.12.0 (2019-05-25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190624_192652_353355_2B1305E1 X-CRM114-Status: GOOD ( 32.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "netdev@vger.kernel.org" , Alexandru Marginean , "linux-kernel@vger.kernel.org" , "UNGLinuxDriver@microchip.com" , Allan Nielsen , Claudiu Manoil , Rob Herring , "Allan W. Nielsen" , "David S . Miller" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24/06/2019 18:24:31+0200, Andrew Lunn wrote: > On Mon, Jun 24, 2019 at 05:23:45PM +0200, Allan W. Nielsen wrote: > > Hi Andrew, > > > > The 06/24/2019 16:26, Andrew Lunn wrote: > > > > > Yeah, there are 2 ethernet controller ports (managed by the enetc driver) > > > > > connected inside the SoC via SGMII links to 2 of the switch ports, one of > > > > > these switch ports can be configured as CPU port (with follow-up patches). > > > > > > > > > > This configuration may look prettier on DSA, but the main restriction here > > > > > is that the entire functionality is provided by the ocelot driver which is a > > > > > switchdev driver. I don't think it would be a good idea to copy-paste code > > > > > from ocelot to a separate dsa driver. > > > > > > > > > > > > > We should probably make the ocelot driver a DSA driver then... > > > An important part of DSA is being able to direct frames out specific > > > ports when they ingress via the CPU port. Does the silicon support > > > this? At the moment, i think it is using polled IO. > > > > That is supported, it requires a bit of initial configuration of the Chip, but > > nothing big (I believe this configuration is part of Claudiu's change-set). > > > > But how do you envision this done? > > > > - Let the existing SwitchDev driver and the DSA driver use a set of common > > functions. > > - Convert the existing Ocelot driver from SwitchDev to DSA > > - Fork (copy) the existing driver of Ocelot, and modify it as needed for the > > Felix driver > > > > My guess is the first one, but I would like to understand what you have in mind. > > I don't know the various architectures the switch is used in. But it > does seem like a core library, and then a switchdev wrapper for Ocelot > and a DSA wrapper for Felix would make sense. Ocelot could also be used in a DSA setting where one port can be connected to an external MAC and be used to inject/extract frames to/from any other ports. In that case, the IFH would serve as the DSA tag. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel