From: Nishka Dasgupta <nishkadg.linux@gmail.com>
To: eric@anholt.net, wahrenst@gmx.net, gregkh@linuxfoundation.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devel@driverdev.osuosl.org
Cc: Nishka Dasgupta <nishkadg.linux@gmail.com>
Subject: [PATCH 8/9] staging: vc04_services: Remove function output_timeout_error()
Date: Tue, 25 Jun 2019 23:47:08 +0530 [thread overview]
Message-ID: <20190625181710.2267-8-nishkadg.linux@gmail.com> (raw)
In-Reply-To: <20190625181710.2267-1-nishkadg.linux@gmail.com>
Remove function output_timeout_error as it was only called by
vchiq_arm_force_suspend, which was deleted in a previous patch.
Issue found with Coccinelle.
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
---
.../interface/vchiq_arm/vchiq_arm.c | 36 -------------------
1 file changed, 36 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
index a97076c18a0f..ebf7e2a3bd3b 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
@@ -2705,42 +2705,6 @@ vchiq_platform_check_suspend(struct vchiq_state *state)
return;
}
-static void
-output_timeout_error(struct vchiq_state *state)
-{
- struct vchiq_arm_state *arm_state = vchiq_platform_get_arm_state(state);
- char err[50] = "";
- int vc_use_count = arm_state->videocore_use_count;
- int active_services = state->unused_service;
- int i;
-
- if (!arm_state->videocore_use_count) {
- snprintf(err, sizeof(err), " Videocore usecount is 0");
- goto output_msg;
- }
- for (i = 0; i < active_services; i++) {
- struct vchiq_service *service_ptr = state->services[i];
-
- if (service_ptr && service_ptr->service_use_count &&
- (service_ptr->srvstate != VCHIQ_SRVSTATE_FREE)) {
- snprintf(err, sizeof(err), " %c%c%c%c(%d) service has "
- "use count %d%s", VCHIQ_FOURCC_AS_4CHARS(
- service_ptr->base.fourcc),
- service_ptr->client_id,
- service_ptr->service_use_count,
- service_ptr->service_use_count ==
- vc_use_count ? "" : " (+ more)");
- break;
- }
- }
-
-output_msg:
- vchiq_log_error(vchiq_susp_log_level,
- "timed out waiting for vc suspend (%d).%s",
- arm_state->autosuspend_override, err);
-
-}
-
void
vchiq_check_suspend(struct vchiq_state *state)
{
--
2.19.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-25 18:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 18:17 [PATCH 1/9] staging: vc04_services: Remove function vchiu_queue_is_full() Nishka Dasgupta
2019-06-25 18:17 ` [PATCH 2/9] staging: vc04_services: Remove function vchiq_arm_allow_resume() Nishka Dasgupta
2019-06-25 18:17 ` [PATCH 3/9] staging: vc04_services: Remove vchiq_arm_force_suspend() Nishka Dasgupta
2019-06-25 18:17 ` [PATCH 4/9] staging: vc04_services: Remove vchiq_pause_internal() Nishka Dasgupta
2019-06-25 18:17 ` [PATCH 5/9] staging: vc04_services: Remove vchiq_resume_internal() Nishka Dasgupta
2019-06-25 18:17 ` [PATCH 6/9] staging: vc04_services: Remove vchiq_use_service_no_resume() Nishka Dasgupta
2019-06-25 18:17 ` [PATCH 7/9] staging: vc04_services: Remove vchiq_send_remote_release() Nishka Dasgupta
2019-06-25 18:17 ` Nishka Dasgupta [this message]
2019-06-25 18:17 ` [PATCH 9/9] staging: vc04_services: Remove function block_resume() Nishka Dasgupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625181710.2267-8-nishkadg.linux@gmail.com \
--to=nishkadg.linux@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=eric@anholt.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).