From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8CB0C48BD6 for ; Tue, 25 Jun 2019 20:22:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AFF652085A for ; Tue, 25 Jun 2019 20:22:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GUomXo89"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="DZxe9WXK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AFF652085A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OoNmMg4TQdgXmLheC54TiAHo0/L5EpmW0zDnEblPUvA=; b=GUomXo89Eximjt MgbtkYfi6YiJuYC95YZaobyB//eqIkT0ReeTrSwf/+OdIkBs5GAgb+LM11yernP3XVKeentjgzHqc OxO93xqxPbClo7xbJdcUK7FaWGJQ4c0ZZ/QazJvQW52JfBIi1m9z2BKkhLZQvYg44fFpt4NDZR3Wa lll4tpQDvh51Wc+RQNLIPYUbRJILXRoCRg8oCWfsbKwEUESgHESI0MFPFLuuLNHFVNUerNj48x5hW vIBd7kkYSP15Ts+TChxI+aje8LI4IeLwAMTUcClde6Gh83daBzov5gre9eJZmWioxBxv9SHfPBThl w+SHyIhlboetm2/ZmQRQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hfrxs-0008Mo-NO; Tue, 25 Jun 2019 20:22:52 +0000 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hfrxp-0008MR-K0 for linux-arm-kernel@lists.infradead.org; Tue, 25 Jun 2019 20:22:50 +0000 Received: by mail-ed1-x541.google.com with SMTP id m10so29047744edv.6 for ; Tue, 25 Jun 2019 13:22:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=IbaPTmVSK1Auuensg5mZK66IsBxApH2FblnD8ib5Dg0=; b=DZxe9WXKrsmxaaroa2rbKK1EsEntZAaqVR/+UjyyI7hGgL3bekEganJsyf+fyFbk0X PktDQ/QOboGkcqQb2mlJEWZ60RRAFBy6DQixbZ+b8tm+c4oLCvC4oKBiMlUvm+ludtHT A88M05J210TfYPMN3036eGm3lcpipS7i2woEk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=IbaPTmVSK1Auuensg5mZK66IsBxApH2FblnD8ib5Dg0=; b=VbPAXfE1tgYpL2A49CvNmfnCJEZ5ZyaOt6Xxnq70AA5gdXB56p3LatbLn8PlhVCxwT TCh0HrCMhSgq3OA4DMTnfnJFdd7Y/wLb3mK/vjQGSswzHDGQ4Gna6bxAeXdLYDF9sHwo B97oAu/Eb1MP9Am7pKVUZKy9vG805oeUlzPjNtZeBich8Xs91VwRCBdgr1YQIVbDQ8I2 n0OiYPezPERaCmkSdw7F2/FI6Eq7VYMl5Kb2Npddq4vs1F4CqL9g4/DG3ZIWDXtOQ/bH zEMTU897052JgZtwiR0zvoFUyQOjrtnQcs4D01CmSTUUq9Bf6ovvmJ7bWtJGAWZNC3cj pdiw== X-Gm-Message-State: APjAAAWX+OTRqpV7g4XB11wX46QgV0QpylUbs3yAGbi36xloxGVYQT1x wXNrORWvhh0bwCZcwVRTqeSwtQ== X-Google-Smtp-Source: APXvYqzf4IQVb9h7Dov4iMeSGmus3NKT567mUeCO3NbEkQYOBEowGMzZ7rMIdDBuAYAw+tichO+cdg== X-Received: by 2002:a17:906:b211:: with SMTP id p17mr410520ejz.11.1561494168042; Tue, 25 Jun 2019 13:22:48 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id s5sm4839873edh.3.2019.06.25.13.22.46 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 25 Jun 2019 13:22:47 -0700 (PDT) Date: Tue, 25 Jun 2019 22:22:44 +0200 From: Daniel Vetter To: Robert Beckett Subject: Re: [PATCH v3 4/4] drm/imx: only send event on crtc disable if kept disabled Message-ID: <20190625202244.GG12905@phenom.ffwll.local> Mail-Followup-To: Robert Beckett , dri-devel@lists.freedesktop.org, Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <6599f538740632c5524bab86514b8ba026798537.1561483965.git.bob.beckett@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6599f538740632c5524bab86514b8ba026798537.1561483965.git.bob.beckett@collabora.com> X-Operating-System: Linux phenom 4.19.0-5-amd64 User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190625_132249_661345_65109A0D X-CRM114-Status: GOOD ( 17.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabio Estevam , Philipp Zabel , Maxime Ripard , Shawn Guo , Sascha Hauer , Maarten Lankhorst , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie , NXP Linux Team , Daniel Vetter , Sean Paul , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 25, 2019 at 06:59:15PM +0100, Robert Beckett wrote: > The event will be sent as part of the vblank enable during the modeset > if the crtc is not being kept disabled. > > Fixes: 5f2f911578fb ("drm/imx: atomic phase 3 step 1: Use atomic configuration") > > Signed-off-by: Robert Beckett Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/imx/ipuv3-crtc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/imx/ipuv3-crtc.c b/drivers/gpu/drm/imx/ipuv3-crtc.c > index e04d6efff1b5..c436a28d50e4 100644 > --- a/drivers/gpu/drm/imx/ipuv3-crtc.c > +++ b/drivers/gpu/drm/imx/ipuv3-crtc.c > @@ -94,7 +94,7 @@ static void ipu_crtc_atomic_disable(struct drm_crtc *crtc, > drm_crtc_vblank_off(crtc); > > spin_lock_irq(&crtc->dev->event_lock); > - if (crtc->state->event) { > + if (crtc->state->event && !crtc->state->active) { > drm_crtc_send_vblank_event(crtc, crtc->state->event); > crtc->state->event = NULL; > } > -- > 2.18.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel