From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 530F8C48BD6 for ; Wed, 26 Jun 2019 13:16:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E0C321670 for ; Wed, 26 Jun 2019 13:16:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ubYTx2kf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E0C321670 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=the-dreams.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2vWxaUrVXhphGRAK/f20Umn0QXcgaqU/9PVN77dt1FQ=; b=ubYTx2kfXqpdixFOVaZ5bmyeL oTyrYzM3ZB22Poe54OF8MmamsnAmHOXYMyKQgKFAoXAo0ssarxFWY42YcQP4OQvsAL63yjP8WiAdb QBX8VrVdbcZBp1PdsYoe50jMhTZgwLyyvK4/kwpYvNE4sf3FcC1xKyEgtgIQIyNVOcx0qY57Orvs5 PRUusMoQqXY9W8QFRT1kxtiRBabPBWI2WNKW0ZyvgRsj+N8ds/qar9DNE3LtTFtvkrFsBkIZeKgUs 0TM4va3BhSxQALHJPgleKNKY7btAbj37gh8uVuNbp/3m6h42gYHMiB1QHuba+VyCwhnFatHHPbsh+ zjTBVYnYw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hg7mu-0002fW-J0; Wed, 26 Jun 2019 13:16:36 +0000 Received: from sauhun.de ([88.99.104.3] helo=pokefinder.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hg7mb-0002Tc-Mn; Wed, 26 Jun 2019 13:16:19 +0000 Received: from localhost (p54B330AF.dip0.t-ipconnect.de [84.179.48.175]) by pokefinder.org (Postfix) with ESMTPSA id D42872C0114; Wed, 26 Jun 2019 15:16:11 +0200 (CEST) Date: Wed, 26 Jun 2019 15:16:11 +0200 From: Wolfram Sang To: Annaliese McDermond Subject: Re: [PATCH v2 1/2] i2c: bcm2835: Move IRQ request after clock code in probe Message-ID: <20190626131611.GD801@ninjato> References: <20190621105250.19858-1-nh6z@nh6z.net> <20190621105250.19858-2-nh6z@nh6z.net> MIME-Version: 1.0 In-Reply-To: <20190621105250.19858-2-nh6z@nh6z.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190626_061617_895973_9A0C95EA X-CRM114-Status: UNSURE ( 9.04 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: f.fainelli@gmail.com, wahrenst@gmx.net, swarren@wwwdotorg.org, team@nwdigitalradio.com, eric@anholt.net, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============4776707521702111692==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4776707521702111692== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fOHHtNG4YXGJ0yqR" Content-Disposition: inline --fOHHtNG4YXGJ0yqR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 21, 2019 at 03:52:49AM -0700, Annaliese McDermond wrote: > If any of the clock code in the probe fails and returns, the IRQ > will not be freed. Moving the IRQ request to last allows it to > be freed on any errors further up in the probe function. devm_ > calls can apparently not be used because there are some potential > race conditions that will arise. >=20 > Fixes: bebff81fb8b9 ("i2c: bcm2835: Model Divider in CCF") >=20 > Signed-off-by: Annaliese McDermond Applied to for-next, thanks! --fOHHtNG4YXGJ0yqR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl0TcBsACgkQFA3kzBSg KbaeQhAAlH5Fv73WNS3Hs724iNcA4HCx+cCQ3SQCuU5Z/VnDG3exwNTaiwW6RsmV AqMSZyO5B6Pm0Umt5MwzdI9H4dJ2Nf+3HEvUEvqc3fAMbxPguMhf7DhXH29DX89S 5ophbbmY6rD/7WCpjvJPFGvgTXgPpKkt9soqI/DJPfnH/Mpf+7uXMwsJk4jjzTIF po7L4uxY5fH7+swxzUN+YzpSZ8Ao+Cb99ewXfM53gsuzWQEgZnlGREsTpSyt891f DKy9SDZ5XVyDl3c+P8UOmpC/PrHc7fTp3szyuW9/GnrcpNh+3edmSSg6d0GoBJ5+ 0KK9efwCE/2HRcGNJIUIuI2xgjWnnkd0QZavB1D9MDe16XS5K4m62zUZEbP78BXU DQPUHgZKa31ZamIRDT6qaJR+e6voPhEsV5hJMwCuKi48LzxM+Sf67C5uYzaf/ive 9PSgOUMZwEliQ7CDW+7+7SlB5KWcTHjRZgz9mbtZ7hP9auFGdtR54Hxi4P4Y6gie HIiwoRsMHi8AyynqZh4jfCXeJHEevkYdvxEDJND2byqm/BtD2iEOmQNdtbKeTiFq 6ajSpPdf0PBNMY8BarAKuPg4I/HIKtxm4Co8jI+OJ+FwziBE2mTmTZtC6MU8GhrK BBJogbQMrTmA61902d1JpACGuplHEZ35eD3nAKRG5A0i3CrUGMU= =8z// -----END PGP SIGNATURE----- --fOHHtNG4YXGJ0yqR-- --===============4776707521702111692== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4776707521702111692==--