From: Andrew Murray <andrew.murray@arm.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: coresight@lists.linaro.org, Sudeep Holla <sudeep.holla@arm.com>,
linux-arm-kernel@lists.infradead.org,
Mike Leach <mike.leach@linaro.org>
Subject: [PATCH v2 1/5] coresight: etm4x: remove superfluous setting of os_unlock
Date: Thu, 27 Jun 2019 09:35:21 +0100 [thread overview]
Message-ID: <20190627083525.37463-2-andrew.murray@arm.com> (raw)
In-Reply-To: <20190627083525.37463-1-andrew.murray@arm.com>
In addition to unlocking the OS lock, etm4_os_unlock will also
set the os_unlock flag. Therefore let's avoid unnecessarily
setting os_unlock flag outside of this function.
Signed-off-by: Andrew Murray <andrew.murray@arm.com>
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
drivers/hwtracing/coresight/coresight-etm4x.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c
index 7fe266194ab5..c89190d464ab 100644
--- a/drivers/hwtracing/coresight/coresight-etm4x.c
+++ b/drivers/hwtracing/coresight/coresight-etm4x.c
@@ -1047,10 +1047,8 @@ static int etm4_starting_cpu(unsigned int cpu)
return 0;
spin_lock(&etmdrvdata[cpu]->spinlock);
- if (!etmdrvdata[cpu]->os_unlock) {
+ if (!etmdrvdata[cpu]->os_unlock)
etm4_os_unlock(etmdrvdata[cpu]);
- etmdrvdata[cpu]->os_unlock = true;
- }
if (local_read(&etmdrvdata[cpu]->mode))
etm4_enable_hw(etmdrvdata[cpu]);
--
2.21.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-27 8:36 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 8:35 [PATCH v2 0/5] coresight: etm4x: save/restore ETMv4 context across CPU low power states Andrew Murray
2019-06-27 8:35 ` Andrew Murray [this message]
2019-06-27 8:35 ` [PATCH v2 2/5] coresight: etm4x: use explicit barriers on enable/disable Andrew Murray
2019-06-27 9:16 ` Suzuki K Poulose
2019-06-27 11:41 ` Andrew Murray
2019-06-28 2:45 ` Leo Yan
2019-06-28 8:35 ` Andrew Murray
2019-06-28 8:51 ` Leo Yan
2019-06-28 9:00 ` Andrew Murray
2019-06-28 9:41 ` Leo Yan
2019-07-01 8:58 ` Suzuki K Poulose
2019-07-01 9:59 ` Leo Yan
2019-06-27 8:35 ` [PATCH v2 3/5] coresight: etm4x: use module_param instead of module_param_named Andrew Murray
2019-06-27 8:35 ` [PATCH v2 4/5] coresight: etm4x: improve clarity of etm4_os_unlock comment Andrew Murray
2019-06-27 8:35 ` [PATCH v2 5/5] coresight: etm4x: save/restore state across CPU low power states Andrew Murray
2019-06-27 14:25 ` Mike Leach
2019-06-27 14:55 ` Andrew Murray
2019-06-27 16:01 ` Suzuki K Poulose
2019-07-08 14:35 ` Andrew Murray
2019-06-28 8:07 ` Leo Yan
2019-06-28 8:53 ` Andrew Murray
2019-06-28 9:12 ` Leo Yan
2019-06-28 9:22 ` Andrew Murray
2019-07-01 2:07 ` Leo Yan
2019-07-01 9:34 ` Andrew Murray
2019-07-01 9:48 ` Leo Yan
2019-07-01 9:54 ` Andrew Murray
2019-07-01 10:14 ` Leo Yan
2019-07-04 10:21 ` Andrew Murray
2019-07-04 14:27 ` Mathieu Poirier
2019-07-05 1:52 ` Leo Yan
2019-07-01 13:15 ` Suzuki K Poulose
2019-07-04 9:59 ` Andrew Murray
2019-07-03 21:21 ` Mathieu Poirier
2019-07-04 10:06 ` Andrew Murray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190627083525.37463-2-andrew.murray@arm.com \
--to=andrew.murray@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=sudeep.holla@arm.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).