From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9A4BC4321A for ; Fri, 28 Jun 2019 05:09:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A3476206E0 for ; Fri, 28 Jun 2019 05:09:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BpP2da+E"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="tuUO3xja" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A3476206E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6zHH5YkNTS2GSKvdLAryDLPXsl8asFq9ELHhn/iBgdM=; b=BpP2da+EDB8kzc 28tb9Gp4yMdXjPDiMycPPSNU0JD3/FMxaXo19hc0pMHtNk/rmyCesNH7i1sirI41I89v0A01EWUfV XqieAvtuN8oLT0XJaRQnkM3vGDSe3UX1/Eo57F6BVPlFEszgOaXTktsWmwaJ6a4d9OOWgPtu/ADy1 a8DRyhHk/RULWnBJnvh37oniv0IPTbMcFIxcStm0RpB1u5UOvsuFjufeGaEEFL2ohK7lmVbRCP8Q6 nx3t3fS7fMWmOzEXcwBwPHKeNLDk02X7ibPFksTDlyd+qflniG7JzLrNmoPsegRNGQAXChRRPb1E0 5TgOxtWAbRn0Llqci+dQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hgj8u-0004Mm-HV; Fri, 28 Jun 2019 05:09:48 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hgj8s-0004MQ-90 for linux-arm-kernel@lists.infradead.org; Fri, 28 Jun 2019 05:09:47 +0000 Received: from sol.localdomain (c-24-5-143-220.hsd1.ca.comcast.net [24.5.143.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A85F3206E0; Fri, 28 Jun 2019 05:09:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561698586; bh=/peHflkrKmzjbuBmMuvUh/DLiTO8hGnUbfVTz+1n2Nc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tuUO3xjaZIWvv3Mbofdz1xB8AocKHnbI5XgL+ZE/Yrl4SQPS/oif9fvuu28wewGbF y3INDtDd1R3SOBrBKOxq5TNIordgAutrhTvLNsVlaCsvqOX+YyuOx9JEfflt3KkCLq PPafmL2uJvZ7PtFOxYWVbFGr29cYtAtZ3jO1gnHc= Date: Thu, 27 Jun 2019 22:09:44 -0700 From: Eric Biggers To: Keerthy Subject: Re: [RESEND PATCH 05/10] crypto: sha256_generic: Export the Transform function Message-ID: <20190628050944.GE673@sol.localdomain> References: <20190628042745.28455-1-j-keerthy@ti.com> <20190628042745.28455-6-j-keerthy@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190628042745.28455-6-j-keerthy@ti.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190627_220946_339345_BF5532FB X-CRM114-Status: UNSURE ( 8.20 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, devicetree@vger.kernel.org, herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org, t-kristo@ti.com, robh+dt@kernel.org, linux-crypto@vger.kernel.org, davem@davemloft.net, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 28, 2019 at 09:57:40AM +0530, Keerthy wrote: > The transform function can be used as is by other crypto > drivers that need to transform the 256 bit key using cpu. > Hence export it. What is this supposed to mean? SHA-256 is an unkeyed hash function. Also, you need to actually explain why this is needed. If your hardware supports SHA-256, why do you need to use the C sha256_transform()? - Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel