From: Mark Brown <broonie@kernel.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] arm64: Add initial support for E0PD
Date: Fri, 28 Jun 2019 18:39:20 +0100 [thread overview]
Message-ID: <20190628173920.GA2793@sirena.org.uk> (raw)
In-Reply-To: <20190628163642.GB56463@arrakis.emea.arm.com>
[-- Attachment #1.1: Type: text/plain, Size: 1165 bytes --]
On Fri, Jun 28, 2019 at 05:36:42PM +0100, Catalin Marinas wrote:
> On Fri, Jun 28, 2019 at 01:30:40PM +0100, Mark Brown wrote:
> > It's largely on the general theory that it's better to carry less out of
> > tree code - there's less diff to manage, less chance of collisions with
> > other work (in either direction), and less pending review to worry about.
> > So long as something represents forward progress I tend to work on the
> > basis of why not rather than why.
> A reason is that once we add the support for disabling kpti based on
> the E0PD feature, this patch may turn out to be slightly different (for
> example, you may add a common has_e0pd() check that is called from
> both unmap_kernel_at_el0() and the E0PD arm64_features[] entry). Given
Hrm, I don't really get that - incremental patches can always be done
(indeed they're often really helpful for people trying to understand how
the code got to be the way it is). Obviously you can go too far in the
other direction as well, a middle ground is generally best.
> that both patches would be relatively small, I agree with Will that
> there is no rush to merge them independently.
I guess.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-28 17:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 14:15 [PATCH v2] arm64: Add initial support for E0PD Mark Brown
2019-06-28 11:04 ` Will Deacon
2019-06-28 12:30 ` Mark Brown
2019-06-28 16:36 ` Catalin Marinas
2019-06-28 17:39 ` Mark Brown [this message]
2019-06-29 13:21 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628173920.GA2793@sirena.org.uk \
--to=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox