From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D1BEC4321A for ; Sat, 29 Jun 2019 07:53:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 122DE21670 for ; Sat, 29 Jun 2019 07:53:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dtE9R6L8"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ODorpqjj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 122DE21670 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FtritLG9mZsvIE/swjRWYUnSfIpFgbeRLC5LbRUk3yI=; b=dtE9R6L8053yUy v0rFDfBbOmCxl/Y/6mgTS3KjZoj06nQx6XsbkSm/k5lllHGNOcR75WIZ7DgNi/PZVR/FN/DY0D7QO 4rGvMhwReesDuRAt2jxBvNPiNYfEIiZO1zjRJ7OiRaSYExEMkugHBPYjofLz0rFtN1Mw8PVB/GkmB z+soMTazQpmed+GuMfqZGjsEKrAYNrxZMMOQn4sV2ov9TAhQdACD8AnS9rwknVv0Hthu8MmNctgzI WerPMgd60WK4HJ0XuOgqZGTiQ9PfCP0eIWG/sa4XILPr1Ontu6KMyjU7KzCqLuFeZJ6it4XnX2c34 /FsVrruS/j96Rr4Sh9kA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hh8An-00018z-DG; Sat, 29 Jun 2019 07:53:25 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hh8Ah-00017u-QK for linux-arm-kernel@lists.infradead.org; Sat, 29 Jun 2019 07:53:22 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 06BE02083B; Sat, 29 Jun 2019 07:53:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561794796; bh=eXUSg5gAEOz4gIaibl+P2xmyG9y3MtvzIka3bgkCHPk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ODorpqjjRnnfWVgc4AoMyhb95CgAYXOg95HTZNCI2fdm9S5IZJzrwvPKO+bvpfZoB l8I7tpjsrJxntfggfnIGQR395WNwx/gxF1kdqB11ihc+NsRu8mKMAnoBtICevomkBL MweFIxCIiw01QKFBB0/3L9XQFo0lCVYl1sWcnc2A= Date: Sat, 29 Jun 2019 09:53:12 +0200 From: Greg Kroah-Hartman To: Christoph Hellwig Subject: Re: [PATCH] driver core: platform: Allow using a dedicated dma_mask for platform_device Message-ID: <20190629075312.GB28708@kroah.com> References: <20190628141550.22938-1-maxime.chevallier@bootlin.com> <20190628155946.GA16956@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190628155946.GA16956@infradead.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190629_005319_876613_4F60A7A8 X-CRM114-Status: GOOD ( 13.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Rafael J . Wysocki" , Antoine Tenart , linux-kernel@vger.kernel.org, Russell King , Maxime Chevallier , nadavh@marvell.com, brian.brooks@linaro.org, Rob Herring , thomas.petazzoni@bootlin.com, Russell King , stefanc@marvell.com, Frank Rowand , David Miller , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 28, 2019 at 08:59:46AM -0700, Christoph Hellwig wrote: > I'd much rather bite the bullet and make dev->dma_mask a scalar > instead of a pointer. The pointer causes way to much boiler plate code, > and the semantics are way to subtile. Below is a POV patch that > compiles and boots with my usual x86 test config, and at least compiles > with the arm and pmac32 defconfigs. It probably breaks just about > everything else, but should give us an idea what is involve in the > switch: > > --- > >From ea73ba2d29f56ff6413066b10f018a671f2b26ac Mon Sep 17 00:00:00 2001 > From: Christoph Hellwig > Date: Fri, 28 Jun 2019 16:24:01 +0200 > Subject: device.h: make dma_mask a scalar instead of a pointer > > Kill the dma_mask indirection to clean up the mess we acquired around > it. I have no objection to this at all. I would love to see the indirection go away. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel