From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 576A2C5B578 for ; Mon, 1 Jul 2019 04:58:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2AFBD208E4 for ; Mon, 1 Jul 2019 04:58:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ugHp8B+h"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="1pOjHruX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2AFBD208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xtJ8tYYjIVEEq6YUGn7+ZcHT2RIyFVNY8EF0gLOwB1U=; b=ugHp8B+hbADFgZ 3C2mbHWTjuXYjK8rxp3Cn8L3qzgYhVZnZnvnoQiFypwqnZjaz6mwXg5hhpIsboaezAAiZ81tC6x0z oLVX0PivZHiDButtf7OdTqbPKs8YO3x2/TxYSBhynWF9kPSdYI8ObCROHoo8UG6vegeur26bSJ3iv jHEII8GLRfNKbYYrG/w16PMiBf3l8LfIjrBZ9/jmd9EO2RFrH7t3kJ/njzA4uE8R+dbZJysL/hzcx RzZLnjfUBZXo6ZzVkex9vCbUGoU4dK0RibGSTyb90bpu9uPNzrEai75PAjoYjXzNBz6eJGkHlD2ZI AONP8K4WBBT8UWhufqYA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hhoO3-0004b4-Me; Mon, 01 Jul 2019 04:57:55 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hhoO0-0004aa-Eb for linux-arm-kernel@lists.infradead.org; Mon, 01 Jul 2019 04:57:53 +0000 Received: from localhost (unknown [122.167.76.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 059FD208E4; Mon, 1 Jul 2019 04:57:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561957071; bh=Xoo66K/G7tcXAmjXGTmitRGCFyxgVt2d479uVZAiUpo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1pOjHruXzLwzMCPIasWt3ujiDoE1q3JURU5+mwfNEZTqecdT0+TkspW//60OUJq1m 1pN5yUlaCNm71cv6rmBxMFtzhyDNEbcINKK0DzXPztRRr1KfIxfy+L5fKF9ZswnzOe NIqXYqNIXB2J2Dt/P77Guw+sjH1KU/xS6cTsXEdY= Date: Mon, 1 Jul 2019 10:24:43 +0530 From: Vinod Koul To: Fuqian Huang Subject: Re: [PATCH 12/87] dma: imx-sdma: Remove call to memset after dma_alloc_coherent Message-ID: <20190701045443.GI2911@vkoul-mobl> References: <20190627173536.2457-1-huangfq.daxian@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190627173536.2457-1-huangfq.daxian@gmail.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190630_215752_508149_89B734C6 X-CRM114-Status: GOOD ( 14.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shawn Guo , Sascha Hauer , linux-kernel@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , dmaengine@vger.kernel.org, Dan Williams , Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28-06-19, 01:35, Fuqian Huang wrote: > In commit af7ddd8a627c > ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"), > dma_alloc_coherent has already zeroed the memory. > So memset is not needed. Please point to the exact commit and not the merge commit. Hint use git blame on that file... > > Signed-off-by: Fuqian Huang > --- > drivers/dma/imx-sdma.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c > index 99d9f431ae2c..54d86359bdf8 100644 > --- a/drivers/dma/imx-sdma.c > +++ b/drivers/dma/imx-sdma.c > @@ -1886,10 +1886,6 @@ static int sdma_init(struct sdma_engine *sdma) > sdma->context_phys = ccb_phys + > MAX_DMA_CHANNELS * sizeof (struct sdma_channel_control); > > - /* Zero-out the CCB structures array just allocated */ > - memset(sdma->channel_control, 0, > - MAX_DMA_CHANNELS * sizeof (struct sdma_channel_control)); > - > /* disable all channels */ > for (i = 0; i < sdma->drvdata->num_events; i++) > writel_relaxed(0, sdma->regs + chnenbl_ofs(sdma, i)); > -- > 2.11.0 -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel