From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C69ECC06510 for ; Tue, 2 Jul 2019 11:08:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B41C206A2 for ; Tue, 2 Jul 2019 11:08:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YT9bBaF2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B41C206A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MI978mpEpyEtM3RuIxLqFRDgdRAQkmSmE6Ep4V7Blhc=; b=YT9bBaF2uuSoQC N4SmUJIzVkWXyNAmSwZbgbyGZDevjMdy9tP87UzYp1JbmmMANMRHCpUDPUKImjsBGXC6eaCflZXVA VfU6A9agF968YcycKRQKMspCu3jq06qERHRcFiz/jirdmt03aq8iLlWxM0wf3TW6TrqcccVQmYsCD kSbAPfVH5f8BSjNG0DG61P8XG15kcq3aUonyeHAztGgKZFAh2b7w32wmdi96QXIhVm5B2IUFpo0Gi MqivVUPYfleqG9x7b7WFRtQl6xnQVlY2KuzFlj+uJK9WjgAwnJiIm6+oj6/KSyyl36Oh+hxa+6WJm 3rSZUQrUuQxUaUcrjgjg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hiGdx-00007v-Ew; Tue, 02 Jul 2019 11:08:13 +0000 Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hiGdo-0008UJ-2n for linux-arm-kernel@lists.infradead.org; Tue, 02 Jul 2019 11:08:05 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4D63E88313; Tue, 2 Jul 2019 11:07:53 +0000 (UTC) Received: from krava (unknown [10.43.17.81]) by smtp.corp.redhat.com (Postfix) with SMTP id 345422D351; Tue, 2 Jul 2019 11:07:44 +0000 (UTC) Date: Tue, 2 Jul 2019 13:07:43 +0200 From: Jiri Olsa To: Leo Yan Subject: Re: [PATCH v1 00/11] perf: Fix errors detected by Smatch Message-ID: <20190702110743.GA12694@krava> References: <20190702103420.27540-1-leo.yan@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190702103420.27540-1-leo.yan@linaro.org> User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 02 Jul 2019 11:07:58 +0000 (UTC) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190702_040804_359575_E515A5F7 X-CRM114-Status: GOOD ( 19.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Song Liu , Peter Zijlstra , Rasmus Villemoes , linux-kernel@vger.kernel.org, Jin Yao , Andi Kleen , Eric Saint-Etienne , Konstantin Khlebnikov , Ingo Molnar , Suzuki K Poulose , Arnaldo Carvalho de Melo , Alexios Zavras , Davidlohr Bueso , Namhyung Kim , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Mathieu Poirier , Thomas Richter , Adrian Hunter , Alexander Shishkin , "David S. Miller" , Changbin Du , Alexey Budankov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 02, 2019 at 06:34:09PM +0800, Leo Yan wrote: > When I used static checker Smatch for perf building, the main target is > to check if there have any potential issues in Arm cs-etm code. So > finally I get many reporting for errors/warnings. > > I used below command for using static checker with perf building: > > # make VF=1 CORESIGHT=1 -C tools/perf/ \ > CHECK="/root/Work/smatch/smatch --full-path" \ > CC=/root/Work/smatch/cgcc | tee smatch_reports.txt > > I reviewed the errors one by one, if I understood some of these errors > so changed the code as I can, this patch set is the working result; but > still leave some errors due to I don't know what's the best way to fix > it. There also have many inconsistent indenting warnings. So I firstly > send out this patch set and let's see what's the feedback from public > reviewing. > > Leo Yan (11): > perf report: Smatch: Fix potential NULL pointer dereference > perf stat: Smatch: Fix use-after-freed pointer > perf top: Smatch: Fix potential NULL pointer dereference > perf annotate: Smatch: Fix dereferencing freed memory > perf trace: Smatch: Fix potential NULL pointer dereference > perf hists: Smatch: Fix potential NULL pointer dereference > perf map: Smatch: Fix potential NULL pointer dereference > perf session: Smatch: Fix potential NULL pointer dereference > perf intel-bts: Smatch: Fix potential NULL pointer dereference > perf intel-pt: Smatch: Fix potential NULL pointer dereference > perf cs-etm: Smatch: Fix potential NULL pointer dereference from quick look it all looks good to me, nice tool ;-) Acked-by: Jiri Olsa jirka > > tools/perf/builtin-report.c | 4 ++-- > tools/perf/builtin-stat.c | 2 +- > tools/perf/builtin-top.c | 8 ++++++-- > tools/perf/builtin-trace.c | 5 +++-- > tools/perf/ui/browsers/hists.c | 13 +++++++++---- > tools/perf/util/annotate.c | 6 ++---- > tools/perf/util/cs-etm.c | 2 +- > tools/perf/util/intel-bts.c | 5 ++--- > tools/perf/util/intel-pt.c | 5 ++--- > tools/perf/util/map.c | 7 +++++-- > tools/perf/util/session.c | 3 +++ > 11 files changed, 36 insertions(+), 24 deletions(-) > > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel