From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C4ADC0650E for ; Wed, 3 Jul 2019 18:18:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1800E21882 for ; Wed, 3 Jul 2019 18:18:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ykg4LAum"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="dhKGk9kk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1800E21882 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lWB0VZbBMjT02CeSM1ocIsRvCTZaU8nUQHI5LUfD9Yg=; b=Ykg4LAumsBHzkj VFNVue2koD752N9UuYGurw6PoC0SucjCkRthmEpwktcOYyNknQLkH9bBB53XDmEOqN95PgXF5vYek mpGOQwPRV3/rnSNSsT9WpEobdQgkZ+NPJPfUlSNdrA43g0JQgBgfTgKxbLM3hNMVPzqeBO+GP9O+J EYgYq8diZqGbvSVI/K/3chJ3KKn7eXSio8e1GywHF1noKyC4GB7V1UD9H7cg+XCPMxa3aHE5vuA0U +9C4wGSW94gdCriVDOux8tYEcLVjz8FZnQYnWZwFulSMhcMxm5HBn4oWpYIIUUn4KUu9h/JRLEUFq 4H3jFJRRGVqzvLYjN9EA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hijqF-0006Yo-Nz; Wed, 03 Jul 2019 18:18:51 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hijqE-0006YX-9i for linux-arm-kernel@bombadil.infradead.org; Wed, 03 Jul 2019 18:18:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=DCpM7nms5B5RUVgOYjG5X7MCBjiWqWHo1JgqvBcjmHM=; b=dhKGk9kkUlTV/wCSZEiNLkuel iZTrtRELGJh/0jy6hfJsXF5QpUTphgNSMTV8+uMGdDh1S6ro/1NDNfqTI0xh+Uc2CmEVRRjrIi+gA tWYRaJ6+9WhFZ/CVGV2IIc1no1ZXWFI3pjc51YJUQ8O5sNxXm3PoloLctMXe6FTJ5Qsal6G16x5AC rDP+F6jlAdW4XlfLjwWv/a4vnslujFxl3v5nGBvcWcKB3sygrrjib0TeTlLfD7bDFkSXR3Qw8a3sy wLU89SRllIl2kTRjOsFnI36PImiFWXXr0QtnqMoWmcsMFaUz9htGTayqL/PEOsD6FDZP/R8IpoAMr WUWE9FKTQ==; Received: from [177.195.209.182] (helo=quaco.ghostprotocols.net) by merlin.infradead.org with esmtpsa (Exim 4.92 #3 (Red Hat Linux)) id 1hijqC-0000R1-61; Wed, 03 Jul 2019 18:18:48 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id BF8DF41153; Wed, 3 Jul 2019 15:18:41 -0300 (-03) Date: Wed, 3 Jul 2019 15:18:41 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Subject: Re: [PATCH v1 02/11] perf stat: Smatch: Fix use-after-freed pointer Message-ID: <20190703181841.GC10740@kernel.org> References: <20190702103420.27540-1-leo.yan@linaro.org> <20190702103420.27540-3-leo.yan@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190702103420.27540-3-leo.yan@linaro.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.11.3 (2019-02-01) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Song Liu , Peter Zijlstra , Rasmus Villemoes , linux-kernel@vger.kernel.org, Jin Yao , Jiri Olsa , Andi Kleen , Eric Saint-Etienne , Konstantin Khlebnikov , Ingo Molnar , Suzuki K Poulose , Alexios Zavras , Davidlohr Bueso , Namhyung Kim , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Mathieu Poirier , Thomas Richter , Adrian Hunter , Alexander Shishkin , "David S. Miller" , Changbin Du , Alexey Budankov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Tue, Jul 02, 2019 at 06:34:11PM +0800, Leo Yan escreveu: > Based on the following report from Smatch, fix the use-after-freed > pointer. > > tools/perf/builtin-stat.c:1353 > add_default_attributes() warn: passing freed memory 'str'. > > The pointer 'str' has been freed but later it is still passed into the > function parse_events_print_error(). This patch fixes this > use-after-freed issue. thanks, applied. > Signed-off-by: Leo Yan > --- > tools/perf/builtin-stat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c > index 8a35fc5a7281..de0f6d0e96a2 100644 > --- a/tools/perf/builtin-stat.c > +++ b/tools/perf/builtin-stat.c > @@ -1349,8 +1349,8 @@ static int add_default_attributes(void) > fprintf(stderr, > "Cannot set up top down events %s: %d\n", > str, err); > - free(str); > parse_events_print_error(&errinfo, str); > + free(str); > return -1; > } > } else { > -- > 2.17.1 -- - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel