From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD594C0650E for ; Wed, 3 Jul 2019 18:30:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9905621882 for ; Wed, 3 Jul 2019 18:30:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="a6mHIFsL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9905621882 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yQiJFXhr6e2/AcBjEdBrg5UFP5PM3duft/kSApSRAJ4=; b=a6mHIFsL93gr/T oIM7YGDND2Z+2GjEBxr1JiTjIui+2/5I4a/Va7gMUGjtpzKDddd47NvZxsM/KfvXG0UPSWUmKGB7H L0xkLsfJJsND+V/BOuaU0TQZxNmHaFXnHW0oVZRY2OVO1y/TPYB5z5tExy+9MRwlPTcwLCB+iTG5t Un1k1kXcpd+zwtpbP22ypku6M2XfvveaDQao/0uYHBahHthFHxmbImGTPWk1PofgFvoX3HcEENNDd 095b9AEHle3Jc+wnLK7VDwYaSDsCgM6CP4xNZWQCX5E8p96xiKslxhwJLby6V3UnKKN53kjMkpvnr GFsD3c/dADwrguvjkRPw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hik1w-0002d8-6M; Wed, 03 Jul 2019 18:30:56 +0000 Received: from [177.195.209.182] (helo=quaco.ghostprotocols.net) by bombadil.infradead.org with esmtpsa (Exim 4.92 #3 (Red Hat Linux)) id 1hik1t-0002cu-UB; Wed, 03 Jul 2019 18:30:54 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 5542A41153; Wed, 3 Jul 2019 15:30:49 -0300 (-03) Date: Wed, 3 Jul 2019 15:30:49 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Subject: Re: [PATCH v1 03/11] perf top: Smatch: Fix potential NULL pointer dereference Message-ID: <20190703183049.GD10740@kernel.org> References: <20190702103420.27540-1-leo.yan@linaro.org> <20190702103420.27540-4-leo.yan@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190702103420.27540-4-leo.yan@linaro.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.11.3 (2019-02-01) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Song Liu , Peter Zijlstra , Rasmus Villemoes , linux-kernel@vger.kernel.org, Jin Yao , Jiri Olsa , Andi Kleen , Eric Saint-Etienne , Konstantin Khlebnikov , Ingo Molnar , Suzuki K Poulose , Alexios Zavras , Davidlohr Bueso , Namhyung Kim , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Mathieu Poirier , Thomas Richter , Adrian Hunter , Alexander Shishkin , "David S. Miller" , Changbin Du , Alexey Budankov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Tue, Jul 02, 2019 at 06:34:12PM +0800, Leo Yan escreveu: > Based on the following report from Smatch, fix the potential > NULL pointer dereference check. > > tools/perf/builtin-top.c:109 > perf_top__parse_source() warn: variable dereferenced before check 'he' > (see line 103) > > tools/perf/builtin-top.c:233 > perf_top__show_details() warn: variable dereferenced before check 'he' > (see line 228) > > tools/perf/builtin-top.c > 101 static int perf_top__parse_source(struct perf_top *top, struct hist_entry *he) > 102 { > 103 struct perf_evsel *evsel = hists_to_evsel(he->hists); > ^^^^ > 104 struct symbol *sym; > 105 struct annotation *notes; > 106 struct map *map; > 107 int err = -1; > 108 > 109 if (!he || !he->ms.sym) > 110 return -1; > > This patch moves the values assignment after validating pointer 'he'. Applied, thanks, - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel