From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 807BAC4647E for ; Thu, 4 Jul 2019 13:06:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54DC02189E for ; Thu, 4 Jul 2019 13:06:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VdEv3Bt5"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MhGHCbNx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54DC02189E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=e17PlGK9D3JVlwx6D8BRrFp2d14y5QslpeObrCEq8Og=; b=VdEv3Bt5nOJgO1 pCnVtXqA9B1JCGtJbmA9F58AXzhgP4xgtlpoMScIJF/TM7qy+J/pfnkq7yB4GHu3gX/iSXDzZoeth qQV/5r41xK4Kv9oGze0Nhz66RgcRD2VS2wKUYMG6cCVpNTjOd6/4xVocMTr/cg63x3zikodMRZo8T JHibtSF6u7IPMJn33a+hTZnHxlkUcA7OEZUiWa+QqQbNTmwebkfbZDTT8BlLCRE0V9Qex/NSWXZJA VZmqra86bxQzf40Ws3eIjzIV01QCDtjQ6OI+8C7fFO97WV6SiFOti9lEXwLcnjdbQZrLxvKp8o7Oi SU6x5N+NjuvtAKWazwmw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hj1Rj-0003s7-Ks; Thu, 04 Jul 2019 13:06:43 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hj1Rg-0003rV-Mi for linux-arm-kernel@lists.infradead.org; Thu, 04 Jul 2019 13:06:42 +0000 Received: by mail-wm1-x342.google.com with SMTP id c6so6116307wml.0 for ; Thu, 04 Jul 2019 06:06:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=C0G7rBJyorAv/Go9XW+5KlxgxsrwAo4Lw8h4E0AK/9g=; b=MhGHCbNxmBGEX9gNxaF9U5CCJT+qFuz/qiepbdulPX4tk3cpmHk4Nr1cvq+wO4v/6O +ybPFIWjxCRzO1VplawtIKym3JIWT6EL6KCC/kXweTg1xEDf6xWNuutL6xnTVP49ECPa 2IkTuBaIC5U5cDvAdCksqgV+emWw2anAu4XaajfBHQH+ALVYgz1c6h+ms+nDnaWgQOva rqS7dM0i2zAeunc7L6TMtRFiWjbF3j2AT0T4kRNj/OsD5XYRsUZqdy268I4EZYTBHRYU uIRnNbFdGgRz8D3Ch5iqC9sB+WrvfT8Jn9Q1LiX+atRzygQnXvRv4EHdOsgMgxoxXFdA tX1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=C0G7rBJyorAv/Go9XW+5KlxgxsrwAo4Lw8h4E0AK/9g=; b=oKk3o4ehBBBOUEwbR0WIMRusdYGPnocBRNLAjzQt4CQE/PUS0bgGQg/sQzs/F06rjO fCAIZ+lS7LXvAXyI5MkFVF6Rjx2pyGUP3WfGrjZhWPbaWaWANbkssMgjR4+eQI8HLLnY xV0u7HLi88hc4IPPEhtqiKzftGpCXUB+xMx06fejfCGrImTW5YixJBY1opnP0HwrcuWh XwStzqf2hxepHujYuphmuIh2knIdtikQHMpGHKAhvtOv+ELiSrm7mnJyDjUo2jsDLzMx 9qp9Y9xnLj7ewRVDz+hCNq1ykEJ+QoquM9G7B+7D6TYtnCa/THL003JBMZq2m+++Xhf3 AZzQ== X-Gm-Message-State: APjAAAVCkltoXImyTxtunWhnR4nwixA9QJrIIWN1ZSBlRg1xZuhZtLI5 yveILHRfV2DlZhfQfHekmQLPqQ== X-Google-Smtp-Source: APXvYqwpVkbCltdiX25gOjc+VVQOWtlzTko4TXdJA9hHxN3MnWxEKL9t/rTxGIvJpQMJWxILKQIjYA== X-Received: by 2002:a1c:7c11:: with SMTP id x17mr11648016wmc.22.1562245599046; Thu, 04 Jul 2019 06:06:39 -0700 (PDT) Received: from apalos (athedsl-428434.home.otenet.gr. [79.131.225.144]) by smtp.gmail.com with ESMTPSA id p4sm4889734wrs.35.2019.07.04.06.06.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Jul 2019 06:06:38 -0700 (PDT) Date: Thu, 4 Jul 2019 16:06:35 +0300 From: Ilias Apalodimas To: Jose Abreu Subject: Re: [PATCH net-next 3/3] net: stmmac: Introducing support for Page Pool Message-ID: <20190704130635.GA10412@apalos> References: <1b254bb7fc6044c5e6e2fdd9e00088d1d13a808b.1562149883.git.joabreu@synopsys.com> <20190704120018.4523a119@carbon> <20190704135414.0dd5df76@carbon> <20190704120441.GA6866@apalos> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190704_060640_748793_A78CD618 X-CRM114-Status: GOOD ( 12.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joao Pinto , Alexandre Torgue , Maxime Ripard , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "David S . Miller" , Chen-Yu Tsai , Maxime Coquelin , Jesper Dangaard Brouer , Giuseppe Cavallaro , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jose, > Thank you all for your review comments ! > > From: Ilias Apalodimas > > > That's why i was concerned on what will happen on > 1000b frames and what the > > memory pressure is going to be. > > The trade off here is copying vs mapping/unmapping. > > Well, the performance numbers I mentioned are for TSO with default MTU > (1500) and using iperf3 with zero-copy. Here follows netperf: > Ok i guess this should be fine. Here's why. You'll allocate an extra memory from page pool API which equals the number of descriptors * 1 page. You also allocate SKB's to copy the data and recycle the page pool buffers. So page_pool won't add any significant memory pressure since we expect *all* it's buffers to be recycled. The SKBs are allocated anyway in the current driver so bottom line you trade off some memory (the page_pool buffers) + a memcpy per packet and skip the dma map/unmap which is the bottleneck in your hardware. I think it's fine Cheers /Ilias _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel