From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,FAKE_REPLY_C,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8331C4649B for ; Fri, 5 Jul 2019 15:44:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A14521852 for ; Fri, 5 Jul 2019 15:44:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lsQT+zO4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="eGB3LBfI"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="bCrhMQNj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A14521852 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=Px/j40XUo70KD1qiS0PE9lRYpJhfBrjAy233EaV15dg=; b=lsQT+zO41DnadD v6K+xeMv4+Flf8xP/GggT+XgjphIfZSYOdxUP/9mEJzeaHlIx23gNQ1m5jBbl0dIrViqmlg9a+eTv s5x8zKwSS2L62QDq5rm7xjTgTWkDUvR8JHi9akWmA2GxjvtiPnCC5s9WmMAx+hCkHtGP1i2zFnaHh Fi9UPUfQbT2l260sqiT5NfTzopV4C3QPBBctjIUXN8TLZU16IqLMmyuIL0NM3aZbHQee1u/a6gAmc pKgg3MxCdWj9fnC9fbbLwDBsksIScICZcfHmvsePGjLFIgqzSokBzZQ6ud/B0itXcrySxwCBA89us V6PsEyudyhI6EXqnNqTA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hjQNQ-0005ZZ-UU; Fri, 05 Jul 2019 15:43:56 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hjQN4-0005BS-6r for linux-arm-kernel@bombadil.infradead.org; Fri, 05 Jul 2019 15:43:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:References:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=YbnmQrRaRRYrhxs7kdeDWzo/0iNG1JldZLQum4NDd4E=; b=eGB3LBfIfS0iQm7VIYCNLHREEp oQRZeotpMqmtxN8tJqTZ/QHg45BYmrTteBcXgZLKL0z6mm86rU5FwYtmyeMVa3yEPqAt0nZ0/AKHT R6e9l77TpSdm3fDXbHJAbIpmGeEvX5Vm8F+6lAyfkh/SwQvE8YXR0j93akxGDeeZxh3HiSAb3E7oX gzIjUKOARw05KvUlmQgz1N+r3qC6Bbc8e9cKPuY1M7o+zPJxHoGbb+Kp7kyN2ZhLyKREZZObum5mV ojfN2AlaPgcjAbVSsVitsnVTHsASfnjIz9chahCjDvljiC6HuZ7ecf0QL6H1vopvS96s7lc7I69a9 vYo4iqtg==; Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hjNfi-00021q-2p for linux-arm-kernel@lists.infradead.org; Fri, 05 Jul 2019 12:50:39 +0000 Received: from localhost (unknown [122.167.76.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1C2E62184C; Fri, 5 Jul 2019 12:50:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562331006; bh=SkovIuVVyMzxFaOZoi3i2O3ZZrHSAu1M22ejXxbkKQw=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=bCrhMQNjtA9DVZoUzobukEaip6FmeXbLASfbZAuxtV8yRQgYaUCv6wTUQMIYNZgGU tfrpEoPDeuagdnvy4wjXW5nsfjkaVrp72kkqyPXvjJjXphh2ei+eBpCPsofGJGhILQ XOdUk4T3JIfbFC4y2LBBSZGE4lVYSsAhDg8Obk5w= Date: Fri, 5 Jul 2019 18:16:46 +0530 From: Vinod Koul To: Sven Van Asbroeck Subject: Re: [PATCH] dmaengine: imx-sdma: fix use-after-free on probe error path Message-ID: <20190705124646.GD2911@vkoul-mobl> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190624140731.24080-1-TheSven73@gmail.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shawn Guo , Sascha Hauer , linux-kernel@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , dmaengine@vger.kernel.org, Dan Williams , Robin Gong , Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24-06-19, 10:07, Sven Van Asbroeck wrote: Quoting orignal patch for better context: > + if (pdata) { > + ret = sdma_get_firmware(sdma, pdata->fw_name); > + if (ret) > + dev_warn(&pdev->dev, "failed to get firmware from platform data\n"); > + } else { > + /* > + * Because that device tree does not encode ROM script address, > + * the RAM script in firmware is mandatory for device tree > + * probe, otherwise it fails. > + */ > + ret = of_property_read_string(np, "fsl,sdma-ram-script-name", > + &fw_name); > + if (ret) > + dev_warn(&pdev->dev, "failed to get firmware name\n"); > + else { > + ret = sdma_get_firmware(sdma, fw_name); > + if (ret) > + dev_warn(&pdev->dev, "failed to get firmware from device tree\n"); > + } > + } > + On 05-07-19, 08:26, Sven Van Asbroeck wrote: > Hi Vinod, > > On Fri, Jul 5, 2019 at 3:32 AM Vinod Koul wrote: > > > > > + if (ret) > > > + dev_warn(&pdev->dev, "failed to get firmware name\n"); > > > > if should have braces! > > Applied after fixing braces! > > checkpatch.pl output after adding braces: > > WARNING: braces {} are not necessary for single statement blocks > #102: FILE: drivers/dma/imx-sdma.c:2165: > + if (ret) { > + dev_warn(&pdev->dev, "failed to get firmware from device tree\n"); > + } there is an else here too! With the patch the checkpatch warns: CHECK: braces {} should be used on all arms of this statement #201: FILE: drivers/dma/imx-sdma.c:2161: + if (ret) [...] + else { [...] Even if the if is a single block and else being multi block, if would need matching brances. With the change pushed: total: 0 errors, 0 warnings, 0 checks, 60 lines checked -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel