From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AE3FC46499 for ; Fri, 5 Jul 2019 15:25:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0917021721 for ; Fri, 5 Jul 2019 15:25:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="u3hJqR/Q"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PBgHa7BQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0917021721 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2VeVepGtn/4cWnd91TXuB6Rq8fDCBza4AQOgWM7v3Vc=; b=u3hJqR/Q6CB+Zb YXnsRTiKhKM24Sez2OCvFaMDzfmX1wUDKcRREjDGG9/+UNOqLvjK0DHQqSgFtsN+Q5gSulqhY/T6Q C9SdEuy8ik2tiGNSRAWnftMzNictxcn4KDtVCZUf059DEKk/ojmCbH56vZRC4kjs3x6r95vN05Yql YTdcv4GZ849pe4zXpx9vjHKdnAVxHDozcrG3FrF4bFYIJjJEfoobW6cFlG/qCgiJPBl+Nr2r4E/Sb goJJ/lVcHSK1WchipAHIgKcqKcum+b01OChQIYnuRv2+ATqgwJpxoBjCRnCzJcEZCEWZ0nzc4zOXF Pj8H3dIAsj9qa0bDvfXw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hjQ58-00062t-NR; Fri, 05 Jul 2019 15:25:02 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hjQ55-0005xn-DO for linux-arm-kernel@lists.infradead.org; Fri, 05 Jul 2019 15:25:01 +0000 Received: by mail-wm1-x343.google.com with SMTP id s15so9955152wmj.3 for ; Fri, 05 Jul 2019 08:24:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=776FeSmsIvO9BAuOMfeYFd0GoNy4MOugdcwM/WuTqsg=; b=PBgHa7BQApvEk3m/50z6wziaw2Yv01CO3uBItHINnz4ARhdSYZX/h/XULODQ7roknM NqXltRZuqAO6z2id1WpdesjpwtCY04gypErUOUmV5gKFajMA67bCIZ3vA1AB5OqhuK3N HgCHq9gQwesyRZ3Ov/OjAyMct5QUJeHySzX6dhh+f/WPco6uM/3JWEehGRyry/l/1TLL wqS2IauQSempUSqAoOw4K9yN+wepHNjVmxhAka9uBfUfOlpSSoqYEFb7Z1CASVzNAc8h XPIdkNm2jMJplehxOjzNqY4i4WKqYPR6DDfU3Aj1paFwNKVSAGg8xVdf6eEw3uKDSMOs CjbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=776FeSmsIvO9BAuOMfeYFd0GoNy4MOugdcwM/WuTqsg=; b=S6jw1+5tHcqve3TooaoEyH6Fikk5LWNVS5IA3XZ3rqnAj86gn1oe6ygi82ADWoZ7GC wL6T3I14nTk+mTrFzHtsftcjbEd3qJEfmlvYMLE1v9ax1Pnozs/8hA6Wcji1ZTzDuqOx amhrJJbPnGwp8oWtSqPssOm/T2A2czPZzkXw4WiH9rNhi/m6RKcOy1dqKhCZTgR27CPW Fvg+8LqE0Qi6cY1ubZudBgL4bHRsk9nqkgIArAaEOoZqkaK/Wuv0xKHhBdQkvYARtw5O n2YDbBMkN28s3vM6vGlGQBgVbFCUgvmZ1v0F9G7ENnResEa15OE9IWTaOtlkdreKym2L +IFw== X-Gm-Message-State: APjAAAUUpJvO81+BHBMXAMU2oq0fYWb74e69D54t90T+UbVcTb9r/woF SBNIOIQFrEasB0btbrFIZgNLXQ== X-Google-Smtp-Source: APXvYqwIn+CAMTXhiaR2OhdbdPqYr3i7rcxaiDbB1iTdnKqBy7Yo87Yv81S7nEiWLwHuACvpF1sKxA== X-Received: by 2002:a7b:c84c:: with SMTP id c12mr3851618wml.70.1562340297200; Fri, 05 Jul 2019 08:24:57 -0700 (PDT) Received: from apalos (athedsl-428434.home.otenet.gr. [79.131.225.144]) by smtp.gmail.com with ESMTPSA id c30sm789893wrb.15.2019.07.05.08.24.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Jul 2019 08:24:56 -0700 (PDT) Date: Fri, 5 Jul 2019 18:24:53 +0300 From: Ilias Apalodimas To: Jose Abreu Subject: Re: [PATCH net-next v3 3/3] net: stmmac: Introducing support for Page Pool Message-ID: <20190705152453.GA24683@apalos> References: <384dab52828c4b65596ef4202562a574eed93b91.1562311299.git.joabreu@synopsys.com> <20190705132905.GA15433@apalos> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190705_082500_007350_D0E2C44B X-CRM114-Status: GOOD ( 13.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Joao Pinto , Alexandre Torgue , Arnd Bergmann , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , Jesper Dangaard Brouer , Giuseppe Cavallaro , "David S . Miller" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jose, On Fri, Jul 05, 2019 at 03:21:16PM +0000, Jose Abreu wrote: > From: Ilias Apalodimas > > > I think this look ok for now. One request though, on page_pool_free > > Thanks for the review! > > > A patch currently under review will slightly change that [1] and [2] > > Can you defer this a bit till that one gets merged? > > The only thing you'll have to do is respin this and replace page_pool_free() > > with page_pool_destroy() > > As we are in end of release cycle net-next may close soon so maybe this > can be merged and I can send a follow-up patch later if that's okay by > you and David ? Well ideally we'd like to get the change in before the merge window ourselves, since we dont want to remove->re-add the same function in stable kernels. If that doesn't go in i am fine fixing it in the next merge window i guess, since it offers substantial speedups Thanks /Ilias _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel