From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86E27C0650E for ; Sat, 6 Jul 2019 20:05:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54C0720836 for ; Sat, 6 Jul 2019 20:05:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mjGqGCJX"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="zZlZPQnW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54C0720836 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vAM5egwgeOevR+Cj99R1/vaxBTgR0gmR7YWMsTWdsCY=; b=mjGqGCJXEX2JjE VO+oOpVE7nVGtcFMrJF1zvDQmq2CVgtQHQHNLDJWbGpvORGl4rNk2aKZeHVvhWLXgGPQf3UDdgJUJ lZRaALwBr6mMY7oChiXRIr44PZgQUf8BSYI8kxH9vNt1H3FFxWqt+NXZmt7BLqwr7HLNUqfY4tkvr aD+jio1GmnrYBc1Xnv6jkPV/hi50UC3Cmf1HEO8k/VGlcQaN3A5dD9oaYFQfWkskkZ62KpCeQTp1A /nLljCtRfMKjR0Da98lRAKYffwl/Fnhp+iP1WScNFXVV6CGXqzZOZl41HWbVkelluSpiMVLZ0SO5F N9wPMG2BFeYktrm1gMyg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hjqvg-0000D0-MV; Sat, 06 Jul 2019 20:05:04 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hjqvf-0008B4-5j; Sat, 06 Jul 2019 20:05:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=xPPW0Y+V/+W7+A623cn0ORRSiYMjDSZxwPi+8VYEw+8=; b=zZlZPQnWO7vWzTIv2p5qgeWLA GnIK2ck7h40M9+OXU5EUmQBqTzoVieREz8v3gF+fPLzkxcs2o6GSOeV2O9vSwrVle6c7TR5MGjq16 1vtuLsc0X6YvKC6kMMGMR4GkNKBuhx4l7+lpeU5Fta0naCQ8wX/WZLPlw1AAnznZ46/3A+rVPfbrf wHycg9H0AvLwT2mGeJlTdtq4+qJvrzMbSnbXySCaa3djbTVK7A5jUZBHwALMHay2AT/GJM+undWJd LZGKOlU+OP7NWviz17K36FI5aXzCDSsEeuYDbAlob/Re5e+SROgktANwFH0NaHr64yTt4lH5JYAOL pcwXiKXWA==; Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by merlin.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hjqva-000360-CV; Sat, 06 Jul 2019 20:04:59 +0000 X-Originating-IP: 90.65.161.137 Received: from localhost (lfbn-1-1545-137.w90-65.abo.wanadoo.fr [90.65.161.137]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 4B50AE0003; Sat, 6 Jul 2019 20:04:20 +0000 (UTC) Date: Sat, 6 Jul 2019 22:04:20 +0200 From: Alexandre Belloni To: Frank Wunderlich Subject: Re: Re: Re: [PATCH v2 3/7] rtc: mt6397: improvements of rtc driver Message-ID: <20190706200420.GE12409@piout.net> References: <20190703164822.17924-1-frank-w@public-files.de> <20190703164822.17924-4-frank-w@public-files.de> <20190704204336.GJ3692@piout.net> <20190705212448.GB12409@piout.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Linus Walleij , linux-kernel@vger.kernel.org, Richard Fontana , Mauro Carvalho Chehab , "Paul E . McKenney" , Lee Jones , linux-rtc@vger.kernel.org, Rob Herring , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Sean Wang , Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , Thomas Gleixner , Eddie Huang , Allison Randal , Alessandro Zummo , Josef Friedl , Greg Kroah-Hartman , Sebastian Reichel , "David S . Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 06/07/2019 18:15:20+0200, Frank Wunderlich wrote: > > Gesendet: Freitag, 05. Juli 2019 um 23:24 Uhr > > Von: "Alexandre Belloni" > > > Let's say the RTC has been used to start your platform, then the irq > > handler will be called as soon as the irq is requested, leading to a > > null pointer dereference. > > i cannot test this with my platform, but i have changed it in my repo > > https://github.com/frank-w/BPI-R2-4.14/commits/5.2-poweroff-mainline > > > Yes and IIRC, I did comment that the rtc change also had to be separated > > from 1/7. > > also this is put in separate commit, can you take a look before i post v3? > > > Also, I really doubt this new compatible is necessary at all as you > > could simply directly use mediatek,mt6397-rtc. > > imho this can confuse because the wrong chip-name is used in dts > This is not true, we do that all the time and the immediate benefit of using the mt6397 compatible is that then there is no need to synchronize between subsystems. If you want to be absolutely conservative, you could use compatible = "mediatek,mt6323-rtc", "mediatek,mt6397-rtc"; in your DT. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel