From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07E79C48BDB for ; Sun, 7 Jul 2019 19:11:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D77B92070D for ; Sun, 7 Jul 2019 19:11:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tdBSSt9E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D77B92070D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zl0pVNrhJesFZom3rXpcUVdI+iZg0cOqhjjcQ+VlulQ=; b=tdBSSt9EzAh3Dk lIJHYeXlEHGVg6ARLkOVUPOf6IIinrHgRt36FTLI+IJLKXn5zgX43dpUkfhH0FQ6Kq1Yykw9BZO1t OkzbruOB0zYse9bso3S1CaCxWs+GPI+adwIyt5W7poWQ1DweKvbvR4Wl/6vnFigyJbXir6YB7pd/7 oSX7KfKX6i330ZsaCVpzoQ8rMiK4oVRYdW1JitiSAtZpJmW/y57pjjdBGTx8CU2BDN9r8bZI6Ge68 bCkRekA4YGBH/jx77BMTTvk+ZMdAMRhW0DPdT33gQGUuGK18wqUYiywGYTsJQNgTrH0eQc6+VMYjJ PMEMwqAdTOy1gp2q5DOQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hkCZ9-0003l5-3J; Sun, 07 Jul 2019 19:11:15 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hkCZ6-0003kD-DA for linux-arm-kernel@lists.infradead.org; Sun, 07 Jul 2019 19:11:13 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 13DCD360; Sun, 7 Jul 2019 12:11:09 -0700 (PDT) Received: from why (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5FA503F738; Sun, 7 Jul 2019 12:11:07 -0700 (PDT) Date: Sun, 7 Jul 2019 20:10:59 +0100 From: Marc Zyngier To: Aleix Roca Nonell Subject: Re: [PATCH 1/6] dt-bindings: interrupt-controller: Document RTD129x Message-ID: <20190707201059.0e86dc71@why> In-Reply-To: <20190707132246.GB13340@arks.localdomain> References: <20190707132246.GB13340@arks.localdomain> Organization: ARM Ltd X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190707_121112_491382_C3130CC8 X-CRM114-Status: GOOD ( 17.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Jason Cooper , linux-kernel@vger.kernel.org, Rob Herring , Matthias Brugger , Thomas Gleixner , Andreas =?UTF-8?B?RsOkcmJlcg==?= , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 7 Jul 2019 15:22:46 +0200 Aleix Roca Nonell wrote: > Add binding for Realtek RTD129x interrupt controller. > > Signed-off-by: Aleix Roca Nonell > --- > .../realtek,rtd129x-intc.txt | 24 +++++++++++++++++++ > 1 file changed, 24 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/realtek,rtd129x-intc.txt > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/realtek,rtd129x-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/realtek,rtd129x-intc.txt > new file mode 100644 > index 000000000000..3ebb7c02afe5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/realtek,rtd129x-intc.txt > @@ -0,0 +1,24 @@ > +Realtek RTD129x IRQ Interrupt Controller > +======================================= > + > +Required properties: > + > +- compatible : Should be one of the following: > + - "realtek,rtd129x-intc-misc" > + - "realtek,rtd129x-intc-iso" What does 'iso' mean in this context? > +- reg : Specifies the address of the ISR, IER and Unmask > + register in couples of "address length". Are these registers actually interleaved with other stuff? What else it in between? > +- interrupts : Specifies the interrupt line which is mux'ed. > +- interrupt-controller : Presence indicates the node as interrupt controller. > +- #interrupt-cells : Shall be 1. See common bindings in interrupt.txt. So I guess this is level only, with an unspecified polarity? No edge interrupts? > + > + > +Example: > + > + interrupt-controller@98007000 { > + compatible = "realtek,rtd129x-iso-irq-mux"; It'd be good if the the example matched the rest of the documentation. > + reg = <0x98007000 0x4 0x98007040 0x4 0x98007004 0x4>; > + interrupts = ; > + interrupt-controller; > + #interrupt-cells = <1>; > + }; Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel