From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAB7BC606C1 for ; Mon, 8 Jul 2019 16:05:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8409B2173E for ; Mon, 8 Jul 2019 16:05:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="L/mow24M"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Cs2Ah93r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8409B2173E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b7BAeA6Gtd1qu1RbOIqRPi3SoXkiep+JrpGBHB1plho=; b=L/mow24MOXXqL+ fplOAd2tQDmEMdgHeEzKWcpl8GawcCTgT8uOQ/b1rbs5RisjbFA/ycov24ZJRqnjUIXYAP5cFW0Co Lg2NDzOMuPTRrFyEKVjx1iMpZtYEWJu7GpAXax0NkJDOlrcZK6UvNtV8etpAJKIuETeotlfkn/Efq I6q4JgeAM3M5mf6PnHrTc2hLzeoKDVpNW/etkUhmc5laHqAFrxpVXUs58er1Q5GLC98TnosJ8aagA M7RPd8iEdYU14eJYJ2C6yLuxN56+b/3Myw6UYcJa0HvBCJsmuUY6U8K+dMHVW/kddN9vWQsPEYaby PTI+zIbHtSHgqhKHcubg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hkW8s-0006C7-NT; Mon, 08 Jul 2019 16:05:26 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hkW8p-0006BT-KR for linux-arm-kernel@lists.infradead.org; Mon, 08 Jul 2019 16:05:25 +0000 Received: by mail-pl1-x641.google.com with SMTP id b7so8517580pls.6 for ; Mon, 08 Jul 2019 09:05:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zj4h3LPFwWX/eUpF2K+qOBGx59jHvRg14Pyk3N6ZIj8=; b=Cs2Ah93rCf/JmPqAEHCi8TaA0qrOFhqaE5hmqN67kLV2wG8IVxSv1FOCkToM6klGMS /YaIg8vFcv6FWh8xwVfD2FPUtzykQLsLETpwwG4c9R3BEmTTtAwRaAzGdgtlHlXkImAI F1WzTwlRb//4YarU/QOUUEE2M2AK69iu2ItsTGuvNxVRVa3H+URF6XKHKZ7fQ+aWbFaI ky91CHbsurW0JSNx0/t2jawrFN/MXPdK/dBRD9asRGleMS2N7pzNupOMnonuoWMHVLbz qdjAWbE7b5bexbDBctTCFMFncQsO+0e2GUGsA4xAU7ElAt6IsCr24C4OC0GKUknqGEen 6PBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=zj4h3LPFwWX/eUpF2K+qOBGx59jHvRg14Pyk3N6ZIj8=; b=Pck+161EHCNAvOKMTzvcNVXPUWN0vb1hytcVg6nrk2QEb8pVZDLdW1IkKqf1j65LRR csotnU057xPx8PnsrG+LOV+3PW5AX7MnplJ0HLL65+c2WnbfG1lw9mlGVT89sNuwgmn3 T1z5HZuL2C6OX64tiiEpkn5CzIf/hjNqeTyXw58sXckBCB+GM8BqkDgmwSmTbp9Ol8cg sz1pntKkPhj4x8arI1iGZBH4GpMYZEE2okMpPywOici8XdvePlDJQfP2fiPy19C0qR+Y //oKwmyTvjm4hLFv0VokVMt19Yv5CI1ClQCTnbJPA56BPBUnoUE63lZRFAXOn4CgESYx Q+lg== X-Gm-Message-State: APjAAAXni4pjiVl+clr1mlAW3YmiU/m5GyCL2xKHw/tm+qngLK5GbASz lKZggDaNUOEHMZ/ms+0gRPI= X-Google-Smtp-Source: APXvYqyTXYeYdUKJVxZlIQ1sQYegDbAsQ25fSAznBmuferVZ1DpzRqW+HYMbh+MGvB0mQxyasDEQeQ== X-Received: by 2002:a17:902:5998:: with SMTP id p24mr25814533pli.110.1562601922829; Mon, 08 Jul 2019 09:05:22 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id t2sm15708380pgo.61.2019.07.08.09.05.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Jul 2019 09:05:21 -0700 (PDT) Date: Mon, 8 Jul 2019 09:05:20 -0700 From: Guenter Roeck To: Sudeep Holla Subject: Re: [PATCH 08/11] firmware: arm_scmi: Drop async flag in sensor_ops->reading_get Message-ID: <20190708160520.GA6741@roeck-us.net> References: <20190708154730.16643-1-sudeep.holla@arm.com> <20190708154730.16643-9-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190708154730.16643-9-sudeep.holla@arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190708_090523_672262_20D47085 X-CRM114-Status: GOOD ( 19.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hwmon@vger.kernel.org, Peng Fan , linux-kernel@vger.kernel.org, Bo Zhang , Jim Quinlan , Volodymyr Babchuk , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 08, 2019 at 04:47:27PM +0100, Sudeep Holla wrote: > SENSOR_DESCRIPTION_GET provides attributes to indicate if the sensor > supports asynchronous read. Ideally we should be able to read that flag > and use asynchronous reads for any sensors with that attribute set. > > In order to add that support, let's drop the async flag passed to > sensor_ops->reading_get and dynamically switch between sync and async > flags based on the attributes as provided by the firmware. > > Cc: Guenter Roeck > Cc: linux-hwmon@vger.kernel.org > Signed-off-by: Sudeep Holla For hwmon: Acked-by: Guenter Roeck Guenter > --- > drivers/firmware/arm_scmi/sensors.c | 4 ++-- > drivers/hwmon/scmi-hwmon.c | 2 +- > include/linux/scmi_protocol.h | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/firmware/arm_scmi/sensors.c b/drivers/firmware/arm_scmi/sensors.c > index 17dbabd8a94a..1b5757c77a35 100644 > --- a/drivers/firmware/arm_scmi/sensors.c > +++ b/drivers/firmware/arm_scmi/sensors.c > @@ -211,7 +211,7 @@ scmi_sensor_trip_point_config(const struct scmi_handle *handle, u32 sensor_id, > } > > static int scmi_sensor_reading_get(const struct scmi_handle *handle, > - u32 sensor_id, bool async, u64 *value) > + u32 sensor_id, u64 *value) > { > int ret; > struct scmi_xfer *t; > @@ -225,7 +225,7 @@ static int scmi_sensor_reading_get(const struct scmi_handle *handle, > > sensor = t->tx.buf; > sensor->id = cpu_to_le32(sensor_id); > - sensor->flags = cpu_to_le32(async ? SENSOR_READ_ASYNC : 0); > + sensor->flags = cpu_to_le32(0); > > ret = scmi_do_xfer(handle, t); > if (!ret) { > diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c > index 0c93fc5ca762..8a7732c0bef3 100644 > --- a/drivers/hwmon/scmi-hwmon.c > +++ b/drivers/hwmon/scmi-hwmon.c > @@ -72,7 +72,7 @@ static int scmi_hwmon_read(struct device *dev, enum hwmon_sensor_types type, > const struct scmi_handle *h = scmi_sensors->handle; > > sensor = *(scmi_sensors->info[type] + channel); > - ret = h->sensor_ops->reading_get(h, sensor->id, false, &value); > + ret = h->sensor_ops->reading_get(h, sensor->id, &value); > if (ret) > return ret; > > diff --git a/include/linux/scmi_protocol.h b/include/linux/scmi_protocol.h > index ea6b72018752..697e30fb9004 100644 > --- a/include/linux/scmi_protocol.h > +++ b/include/linux/scmi_protocol.h > @@ -182,7 +182,7 @@ struct scmi_sensor_ops { > int (*trip_point_config)(const struct scmi_handle *handle, > u32 sensor_id, u8 trip_id, u64 trip_value); > int (*reading_get)(const struct scmi_handle *handle, u32 sensor_id, > - bool async, u64 *value); > + u64 *value); > }; > > /** > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel