From: Sudeep Holla <sudeep.holla@arm.com>
To: Steven Price <steven.price@arm.com>
Cc: Peng Fan <peng.fan@nxp.com>,
linux-kernel@vger.kernel.org,
Bo Zhang <bozhang.zhang@broadcom.com>,
Jim Quinlan <james.quinlan@broadcom.com>,
Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/6] firmware: arm_scmi: Use the term 'message' instead of 'command'
Date: Mon, 8 Jul 2019 18:25:22 +0100 [thread overview]
Message-ID: <20190708172522.GB11197@e107155-lin> (raw)
In-Reply-To: <a04dfc00-9c7a-8321-859d-7a12e7b84ea6@arm.com>
On Mon, Jul 08, 2019 at 05:21:29PM +0100, Steven Price wrote:
> On 08/07/2019 16:43, Sudeep Holla wrote:
> > In preparation to adding support for other two types of messages that
> > SCMI specification mentions, let's replace the term 'command' with the
> > correct term 'message'.
> >
> > As per the specification the messages are of 3 types:
> > commands(synchronous or asynchronous), delayed responses and notifications.
> >
> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> > ---
> > drivers/firmware/arm_scmi/common.h | 10 +++++-----
> > drivers/firmware/arm_scmi/driver.c | 6 +++---
> > 2 files changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi/common.h
> > index 44fd4f9404a9..4349d836b392 100644
> > --- a/drivers/firmware/arm_scmi/common.h
> > +++ b/drivers/firmware/arm_scmi/common.h
> > @@ -48,11 +48,11 @@ struct scmi_msg_resp_prot_version {
> > /**
> > * struct scmi_msg_hdr - Message(Tx/Rx) header
> > *
> > - * @id: The identifier of the command being sent
> > - * @protocol_id: The identifier of the protocol used to send @id command
> > - * @seq: The token to identify the message. when a message/command returns,
> > - * the platform returns the whole message header unmodified including
> > - * the token
> > + * @id: The identifier of the message being sent
> > + * @protocol_id: The identifier of the protocol used to send @id message
> > + * @seq: The token to identify the message. when a message returns, the]
>
> Stray ']' at the end of the line.
>
Thanks for spotting, will fix it.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-08 17:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 15:43 [PATCH 0/6] firmware: arm_scmi: miscellaneous fixes/updates Sudeep Holla
2019-07-08 15:43 ` [PATCH 1/6] firmware: arm_scmi: Use the correct style for SPDX License Identifier Sudeep Holla
2019-07-08 15:43 ` [PATCH 2/6] firmware: arm_scmi: Align few names in sensors protocol with SCMI specification Sudeep Holla
2019-07-08 15:43 ` [PATCH 3/6] firmware: arm_scmi: Remove extra check for invalid length message responses Sudeep Holla
2019-07-08 15:43 ` [PATCH 4/6] firmware: arm_scmi: Fix few trivial typos in comments Sudeep Holla
2019-07-08 15:43 ` [PATCH 5/6] firmware: arm_scmi: Use the term 'message' instead of 'command' Sudeep Holla
2019-07-08 16:21 ` Steven Price
2019-07-08 17:25 ` Sudeep Holla [this message]
2019-07-08 15:43 ` [PATCH 6/6] firmware: arm_scmi: Check if platform has released shmem before using Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190708172522.GB11197@e107155-lin \
--to=sudeep.holla@arm.com \
--cc=bozhang.zhang@broadcom.com \
--cc=james.quinlan@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=steven.price@arm.com \
--cc=volodymyr_babchuk@epam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).