From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8CE1C74A54 for ; Thu, 11 Jul 2019 14:43:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E2A120872 for ; Thu, 11 Jul 2019 14:43:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DszTZxMy"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PZ5eH3m7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E2A120872 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mDPZUQB78+wUquUI8jYNh0XV1Zu9SyFPM7LW79i606U=; b=DszTZxMyOEyyzs aFJV4iyEYQxXWT8sOMqTgncEHYj4V5399zGNDEronc6ZMfryUsriookSMgzlLKlEJOnDG4fhoKDOi X2sRI6v1Yv9j5x3Ws09NUaFmt9GTABOGRuDA8AUCdaLQrvePEI7KtrXW0GGEHoXPtXr5LKzwbw69Y fQ6ScKkJOV4uhJTnQaSY0YNZQ/Mmoo9Lvz1iwwaaQfQWR+niyYbnnk1DMM/A1AYZ3mh1atCfKJvxP GZ4bm2IvwaEFHsYj3icFyhOnO+J1HEXahqTdJo4xjKZ3OUw1eLN+6+L2F3RN2hCZ3njItLz5ZB9XT zvmg+mgj5x/2YHYKcsYA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hlaI5-0003bN-8h; Thu, 11 Jul 2019 14:43:21 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hlaI1-0003aI-ED for linux-arm-kernel@lists.infradead.org; Thu, 11 Jul 2019 14:43:18 +0000 Received: by mail-pg1-x542.google.com with SMTP id i8so3033413pgm.13 for ; Thu, 11 Jul 2019 07:43:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=bVnXpkhdRXKYktl+iS83oNTlUAhPFObnKhn5LwokMJw=; b=PZ5eH3m7RNSLXRKexjamxhZJZMNP9oQiQvVuxRDtw+D/ARroDOjKRysZHlb3hjgV7H +OHnQYpdLV/spoUrGR/xtUx3I42+R02Ro/1dS5X7wPoWi23Yfi0V6MqtVZPC4xMheGaL pwUxFBL8lcHM4TvvDyfanulX+9K44w0WOpODtrdkRXKU+fO+XNgquQYjDohnPTKhHFyn 8qyQF4IrY8XCVyxdrUuqcZGRJ4/aWbGCHKue63IF9WPU68/9IxfE3tfCeJi9t1UMeV5Q ukde9mAMmG8sz4B9tBM4TMd3G74FeEtSRQcNTlFiRHq/tKBkPuvEMCuWLtlvq8Vb5rkp /6YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bVnXpkhdRXKYktl+iS83oNTlUAhPFObnKhn5LwokMJw=; b=abBmQdjbaFmHE93KtY1Z3KlmXoppgXSBXdAgw9nTPXAFystSU3pZvEgO4ksudMPTXR GJMI1hWAAJ9SOg09bNlxGqoPh4Uj6+YFPNlp1mnusTOF7qzqyqU1ol8H3o5kNrlIwnxm Qir5fqC0rRv0Q1EjGBSnrG9ekMqyfq4I7N95jF4+AMsp/Cjou263F/iwQBTtqXaX0JbB Q6mH3g9WHtZcUrGmIOx4l0/zQy/+M+NgmOa4riaiYt6mKBwxYsbtRYMQkNao76Xd9IOS yWzpFs/NL2doCwOhgCXOyAx2+b7qmGtvLG1RXp3NiEznGv91WVZszxDLkSu2w+jin8kV E0ig== X-Gm-Message-State: APjAAAX6pGL4rQ+kmpOwzMCFeO1sHPzQoQlgWQX7CbZOlTAFRM6+y4w3 lqllwM6rxf+MYuoox30d3JW79A== X-Google-Smtp-Source: APXvYqxu5aCDxjj3fkcv7rULRhrqZhb+7XDdmM9S1aURNZVTU+dFXJ+uf4wJfqTHgfPQXF/t8LDwGA== X-Received: by 2002:a17:90a:bf02:: with SMTP id c2mr5310288pjs.73.1562856194457; Thu, 11 Jul 2019 07:43:14 -0700 (PDT) Received: from tuxbook-pro (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id g14sm6276112pgn.8.2019.07.11.07.43.12 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 11 Jul 2019 07:43:13 -0700 (PDT) Date: Thu, 11 Jul 2019 07:44:24 -0700 From: Bjorn Andersson To: Jorge Ramirez-Ortiz Subject: Re: [PATCH v3 02/14] mbox: qcom: add APCS child device for QCS404 Message-ID: <20190711144424.GD7234@tuxbook-pro> References: <20190625164733.11091-1-jorge.ramirez-ortiz@linaro.org> <20190625164733.11091-3-jorge.ramirez-ortiz@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190625164733.11091-3-jorge.ramirez-ortiz@linaro.org> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190711_074317_500092_066EC031 X-CRM114-Status: GOOD ( 16.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, heiko@sntech.de, mturquette@baylibre.com, will.deacon@arm.com, david.brown@linaro.org, linux-clk@vger.kernel.org, jassisinghbrar@gmail.com, sibis@codeaurora.org, jagan@amarulasolutions.com, devicetree@vger.kernel.org, niklas.cassel@linaro.org, arnd@arndb.de, linux-arm-msm@vger.kernel.org, olof@lixom.net, robh+dt@kernel.org, horms+renesas@verge.net.au, linux-arm-kernel@lists.infradead.org, sboyd@kernel.org, linux-kernel@vger.kernel.org, amit.kucheria@linaro.org, vkoul@kernel.org, khasim.mohammed@linaro.org, enric.balletbo@collabora.com, georgi.djakov@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue 25 Jun 09:47 PDT 2019, Jorge Ramirez-Ortiz wrote: > There is clock controller functionality in the APCS hardware block of > qcs404 devices similar to msm8916. > > Co-developed-by: Niklas Cassel > Signed-off-by: Niklas Cassel > Signed-off-by: Jorge Ramirez-Ortiz > --- > drivers/mailbox/qcom-apcs-ipc-mailbox.c | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c > index 705e17a5479c..a05dc3aabac7 100644 > --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c > +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c > @@ -89,16 +89,18 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev) > return ret; > } > > - if (of_device_is_compatible(np, "qcom,msm8916-apcs-kpss-global")) { > - apcs->clk = platform_device_register_data(&pdev->dev, > - "qcom-apcs-msm8916-clk", > - -1, NULL, 0); > - if (IS_ERR(apcs->clk)) > - dev_err(&pdev->dev, "failed to register APCS clk\n"); > - } > - > platform_set_drvdata(pdev, apcs); > > + if (!of_device_is_compatible(np, "qcom,msm8916-apcs-kpss-global") && > + !of_device_is_compatible(np, "qcom,qcs404-apcs-apps-global")) If the remainder of the function was a long snippet I think this would motivate the somewhat unusual early return. But I think it would be cleaner to just add to the existing conditional. Regards, Bjorn > + return 0; > + > + apcs->clk = platform_device_register_data(&pdev->dev, > + "qcom-apcs-msm8916-clk", > + -1, NULL, 0); > + if (IS_ERR(apcs->clk)) > + dev_err(&pdev->dev, "failed to register APCS clk\n"); > + > return 0; > } > > -- > 2.21.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel