From: Sam Ravnborg <sam@ravnborg.org>
To: Nicolas.Ferre@microchip.com,
Joshua Henderson <joshua.henderson@microchip.com>
Cc: alexandre.belloni@bootlin.com, bbrezillon@kernel.org,
airlied@linux.ie, Joshua.Henderson@microchip.com,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/atmel-hlcdc: set layer REP bit to enable replication logic
Date: Fri, 12 Jul 2019 18:21:17 +0200 [thread overview]
Message-ID: <20190712162117.GB18990@ravnborg.org> (raw)
In-Reply-To: <13aa50e4-a726-3f82-b186-79b452199a02@microchip.com>
Hi Joshua.
On Tue, Jul 09, 2019 at 04:24:49PM +0000, Nicolas.Ferre@microchip.com wrote:
> On 09/07/2019 at 17:35, Joshua Henderson wrote:
> > This bit enables replication logic to expand an RGB color less than 24
> > bits, to 24 bits, which is used internally for all formats. Otherwise,
> > the least significant bits are always set to zero and the color may not
> > be what is expected.
> >
> > Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
>
> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
>
> Here is patchwork entry:
> https://patchwork.kernel.org/patch/11037167/
>
> Thanks, best regards,
> Nicolas
>
> > ---
> > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > index eb7c4cf..6f6cf61 100644
> > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > @@ -389,7 +389,7 @@ atmel_hlcdc_plane_update_general_settings(struct atmel_hlcdc_plane *plane,
> > atmel_hlcdc_layer_write_cfg(&plane->layer, ATMEL_HLCDC_LAYER_DMA_CFG,
> > cfg);
> >
> > - cfg = ATMEL_HLCDC_LAYER_DMA;
> > + cfg = ATMEL_HLCDC_LAYER_DMA | ATMEL_HLCDC_LAYER_REP;
> >
> > if (plane->base.type != DRM_PLANE_TYPE_PRIMARY) {
> > cfg |= ATMEL_HLCDC_LAYER_OVR | ATMEL_HLCDC_LAYER_ITER2BL |
Thanks - this gave me an opportunity to read a bit more in the datasheet
of the controller.
Applied to drm-misc-next with Ack from Nicolas.
Sam
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-12 16:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 15:35 [PATCH] drm/atmel-hlcdc: set layer REP bit to enable replication logic Joshua.Henderson
2019-07-09 16:24 ` Nicolas.Ferre
2019-07-12 16:21 ` Sam Ravnborg [this message]
2019-07-12 16:27 ` Boris Brezillon
2019-07-12 16:32 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712162117.GB18990@ravnborg.org \
--to=sam@ravnborg.org \
--cc=Nicolas.Ferre@microchip.com \
--cc=airlied@linux.ie \
--cc=alexandre.belloni@bootlin.com \
--cc=bbrezillon@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=joshua.henderson@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).