From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A464BC76192 for ; Tue, 16 Jul 2019 11:16:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D11F2173B for ; Tue, 16 Jul 2019 11:16:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="A3yiT1pI"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="fN2ZJSMK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D11F2173B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vv4y57fO09zi6dHtFj30U314+3lTMibRfvFv/qHLMOU=; b=A3yiT1pIm9RO4+zeesQ8XFR5J jT+WTke2C+LCtdx5KNxxLRxaRKk7yPd30RcaL9dhcRYxY+wdh7NDwwAq30dEGeulmrO5boWYEWVO4 xML23TnjMSEHQApTqm9mHNy/K7TrOd9JrdoWZVdIlv3NVVpI4OPqRLAWQP59aF+tRzcEhdPiQEZoT LYREHlIz0BRJRfBRlg/kz7F9NsOGCkn/Nxhl4k86yPRvT1BRvDGOChZ/rfxPO3Ewv2AzaR3Chy4Ye QlhHQiGPt1IEQXlmNyq0+6/D4HYzc4J1SDOtaqLQ0KD76WTIaeIKFWPoLbz+Iu1pi1SdDSvQH+fcX yxrLFMHuA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hnLRi-0002XG-Ls; Tue, 16 Jul 2019 11:16:34 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hnLRf-0002WW-9G for linux-arm-kernel@lists.infradead.org; Tue, 16 Jul 2019 11:16:32 +0000 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 914DA2173B; Tue, 16 Jul 2019 11:16:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563275789; bh=cN2YWLRC4s7HqVcjkwb1qbS93xC53QlrYyzApl46WQY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fN2ZJSMKqcmdmKc0QGJ3lMxe98jrFW3RcAvT1o8V3Zx6VySokBYxZyqlAJHyVHMTr P4h8cQBkE2b7uR2KHP5b/MA7uto9Mm/CRyNivfEx+3f6kMERI8JSzOkGe3oU/SC7pE 6CA3s19YptajttSQaXKI1OvrCZj7xRo6mrsVrKTM= Date: Tue, 16 Jul 2019 07:16:28 -0400 From: Sasha Levin To: Sinan Kaya Subject: Re: [PATCH] ARM64/irqchip: Make ACPI_IORT depend on PCI again Message-ID: <20190716111628.GB1943@sasha-vm> References: <20190716040441.12101-1-sashal@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190716_041631_513119_53FBC358 X-CRM114-Status: UNSURE ( 9.57 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@microsoft.com, julien.thierry@arm.com, marc.zyngier@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, stable@kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 16, 2019 at 12:13:23AM -0400, Sinan Kaya wrote: >On 7/16/2019 12:04 AM, Sasha Levin wrote: >> ACPI_IORT lost it's explicit dependency on PCI in c6bb8f89fa6df >> ("ARM64/irqchip: Update ACPI_IORT symbol selection logic") where the >> author has relied on the general dependency of ACPI on PCI. >> >> However, that dependency was finally removed in 5d32a66541c4 ("PCI/ACPI: >> Allow ACPI to be built without CONFIG_PCI set") and now ACPI_IORT breaks >> when we try and build it without PCI support. >> >> This patch brings back the explicit dependency of ACPI_IORT on PCI. >> >> Fixes: 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set") >> Cc: stable@kernel.org >> Signed-off-by: Sasha Levin > >Do you have more detail on what really is broken without this patch? > >It should be possible to build IORT table without PCI. For the record, the errors look like this: drivers/acpi/arm64/iort.o: In function `acpi_iort_init': iort.c:(.init.text+0x47c): undefined reference to `pci_request_acs' Sinan pointed me to an earlier patch he wrote that would fix it (https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/acpi/arm64/iort.c?id=43554cebba50e709b9207c55ceca6bc281748586). Please disregard this patch. -- Thanks, Sasha _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel