From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52983C76192 for ; Tue, 16 Jul 2019 14:47:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2759820880 for ; Tue, 16 Jul 2019 14:47:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Mj+mvr/B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2759820880 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=53O3FOaS8ipFXUPOQecsImy5hz+Qjv3gDovizWf2lLo=; b=Mj+mvr/BodKXwU Mb5BhRfv9CEj78PvEhK3nl6kEoI4huC1xuoSPD0NJFwOniP1O0CMuQqIsBVOutsZ4uHAjT73+81iq uBc46WUJRn1EMt78yMPEYGypJo0/SeWWBJtgyl9bS0AjKI9dUi6bIMIdu8rdnCly9ezt1rX8R6MJC yXQtZhlyyx7zNQsUuFUS0VVA66CDi3ERyN7a6HvAkUXqUknI39tdNbjzou+DGczRuCbx8uU9KKkLa RRBzbXnpnm27SCkhkiiZuZnTLf5jSm33b51s1+9zwHfgfs2W/zYajH2wdtsNBzFha2ARSTWQmvArG PZO1m6xDfTmgcwyFLNeA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hnOk4-00075i-7z; Tue, 16 Jul 2019 14:47:44 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hnOk1-00074n-Td for linux-arm-kernel@lists.infradead.org; Tue, 16 Jul 2019 14:47:43 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2B8F0337; Tue, 16 Jul 2019 07:47:39 -0700 (PDT) Received: from e107155-lin (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 281E63F59C; Tue, 16 Jul 2019 07:47:36 -0700 (PDT) Date: Tue, 16 Jul 2019 15:47:30 +0100 From: Sudeep Holla To: Ulf Hansson Subject: Re: [PATCH 17/18] arm64: dts: Convert to the hierarchical CPU topology layout for MSM8916 Message-ID: <20190716144730.GA7250@e107155-lin> References: <20190513192300.653-1-ulf.hansson@linaro.org> <20190513192300.653-18-ulf.hansson@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190513192300.653-18-ulf.hansson@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190716_074742_046115_DE2B1742 X-CRM114-Status: GOOD ( 14.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Geert Uytterhoeven , Tony Lindgren , Viresh Kumar , Bjorn Andersson , David Brown , Lina Iyer , Lina Iyer , Lorenzo Pieralisi , Kevin Hilman , Daniel Lezcano , Andy Gross , "Raju P . L . S . S . S . N" , Souvik Chakravarty , linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stephen Boyd , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, Amit Kucheria , Sudeep Holla , Niklas Cassel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 13, 2019 at 09:22:59PM +0200, Ulf Hansson wrote: > From: Lina Iyer > > In the hierarchical layout, we are creating power domains around each CPU > and describes the idle states for them inside the power domain provider > node. Note that, the CPU's idle states still needs to be compatible with > "arm,idle-state". > > Furthermore, represent the CPU cluster as a separate master power domain, > powering the CPU's power domains. The cluster node, contains the idle > states for the cluster and each idle state needs to be compatible with the > "domain-idle-state". > > If the running platform is using a PSCI FW that supports the OS initiated > CPU suspend mode, which likely should be the case unless the PSCI FW is > very old, this change triggers the PSCI driver to enable it. > > Cc: Andy Gross > Cc: David Brown > Signed-off-by: Lina Iyer > Co-developed-by: Ulf Hansson > Signed-off-by: Ulf Hansson > --- [...] > @@ -166,12 +170,57 @@ > min-residency-us = <2000>; > local-timer-stop; > }; > + > + CLUSTER_RET: cluster-retention { > + compatible = "domain-idle-state"; > + arm,psci-suspend-param = <0x1000010>; > + entry-latency-us = <500>; > + exit-latency-us = <500>; > + min-residency-us = <2000>; > + }; > + > + CLUSTER_PWRDN: cluster-gdhs { > + compatible = "domain-idle-state"; > + arm,psci-suspend-param = <0x1000030>; > + entry-latency-us = <2000>; > + exit-latency-us = <2000>; > + min-residency-us = <6000>; > + }; > }; > }; I was trying to understand the composition of composite state parameters in this series and that made me look at these DT examples. What format does the above platform use ? I tried matching them to both original as well as extended format and I fail to understand. Assuming original format: State power_state PowerLevel StateType StateID SPC 0x40000002 0(core) 0(Retention) 0x2 (Res0 b[29]=1?) CLUSTER_RET 0x1000010 1(clusters) 0(Retention) 0x10 CLUSTER_PWRDN 0x1000030 1(clusters) 0(Retention?) 0x30 Now extended format: State power_state StateType StateID SPC 0x40000002 0(Retention) 0x40000002 (Res0 b[29]=1?) CLUSTER_RET 0x1000010 0(Retention) 0x1000010 CLUSTER_PWRDN 0x1000030 0(Retention?) 0x1000030 What am I missing ? -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel