From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41BBCC7618F for ; Thu, 18 Jul 2019 15:47:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18568208C0 for ; Thu, 18 Jul 2019 15:47:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dCWyeDO+"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nWn8WF88" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18568208C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H7RoXKD0QVqVFVF2Es9nl7bwSnaV7uJWRVswMQJpAMA=; b=dCWyeDO+R4O06y /i4z5xRC6pmg16p6Xd+VTRQD/NXg4na5e/Kakdwxo97mnFnFJf0HUu00RPL/jPn7SK/3WBuzZcJR+ SiaWwP0hoOU1Stk59gnfbPyIJh5imL7uy8FUg5lpxcRTWy86AUF/gciqMbBMYrYg5NkQyaa/9X1SG nTsxp/XGo5/5OGAZb5Iv3K56lNJk4Q4HfQR9adRvIy/4b95StqvNFxsOh58DRrOqTHMkBdC5u2H9U vv0GILSWvdsUjkYfdAktuL47fVDSgl/nOGhR3LA63QgwFXW9bMUckbOFaSOtfV+EjZbUkWWzxVYbx h+GG3AIq7JctsT5yEeSg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1ho8dC-0000O8-FT; Thu, 18 Jul 2019 15:47:42 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1ho8d8-0000NE-Vu for linux-arm-kernel@lists.infradead.org; Thu, 18 Jul 2019 15:47:40 +0000 Received: by mail-pl1-x644.google.com with SMTP id az7so14080895plb.5 for ; Thu, 18 Jul 2019 08:47:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=560PSkF5dpA+2PC3MPuVU9QamTae65D5mdIYq7VhBIY=; b=nWn8WF88sGLEvnb9ZAUWfxOrZrBijsDaLNjzEI37z6o1PMe1syCzFJjND489Yc6+ou aVo7+CR6iQQ96mDwliLCqsSjegPmbtIDdNhpeI3ea7KXgmpnSjHA4vcaGA2m/Rr84uV0 9eSKIotIn4R+piPaKAR5DA5aP8DXUpoOME4bUODykpR7rYft9hAXH9px3AqDkyn7sR9d V1IbuNQS1Ht1/R5Y14LlHlIfsbhgoKeTOUBG5ig4YH3t86kCHkw2UN2suZv4xDGQGKhp iDyLapqZz5RLFl50jSV9imMDVllyL94z1u+Dypr+q+Xi8zGJgowlVGDUrJiOnmRnbxDM J7Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=560PSkF5dpA+2PC3MPuVU9QamTae65D5mdIYq7VhBIY=; b=HXfgAnCAEZ03dkD8lEIMID8quAeCUjTJGNpFpWdaN6A1LHHCrrJWz1nWQhqCDyKxBm taP8mdAvozNLEF1ttG0qXo8eLUIf8fdUOZFNZIQAmMWD+sfdf/0nDI5B4cbSM0nlPlm+ g+Reu9DOnQGoc7LUvQg37H1oGfVD0y8VcqCg6hsM5QT6qURYM9jJ/8iQLzuCHCLf0kHN XAD8ynkK7an08Ijun7geEk0SFOGn8pSlzUnaJ/P84sBTetW5oLHArSje2awZgfmOMhrY wtjX5DfsPqYLPFrFFO8750t3knGT5Q1FUW6yYQxgGZaYIbSVXMNFDMMUFf1vb6pHoknw xj3A== X-Gm-Message-State: APjAAAVkGAlg4lOvZuf+szkht9PIR6qx5tkcMCXnKE2YLCTN9gI34O/o RIyHRBfqDztVYMXWMC8Mg9+GFA== X-Google-Smtp-Source: APXvYqzrkSMa3rD3Yn3FdqMZT++R/bJ0PBNWrljxysyHeNXu8HhFYIihfsp9bFamug8U81UUhmEQDA== X-Received: by 2002:a17:902:2ac7:: with SMTP id j65mr51319606plb.242.1563464857764; Thu, 18 Jul 2019 08:47:37 -0700 (PDT) Received: from tuxbook-pro (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id f197sm28101015pfa.161.2019.07.18.08.47.36 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 18 Jul 2019 08:47:37 -0700 (PDT) Date: Thu, 18 Jul 2019 08:48:54 -0700 From: Bjorn Andersson To: Mathieu Poirier Subject: Re: [PATCHv8 3/5] arm64: dts: qcom: msm8996: Add Coresight support Message-ID: <20190718154854.GB7234@tuxbook-pro> References: <2fa725fbc09306f1a95befc62715a708b4c0fad0.1562940244.git.saiprakash.ranjan@codeaurora.org> <20190717170050.GB4271@xps15> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190718_084739_035958_003D2F63 X-CRM114-Status: GOOD ( 22.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Sai Prakash Ranjan , Rajendra Nayak , Suzuki K Poulose , Alexander Shishkin , Greg Kroah-Hartman , linux-arm-msm , Marc Gonzalez , Linux Kernel Mailing List , David Brown , Rob Herring , Sibi Sankar , Vivek Gautam , Leo Yan , linux-arm-kernel , Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu 18 Jul 08:31 PDT 2019, Mathieu Poirier wrote: > On Wed, 17 Jul 2019 at 23:47, Sai Prakash Ranjan > wrote: > > > > Hi Mathieu, > > > > On 7/17/2019 10:30 PM, Mathieu Poirier wrote: > > > On Fri, Jul 12, 2019 at 07:46:25PM +0530, Sai Prakash Ranjan wrote: > > >> From: Vivek Gautam > > >> > > >> Enable coresight support by adding device nodes for the > > >> available source, sinks and channel blocks on msm8996. > > >> > > >> This also adds coresight cpu debug nodes. > > >> > > >> Signed-off-by: Vivek Gautam > > >> Signed-off-by: Sai Prakash Ranjan > > >> Reviewed-by: Mathieu Poirier > > >> Acked-By: Suzuki K Poulose > > >> --- > > >> arch/arm64/boot/dts/qcom/msm8996.dtsi | 434 ++++++++++++++++++++++++++ > > >> 1 file changed, 434 insertions(+) > > >> > > > > > > We've gone trhough 8 iteration of this set and I'm still finding checkpatch > > > problems, and I'm not referring to lines over 80 characters. > > > > > > > I only get below 2 checkpatch warnings: > > > > If you are talking about the below one, then it was not added manually. > > It was taken automatically when I pulled in the v7. Should I be > > resending this patch for this? > > That depends if you want David and Andy to pickup your patches - I am > sure they'll point out exactly the same thing. > If it's only the capitalization of "By" then I'll just fix it up as I apply the patches (thanks for pointing it out though!). But it seems the discussion on patch 2 needs to settle(?) (And the merge window has to close). Regards, Bjorn > > > > $ ./scripts/checkpatch.pl -g 2fa725fbc09306f1a95befc62715a708b4c0fad0 > > WARNING: 'Acked-by:' is the preferred signature form > > #14: > > Acked-By: Suzuki K Poulose > > > > WARNING: line over 80 characters > > #154: FILE: arch/arm64/boot/dts/qcom/msm8996.dtsi:763: > > + compatible = "arm,coresight-dynamic-replicator", > > "arm,primecell"; > > > > total: 0 errors, 2 warnings, 440 lines checked > > > > > > -Sai > > > > -- > > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > > of Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel