From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D73CC76195 for ; Thu, 18 Jul 2019 17:49:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0384821019 for ; Thu, 18 Jul 2019 17:49:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GWU0Y+gZ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=poorly.run header.i=@poorly.run header.b="H6wkH+Ja" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0384821019 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=poorly.run Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RqseMqiL97mvEGH9DTUuUP/5+xQPlQBjqdD0tosAh8w=; b=GWU0Y+gZfBosLe XxZSi3qRUGMQ7h/4G7O6zI4GFH+QMmePsLpZvV7XMZuUVJALzXLmFaclZ7hptof8uqrfdo7MaJ6U+ Qa6QP174kctj22rLYQIfcmlhjP7lOrx9QFkHOaVEmbvUzQkPFb9GAr0cntJTxli6k1G9xm2kYzkGg bKXW6h017qFkEwIW+VcH8pM38DgQ6Hhy5q3Wi7HU6NTitDzdzQ5KPP0+OG4tnk98KT979GCSK7CjM c/9c5jeS0licUt0CDKB7zGKUC399PFdiXWk8jqMdnAQYFZ5BMqGNb9paPOaTQRG0i03HM3bg60zNo qsFtG/Brih0+aNOUI8vg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hoAWl-0005CU-2Z; Thu, 18 Jul 2019 17:49:11 +0000 Received: from mail-yw1-xc42.google.com ([2607:f8b0:4864:20::c42]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hoAWh-0005Ap-Cq for linux-arm-kernel@lists.infradead.org; Thu, 18 Jul 2019 17:49:08 +0000 Received: by mail-yw1-xc42.google.com with SMTP id n205so12535126ywb.10 for ; Thu, 18 Jul 2019 10:49:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poorly.run; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=TcHEhgeLg4wCyvAuCh277bKvKMlAO9sX0vLEQ8gbuaw=; b=H6wkH+Ja6Vv25R0kLDO3V4VVaS5ztNs9UcAubxqNI+3MthILN+2PFYat2u8m43w84T dAl/y87QY25XTUsQar+5BsMFrCcgZZr2GZBLhuqyQHujiIFXoQSWk06OtnL5c36L74TC VxBLEPjDdkPgpMEK7dFUqwRJj+fvhBAX6RIVfav3Jv8IKNZRSO4hEMAaQJ+tiTHT8GCC 58uDhvWDf0K5kwRrrRpoDq/1sHOiikD5rNc1/JfuBN9AtOcD6T+9q+hREa6IMDY3J47U XJ1yiFscnRKTlmsHD1sW4ywez1baijXdAhIcjPWMvudB7QJGXHuaGaZUZArhWVOxGrjq WC9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=TcHEhgeLg4wCyvAuCh277bKvKMlAO9sX0vLEQ8gbuaw=; b=fI/Owj5yHI1e6RBU3p1/tHJZiHO/lBr+znBaHG56dD26FRknBvZp2XCNR+Poxsphq9 xh8Hzrh6pcUXkY7Y+gyXRD8CucPBP7d/c0K1joon8n7wQjd3HqSLP3SJq9QNij/WefF5 b9QtO8713XZOtsa9Q/uJIJufkuxr7/F3JJnJhNEljmv/MzOs39GyguMopZWsCxpIhdCC oXr9U1jb0BvQlbqy2ePMMOKZOAnai9rY2jb2KSDwsNf9E2UV8t/GCJWiNO57YidBRlEC 3Gxl7PAZGKYbEAWgY6BMyaM8dlmGvIR5OlRP3SdCORyye60LhQLMkzt0qoIlCCghfqeP ghtg== X-Gm-Message-State: APjAAAXEvYYI+32ZvRVTnDtLqA0/pc6rB7xmr8Myl8ZHyHfktSighTYE JbECKFsb0yumiqkDuBWidOpwLQ== X-Google-Smtp-Source: APXvYqx6Uslwcgt6FXtPTtAmiDT6PsPZOZfSYSrx+5nJhVWwXm/mkQxhro4Op23WJMYr87U7zzwBEg== X-Received: by 2002:a81:5fd4:: with SMTP id t203mr27254887ywb.300.1563472146017; Thu, 18 Jul 2019 10:49:06 -0700 (PDT) Received: from localhost ([2620:0:1013:11:89c6:2139:5435:371d]) by smtp.gmail.com with ESMTPSA id j67sm6907891ywa.39.2019.07.18.10.49.05 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 18 Jul 2019 10:49:05 -0700 (PDT) Date: Thu, 18 Jul 2019 13:49:05 -0400 From: Sean Paul To: Sam Ravnborg Subject: Re: [PATCH v1 04/11] drm/ati_pcigart: drop dependency on drm_os_linux.h Message-ID: <20190718174905.GG31819@art_vandelay> References: <20190718161507.2047-1-sam@ravnborg.org> <20190718161507.2047-5-sam@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190718161507.2047-5-sam@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190718_104907_435383_F7E5C92F X-CRM114-Status: GOOD ( 19.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Liviu Dudau , dri-devel@lists.freedesktop.org, Chris Wilson , Eric Anholt , Rob Herring , Stefan Agner , Maxime Ripard , CK Hu , Thierry Reding , Daniel Vetter , Chunming Zhou , Jani Nikula , Intel Graphics Development , Maarten Lankhorst , linux-mediatek@lists.infradead.org, Lionel Landwerlin , Matthias Brugger , Sean Paul , linux-arm-kernel@lists.infradead.org, Boris Brezillon , Thomas Zimmermann , Rob Clark , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , Philipp Zabel , Christian =?iso-8859-1?Q?K=F6nig?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 18, 2019 at 06:15:00PM +0200, Sam Ravnborg wrote: > The drm_os_linux.h header is deprecated. > Just opencode the sole DRM_WRITE32(). Any plans for the other users of DRM_WRITE()? It seems like it'd be trivial to fix it up for via and mga. I don't really have any background on drm_os_linux.h, but it doesn't seem like it'd be that much more effort to just remove the whole thing. Sean > > Signed-off-by: Sam Ravnborg > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Sean Paul > Cc: David Airlie > Cc: Daniel Vetter > --- > drivers/gpu/drm/ati_pcigart.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/ati_pcigart.c b/drivers/gpu/drm/ati_pcigart.c > index 2a413e291a60..580aa2676358 100644 > --- a/drivers/gpu/drm/ati_pcigart.c > +++ b/drivers/gpu/drm/ati_pcigart.c > @@ -35,7 +35,6 @@ > > #include > #include > -#include > #include > #include > > @@ -169,6 +168,7 @@ int drm_ati_pcigart_init(struct drm_device *dev, struct drm_ati_pcigart_info *ga > page_base = (u32) entry->busaddr[i]; > > for (j = 0; j < (PAGE_SIZE / ATI_PCIGART_PAGE_SIZE); j++) { > + u32 offset; > u32 val; > > switch(gart_info->gart_reg_if) { > @@ -184,10 +184,12 @@ int drm_ati_pcigart_init(struct drm_device *dev, struct drm_ati_pcigart_info *ga > break; > } > if (gart_info->gart_table_location == > - DRM_ATI_GART_MAIN) > + DRM_ATI_GART_MAIN) { > pci_gart[gart_idx] = cpu_to_le32(val); > - else > - DRM_WRITE32(map, gart_idx * sizeof(u32), val); > + } else { > + offset = gart_idx * sizeof(u32); > + writel(val, (void __iomem *)map->handle + offset); > + } > gart_idx++; > page_base += ATI_PCIGART_PAGE_SIZE; > } > -- > 2.20.1 > -- Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel