From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CEE8C7618F for ; Thu, 18 Jul 2019 18:43:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3FB2C208C0 for ; Thu, 18 Jul 2019 18:43:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AZMDIl6w"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="GtkuohfG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3FB2C208C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:From:To:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W9kJvsZnY34s73w06U7QpZUrFNGhhe9D1QNN88HCWV0=; b=AZMDIl6wUbYPjo lhrPloCn+8EmanWIStfc8IO0ZHQtOuBNGUHGYnEKb+PJqdHzKRUNlyK8jz6+/QjQfqDnDvkU7otM4 posk7SW2sJ3/9JFH40ROyKE9rm9xM4MNbfmAg3miTZsLVDXglwTGRoyjndjP/i4MtiDukA1FBmZ7K j/zSNQFr5jyRpyY11jREs0xmOGUDPXuIFU6pwFnZxDPU1LdobtCJzIGUzGjhsWWriIE2Op+a7jSX3 itxkWjUwNy7HXuLosO1N6sUsDwgkEYnkWzPQdEbXjv14mro5J6c9abgkDWUP2JFzuN6JlttDZs+fF wK6PlYJ5LpWhPnl1Y1TA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hoBN2-0002uK-Ft; Thu, 18 Jul 2019 18:43:12 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hoBMz-0002u1-9T for linux-arm-kernel@lists.infradead.org; Thu, 18 Jul 2019 18:43:10 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C8E24205F4; Thu, 18 Jul 2019 18:43:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563475388; bh=VBkTn+UPbfr861rCtiG3QiX2KUeWke+wNUnCFcuWlP0=; h=In-Reply-To:References:Subject:To:Cc:From:Date:From; b=GtkuohfGepI7F95w0kNLfJx59pmM2WlWA0K2xoMJqr03+LEvRyOYelYnS0KD++AGg rXmyhQkLK4//xdrw0Rc6RyLvmnbzPy8ix7/rSyt3YTtxEki4fPGOE+09HFdJ0wk3C0 5yUxeaCyQS1GKnsDAmXfiDQisNTZ7/MivweFS5p4= MIME-Version: 1.0 In-Reply-To: <20190718174901.t6hlrdq6h3xhzlbj@shell.armlinux.org.uk> References: <20190718163809.9D25D217F4@mail.kernel.org> <20190718174901.t6hlrdq6h3xhzlbj@shell.armlinux.org.uk> Subject: Re: [PATCH] ARM: sa1100: convert to common clock framework To: Russell King - ARM Linux admin From: Stephen Boyd User-Agent: alot/0.8.1 Date: Thu, 18 Jul 2019 11:43:07 -0700 Message-Id: <20190718184308.C8E24205F4@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190718_114309_367390_BF179CFE X-CRM114-Status: GOOD ( 24.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Turquette , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Russell King - ARM Linux admin (2019-07-18 10:49:01) > On Thu, Jul 18, 2019 at 09:38:08AM -0700, Stephen Boyd wrote: > > Quoting Russell King (2019-06-29 03:14:10) > > > Convert sa1100 to use the common clock framework. > > > > > > Signed-off-by: Russell King > > > --- > > > Please ack; this is part of a larger series. Thanks. > > > > Just a few minor comments but otherwise looks good to me. > > > > > diff --git a/arch/arm/mach-sa1100/clock.c b/arch/arm/mach-sa1100/clock.c > > > index 6199e87447ca..523ef25618f7 100644 > > > --- a/arch/arm/mach-sa1100/clock.c > > > +++ b/arch/arm/mach-sa1100/clock.c > > > +static const char * const clk_tucr_parents[] = { > > > + "clk32768", "clk3686400", > > > }; > > > > It would be great if you used the new way of specifying clk parents with > > direct pointers instead of strings. See commit fc0c209c147f ("clk: Allow > > parents to be specified without string names") for some details. > > I don't see at the moment how this is used with clk-mux.c - can you > provide some hints? In this case both the parents are clk_hw pointers I think so an array where first element is the clk_hw pointer to clk32768 and the second element is the clk_hw pointer to clk3686400 would be assigned to clk_init_data's parent_hws member. struct clk_hw *clk_tucr_parents[] = { &clk32768_hw, &clk3686400_hw, }; clk_tucr_init.parent_hws = clk_tucr_parents; > > > > > > > -static void clk_gpio27_enable(struct clk *clk) > > > -{ > > > /* > > > * First, set up the 3.6864MHz clock on GPIO 27 for the SA-1111: > > > * (SA-1110 Developer's Manual, section 9.1.2.1) > > > */ > > > + local_irq_save(flags); > > > GAFR |= GPIO_32_768kHz; > > > GPDR |= GPIO_32_768kHz; > > > - TUCR = TUCR_3_6864MHz; > > > + local_irq_restore(flags); > > > + > > > + return 0; > > > } > > > > > > -static void clk_gpio27_disable(struct clk *clk) > > > +static void clk_gpio27_disable(struct clk_hw *hw) > > > { > > > - TUCR = 0; > > > + unsigned long flags; > > > + > > > + local_irq_save(flags); > > > > Why just disable irqs here? > > What do you mean? Do you mean "why are you only disabling IRQs and not > taking a spinlock" or do you mean "why are you disabling IRQs here" ? I mean, why are you disabling irqs and not taking a spinlock? Must be because there's already a spinlock in the clk framework? > > > > > > GPDR &= ~GPIO_32_768kHz; > > > GAFR &= ~GPIO_32_768kHz; > > > + local_irq_restore(flags); > > > } > > > > > > -static void clk_cpu_enable(struct clk *clk) > > > -{ > > > -} > > > +static const struct clk_ops clk_gpio27_ops = { > > > + .enable = clk_gpio27_enable, > > > + .disable = clk_gpio27_disable, > > > +}; > > > > > > -static void clk_cpu_disable(struct clk *clk) > > > -{ > > > -} > > > +static const char * const clk_gpio27_parents[] = { > > > + "tucr-mux", > > > +}; > > > > > > -static unsigned long clk_cpu_get_rate(struct clk *clk) > > > +static const struct clk_init_data clk_gpio27_init_data __initconst = { > > > + .name = "gpio27", > > > + .ops = &clk_gpio27_ops, > > > + .parent_names = clk_gpio27_parents, > > > + .num_parents = ARRAY_SIZE(clk_gpio27_parents), > > > + .flags = CLK_IS_BASIC, > > > > CLK_IS_BASIC is gone. Please don't use it. > > The patch is against 5.1, and you're right, so that was removed for the > version that ended up going upstream. Oh did this get sent to Linus already? I guess I should have reviewed this earlier. > > > > > > +}; > > > + > > > +/* > > > + * Derived from the table 8-1 in the SA1110 manual, the MPLL appears to > > > + * multiply its input rate by 4 x (4 + PPCR). This calculation gives > > > + * the exact rate. The figures given in the table are the rates rounded > > > + * to 100kHz. Stick with sa11x0_getspeed() for the time being. > > [...] > > > +static const struct clk_init_data clk_mpll_init_data __initconst = { > > > + .name = "mpll", > > > + .ops = &clk_mpll_ops, > > > + .parent_names = clk_mpll_parents, > > > + .num_parents = ARRAY_SIZE(clk_mpll_parents), > > > + .flags = CLK_IS_BASIC | CLK_GET_RATE_NOCACHE | CLK_IS_CRITICAL, > > > > Please add a comment about these last two flags so we know why the rate > > can't be cached and the clk is critical. > > Ok, I'll do that with a follow-up patch once the merge window is over. > Ok, thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel