From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8DF8C76190 for ; Mon, 22 Jul 2019 21:32:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BDA8021900 for ; Mon, 22 Jul 2019 21:32:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dhzQyqWi"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="BfaltBBa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BDA8021900 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:From:To:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bsV2Xa4oCpUBUM+7Bzx64ZjYfn3nG+RcW7g8XDWs2cI=; b=dhzQyqWilTC2aV xZ5cNm6YwTS6ZctaHil2Uhllf32GOMGFhtuSyNPU2AtMjqhaI0awxJtiBmSjtpcyDGPbWH4mZxh2L GRkGKL+n0U1T7shdNfYhQWm1pXrfPEed9e3sHoesvBPGFONoSSjiJPwx5tq1Vg28op7v5nlNncJ/I pjFjg9mWcIi51B1NhMhq9ktI9WflD1/8bE3gwbVxkoq2hQ2KVqfVU10Dpd109DFozlDrDfLvufdxw w6e81BGUWDROcse2r34bhK6C9rXJ5sxWDWbQ7jbVkHk0XMlUvEIwIAjVAXFYjqqsqaFlg7eXbRCdS mT9NCvaBn3XF8Rg8vOKA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hpfua-000568-7v; Mon, 22 Jul 2019 21:32:00 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hpfuW-00055Q-TT for linux-arm-kernel@lists.infradead.org; Mon, 22 Jul 2019 21:31:58 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8829E21900; Mon, 22 Jul 2019 21:31:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563831116; bh=6+/sxagahL+li6jU6ojcB6SqYd6K9O6P+akg/i4q2+0=; h=In-Reply-To:References:Subject:To:Cc:From:Date:From; b=BfaltBBaR63zw809ajWmqfGQDl/yVbLLDWguStR5cYjWJ/GgzUzhXBEZgQklIYe5v fyrtKZIvR7r6glea1WEmEK1XwPkZnPsKrbq4rytKZgyDLKVhQTIYVDHistTPyuxI9U ycHtK1Mcc4LGRHW4fgBSqIZvVxVQHjs3kGuHabuM= MIME-Version: 1.0 In-Reply-To: References: <20190625091002.27567-1-codrin.ciubotariu@microchip.com> Subject: Re: [RESEND][PATCH] clk: at91: generated: Truncate divisor to GENERATED_MAX_DIV + 1 To: Codrin.Ciubotariu@microchip.com, Ludovic.Desroches@microchip.com, Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com From: Stephen Boyd User-Agent: alot/0.8.1 Date: Mon, 22 Jul 2019 14:31:55 -0700 Message-Id: <20190722213156.8829E21900@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190722_143156_965805_914354CF X-CRM114-Status: GOOD ( 13.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Nicolas.Ferre@microchip.com (2019-07-03 08:05:24) > On 25/06/2019 at 11:10, Codrin Ciubotariu wrote: > > In clk_generated_determine_rate(), if the divisor is greater than > > GENERATED_MAX_DIV + 1, then the wrong best_rate will be returned. > > If clk_generated_set_rate() will be called later with this wrong > > rate, it will return -EINVAL, so the generated clock won't change > > its value. Do no let the divisor be greater than GENERATED_MAX_DIV + 1. > > > > Fixes: 8c7aa6328947 ("clk: at91: clk-generated: remove useless divisor loop") > > Signed-off-by: Codrin Ciubotariu > > Acked-by: Nicolas Ferre > > Acked-by: Ludovic Desroches > > --- > > > > - The email-server was converting my patches to base64, so I resend it > > using another server; > > - Added acked-bys from Nicolas and Ludovic; > > Stephen, > > I don't see this patch in linux-next and we're already late in the > development cycle: aka ping... > Sorry. I dropped this one. Will pick it up into fixes. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel