From: Stephen Boyd <sboyd@kernel.org>
To: Nathan Huckleberry <nhuck@google.com>,
andy.yan@rock-chips.com, heiko@sntech.de,
mturquette@baylibre.com, zhangqing@rock-chips.com
Cc: clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org,
Nathan Huckleberry <nhuck@google.com>,
linux-rockchip@lists.infradead.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clk: rockchip: Fix -Wunused-const-variable
Date: Mon, 22 Jul 2019 14:35:18 -0700 [thread overview]
Message-ID: <20190722213519.910D321900@mail.kernel.org> (raw)
In-Reply-To: <20190627222220.89175-1-nhuck@google.com>
Quoting Nathan Huckleberry (2019-06-27 15:22:20)
> Clang produces the following warning
>
> drivers/clk/rockchip/clk-rv1108.c:125:7: warning: unused variable
> 'mux_pll_src_3plls_p' [-Wunused-const-variable]
> PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" };
>
> Looks like this variable was never used. Deleting it to remove the
> warning.
>
> Cc: clang-built-linux@googlegroups.com
> Link: https://github.com/ClangBuiltLinux/linux/issues/524
> Signed-off-by: Nathan Huckleberry <nhuck@google.com>
> ---
> drivers/clk/rockchip/clk-rv1108.c | 1 -
> 1 file changed, 1 deletion(-)
Heiko, can you pick this up? Looks like v5.4 material.
>
> diff --git a/drivers/clk/rockchip/clk-rv1108.c b/drivers/clk/rockchip/clk-rv1108.c
> index 96cc6af5632c..5947d3192866 100644
> --- a/drivers/clk/rockchip/clk-rv1108.c
> +++ b/drivers/clk/rockchip/clk-rv1108.c
> @@ -122,7 +122,6 @@ PNAME(mux_usb480m_pre_p) = { "usbphy", "xin24m" };
> PNAME(mux_hdmiphy_phy_p) = { "hdmiphy", "xin24m" };
> PNAME(mux_dclk_hdmiphy_pre_p) = { "dclk_hdmiphy_src_gpll", "dclk_hdmiphy_src_dpll" };
> PNAME(mux_pll_src_4plls_p) = { "dpll", "gpll", "hdmiphy", "usb480m" };
> -PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" };
> PNAME(mux_pll_src_2plls_p) = { "dpll", "gpll" };
> PNAME(mux_pll_src_apll_gpll_p) = { "apll", "gpll" };
> PNAME(mux_aclk_peri_src_p) = { "aclk_peri_src_gpll", "aclk_peri_src_dpll" };
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-22 21:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 22:22 [PATCH] clk: rockchip: Fix -Wunused-const-variable Nathan Huckleberry
2019-06-27 22:32 ` Nick Desaulniers
2019-07-25 19:49 ` Heiko Stuebner
2019-07-22 21:35 ` Stephen Boyd [this message]
2019-07-22 21:44 ` Heiko Stuebner
2019-07-25 19:47 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190722213519.910D321900@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=andy.yan@rock-chips.com \
--cc=clang-built-linux@googlegroups.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=nhuck@google.com \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).