From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B88E3C7618F for ; Mon, 22 Jul 2019 21:35:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8709521900 for ; Mon, 22 Jul 2019 21:35:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="M3JfEsp4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="GAGVTPyo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8709521900 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:From:To:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V8KFd0N4tcq/f014lZg3Hdj46JxX9b5V6QTYEpq4HEc=; b=M3JfEsp4PbUsOW /zfd5DjyinW4iVDFoptkbOMdiOG8cSsIn4ZkJ4d9lLx40lUGWMkeWXy8JwrlrxmC0k/lF30PDjaxq H+MuLNM5J9ngwLo5zu3znlJZU6LtGxrvw9O28NlDM0AfT3G8ztDw1l2TFVuJHgwzdcsQQuxtrBATA Za4Z6Mco4CKeJwmQH1wHtYAu3TzgMUtToIf6ohZIma0n8ZpikDUNX+uZ9isdiASwtUkTMC2TFZ52F +GJJj8DEpbsrfSMYSRQabwcilLjCxqHsCPro6BtnwfVQ7jY5wO4bEQpdYNiukwSZbLAkFB7zlScML 1Sytr8NzjWUa7f3XM/GA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hpfxr-0007Pw-Ir; Mon, 22 Jul 2019 21:35:23 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hpfxn-0007PI-UX; Mon, 22 Jul 2019 21:35:21 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 910D321900; Mon, 22 Jul 2019 21:35:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563831319; bh=DvqIagaTKeWXpuKwat8d9RWOAli9dQa8fn58FFzhj2I=; h=In-Reply-To:References:Subject:To:Cc:From:Date:From; b=GAGVTPyolP5awe7fywjEGXSa+BDWuSSTnWBWAsVtU+GauWTmbacpuxNHMdreyY0QN EzQzfqEkaMrycQ3qhWZuX9MbqqicKiRXSufriuxCYMpk8r1iiXujFYdWxPoyQ9eL4f 9wYmo7SCdgmoiQUleXveC1Ek57aXrsPWQ/3sK3bs= MIME-Version: 1.0 In-Reply-To: <20190627222220.89175-1-nhuck@google.com> References: <20190627222220.89175-1-nhuck@google.com> Subject: Re: [PATCH] clk: rockchip: Fix -Wunused-const-variable To: Nathan Huckleberry , andy.yan@rock-chips.com, heiko@sntech.de, mturquette@baylibre.com, zhangqing@rock-chips.com From: Stephen Boyd User-Agent: alot/0.8.1 Date: Mon, 22 Jul 2019 14:35:18 -0700 Message-Id: <20190722213519.910D321900@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190722_143520_456602_2FD8AD4B X-CRM114-Status: GOOD ( 10.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org, Nathan Huckleberry , linux-rockchip@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Nathan Huckleberry (2019-06-27 15:22:20) > Clang produces the following warning > > drivers/clk/rockchip/clk-rv1108.c:125:7: warning: unused variable > 'mux_pll_src_3plls_p' [-Wunused-const-variable] > PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" }; > > Looks like this variable was never used. Deleting it to remove the > warning. > > Cc: clang-built-linux@googlegroups.com > Link: https://github.com/ClangBuiltLinux/linux/issues/524 > Signed-off-by: Nathan Huckleberry > --- > drivers/clk/rockchip/clk-rv1108.c | 1 - > 1 file changed, 1 deletion(-) Heiko, can you pick this up? Looks like v5.4 material. > > diff --git a/drivers/clk/rockchip/clk-rv1108.c b/drivers/clk/rockchip/clk-rv1108.c > index 96cc6af5632c..5947d3192866 100644 > --- a/drivers/clk/rockchip/clk-rv1108.c > +++ b/drivers/clk/rockchip/clk-rv1108.c > @@ -122,7 +122,6 @@ PNAME(mux_usb480m_pre_p) = { "usbphy", "xin24m" }; > PNAME(mux_hdmiphy_phy_p) = { "hdmiphy", "xin24m" }; > PNAME(mux_dclk_hdmiphy_pre_p) = { "dclk_hdmiphy_src_gpll", "dclk_hdmiphy_src_dpll" }; > PNAME(mux_pll_src_4plls_p) = { "dpll", "gpll", "hdmiphy", "usb480m" }; > -PNAME(mux_pll_src_3plls_p) = { "apll", "gpll", "dpll" }; > PNAME(mux_pll_src_2plls_p) = { "dpll", "gpll" }; > PNAME(mux_pll_src_apll_gpll_p) = { "apll", "gpll" }; > PNAME(mux_aclk_peri_src_p) = { "aclk_peri_src_gpll", "aclk_peri_src_dpll" }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel